Re: [ptxdist] [PATCH] scripts/migrate: use env to find sed

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Fri, Sep 30, 2011 at 09:33:57AM +0200, Andreas Bießmann wrote:
> Some systems do not provide /bin/sed (e.g. OS X), use env to find sed in
> $PATH.

but on Linux this results in:

/usr/bin/env: sed -f: No such file or directory
error: error occured during migration

It seems, adding extra arguments here is not portable.

Michael


> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
> This is a straight forward solution. Another solution is to preprocess the
> scripts in installation phase and insert the values find by configure. This
> could be necessary for handling e.g. gnu style argument splitting with '--' and
> special configurations. For me the gnu coreutils will have a 'g' before the tool
> (gchmod, gchown, ...) cause fink is installing it this way. I guess some other
> BSD users may have some similar problems. But currently there is no framework to
> pre-process some files in scripts directory. So here is the question, how could
> we handle this?
> I can think of some '*.in' files with special markers. They could be found by
> simple globbing in installation phase. Any other solutions?
> 
>  scripts/migrate/migrate_platform |    2 +-
>  scripts/migrate/migrate_ptx      |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/migrate/migrate_platform b/scripts/migrate/migrate_platform
> index 22a58e4..80b3b04 100755
> --- a/scripts/migrate/migrate_platform
> +++ b/scripts/migrate/migrate_platform
> @@ -1,4 +1,4 @@
> -#!/bin/sed -f
> +#!/usr/bin/env sed -f
>  
>  #
>  # from   : ptxdist-1.99.20
> diff --git a/scripts/migrate/migrate_ptx b/scripts/migrate/migrate_ptx
> index 896959a..78691b3 100755
> --- a/scripts/migrate/migrate_ptx
> +++ b/scripts/migrate/migrate_ptx
> @@ -1,4 +1,4 @@
> -#!/bin/sed -f
> +#!/usr/bin/env sed -f
>  
>  #
>  # from   : ptxdist-1.99.10
> -- 
> 1.7.6.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de