[ptxdist] [PATCH] dtc: Do not inhibit linemarker generation

[ptxdist] [PATCH] dtc: Do not inhibit linemarker generation

[Alexander Stein]

Without linemarkers the error messages are somehwat useless.
To demonstrate I picked a random .dts file file from the arm tree in
linux sources:
DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
FATAL ERROR: Unable to parse input tree

If linemarkers are inserted the error message clearly states in which file
which line caused the error:

DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
FATAL ERROR: Unable to parse input tree

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
 scripts/lib/ptxd_make_dts_dtc.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
index d5e8c59..3ee0897 100644
--- a/scripts/lib/ptxd_make_dts_dtc.sh
+++ b/scripts/lib/ptxd_make_dts_dtc.sh
@@ -41,7 +41,6 @@ ptxd_make_dts_dtb() {
 	-Wp,-MD,${tmp_deps} \
 	-Wp,-MT,${tmp_dts} \
 	-nostdinc \
-	-P \
 	-I$(dirname "${dts}") \
 	-I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts \
 	-I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts/include \
-- 
1.8.5.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] dtc: Do not inhibit linemarker generation

[Alexander Stein]

On Monday 04 August 2014 08:49:31, Alexander Stein wrote:
> Without linemarkers the error messages are somehwat useless.
> To demonstrate I picked a random .dts file file from the arm tree in
> linux sources:
> DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> If linemarkers are inserted the error message clearly states in which file
> which line caused the error:
> 
> DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  scripts/lib/ptxd_make_dts_dtc.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
> index d5e8c59..3ee0897 100644
> --- a/scripts/lib/ptxd_make_dts_dtc.sh
> +++ b/scripts/lib/ptxd_make_dts_dtc.sh
> @@ -41,7 +41,6 @@ ptxd_make_dts_dtb() {
>  	-Wp,-MD,${tmp_deps} \
>  	-Wp,-MT,${tmp_dts} \
>  	-nostdinc \
> -	-P \
>  	-I$(dirname "${dts}") \
>  	-I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts \
>  	-I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts/include \
> 

Any feedback on this?

Regards,
Alexander

-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] dtc: Do not inhibit linemarker generation

[Michael Olbrich]

On Mon, Aug 04, 2014 at 08:49:31AM +0200, Alexander Stein wrote:
> Without linemarkers the error messages are somehwat useless.
> To demonstrate I picked a random .dts file file from the arm tree in
> linux sources:
> DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
> FATAL ERROR: Unable to parse input tree
> 
> If linemarkers are inserted the error message clearly states in which file
> which line caused the error:
> 
> DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
> FATAL ERROR: Unable to parse input tree

I think that means that the dtc must understand these markers, right? This
will most likely break building device-trees for older kernels.

Michael

> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  scripts/lib/ptxd_make_dts_dtc.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
> index d5e8c59..3ee0897 100644
> --- a/scripts/lib/ptxd_make_dts_dtc.sh
> +++ b/scripts/lib/ptxd_make_dts_dtc.sh
> @@ -41,7 +41,6 @@ ptxd_make_dts_dtb() {
>  	-Wp,-MD,${tmp_deps} \
>  	-Wp,-MT,${tmp_dts} \
>  	-nostdinc \
> -	-P \
>  	-I$(dirname "${dts}") \
>  	-I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts \
>  	-I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts/include \
> -- 
> 1.8.5.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] dtc: Do not inhibit linemarker generation

[Alexander Stein]

On Monday 18 August 2014 09:50:37, Michael Olbrich wrote:
> On Mon, Aug 04, 2014 at 08:49:31AM +0200, Alexander Stein wrote:
> > Without linemarkers the error messages are somehwat useless.
> > To demonstrate I picked a random .dts file file from the arm tree in
> > linux sources:
> > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> > Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
> > FATAL ERROR: Unable to parse input tree
> > 
> > If linemarkers are inserted the error message clearly states in which file
> > which line caused the error:
> > 
> > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> > Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
> > FATAL ERROR: Unable to parse input tree
> 
> I think that means that the dtc must understand these markers, right? This
> will most likely break building device-trees for older kernels.

AFAICS this included since dtc-1.4.0.

Regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein@systec-electronic.com
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] dtc: Do not inhibit linemarker generation

[Michael Olbrich]

On Mon, Aug 18, 2014 at 01:34:48PM +0200, Alexander Stein wrote:
> On Monday 18 August 2014 09:50:37, Michael Olbrich wrote:
> > On Mon, Aug 04, 2014 at 08:49:31AM +0200, Alexander Stein wrote:
> > > Without linemarkers the error messages are somehwat useless.
> > > To demonstrate I picked a random .dts file file from the arm tree in
> > > linux sources:
> > > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> > > Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > 
> > > If linemarkers are inserted the error message clearly states in which file
> > > which line caused the error:
> > > 
> > > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> > > Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > 
> > I think that means that the dtc must understand these markers, right? This
> > will most likely break building device-trees for older kernels.
> 
> AFAICS this included since dtc-1.4.0.

That's v3.6 Kernel version. We cannot depend on that. However, we already
have a check for '-i' support in ptxd_make_dts_dtb(). That was introduces
in the same commit. I'd accept a patch that adds '-P' only when dtc does
not support '-i'.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de