Re: [ptxdist] [PATCH] u-boot: Add wrapper blacklist

[Alexander Dahl <ada@thorsis.com>]

Hello Michael,

thanks for your explanations, I comment below.

Am Mittwoch, 31. Januar 2018, 16:09:40 CET schrieb Michael Olbrich:
> Build/runtime failures or by knowing what the options mean :-).
> 
> TARGET_HARDEN_RELRO/TARGET_HARDEN_BINDNOW only makes sense for elf
> binaries.
> TARGET_HARDEN_PIE produces relocatable code. A bootloader may be
> relocatable but that requires special handling, so it makes no sense to
> force this from the outside.

I read this as: it makes sense to blacklist those for a bootloader.

> TARGET_DEBUG matches any TARGET_DEBUG_* option. If debugging is enabled
> then extra debug sections may be added to the binary. This can cause
> problems depending on the bootloader build system and linker script. It's
> not useful anyways, so blacklisting this is a good idea.

TARGET_DEBUG_KEEP is set, but if it's a good idea to blacklist those, well 
then this can stay in.

> TARGET_BUILD_ID is just like TARGET_DEBUG. It adds a special elf section.
> It makes no sense for a bootloader and can cause problems.
> 
> I'm not sure which one is responsible for your problem. Is
> TARGET_DEBUG_ENABLE or TARGET_DEBUG_FULL enabled in your BSP?

TARGET_BUILD_ID is set, globally in /usr/local/lib/ptxdist-2017.09.0/
platforms/toolchain_options.in and there is no option to change that. ;-)

If I blacklist nothing, the u-boot.bin has a size of 543M. Just blacklisting 
TARGET_BUILD_ID leads to the normal size of 332K.

To sum it up: I see no need to send an updated v2 of the patch. I would be 
happy if you could merge it for those still using u-boot. :-)

Greets
Alex


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de