mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Andreas Pretzsch <apr@cn-eng.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH v2] rauc: select on-target tools depending on bootloader
Date: Mon,  1 Jul 2019 18:57:53 +0200	[thread overview]
Message-ID: <1562000273-13003-1-git-send-email-apr@cn-eng.de> (raw)
In-Reply-To: <1559322118-9072-1-git-send-email-apr@cn-eng.de>

RAUC relies on tools on the target to interact with the bootloader.
As the bootloader selection is not part of ptxconfig, but platformconfig,
have the user select the bootloader used on the target.
Based on this, auto-select the appropriate package:
  barebox: dt-utils (barebox-state)
  U-Boot: u-boot-tools (fw_printenv, fw_setenv)
  EFI: efibootmgr (efibootmgr)

Regarding GRUB support, grub-editenv from GRUB2 is required. Currently,
there is no "GRUB2" package in ptxdist, so no active option for it.

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
Changes v1->v2:
  - add "if RUNTIME", as these are runtime dependencies
  - reorder down to the other runtime dependencies
  - omit RAUC_GRUB (no GRUB2 in ptxdist), but keep as comment
  - do not use choice, but single selections

Reason for single selections: Beside possible use cases where no specific
bootloader support at all is desired, symbols might be used later for other
decisions, even with multi-bootloader support.

 rules/rauc.in | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/rules/rauc.in b/rules/rauc.in
index 213a1211e..3c5f64b00 100644
--- a/rules/rauc.in
+++ b/rules/rauc.in
@@ -14,6 +14,10 @@ menuconfig RAUC
 	select JSON_GLIB			if RAUC_JSON
 	select SQUASHFS_TOOLS			if RUNTIME
 	select SQUASHFS_TOOLS_UNSQUASHFS	if RUNTIME
+	select DT_UTILS				if RUNTIME && RAUC_BAREBOX
+	select U_BOOT_TOOLS			if RUNTIME && RAUC_U_BOOT
+	#select GRUB2				if RUNTIME && RAUC_GRUB
+	select EFIBOOTMGR			if RUNTIME && RAUC_EFI
 	help
 	  Robust Auto-Update Controller. RAUC controls the update process on embedded linux systems.
 
@@ -78,4 +82,29 @@ config RAUC_BUNDLE_VERSION
 
 endif
 
+config RAUC_BAREBOX
+	bool "barebox support"
+	help
+	  To interact with barebox, barebox-state from dt-utils is used.
+	  Auto-select this package for installation on the target.
+config RAUC_U_BOOT
+	bool "U-Boot support"
+	help
+	  To interact with U-Boot, fw_printenv and fw_setenv from
+	  u-boot-tools are used.
+	  Auto-select this package for installation on the target.
+# Currently, there is no "GRUB2" package in ptxdist. Even with depends
+# on BROKEN, ptxdist will complain about undefined symbol GRUB2.
+# Still, keep this as reference, to have a complete bootloader list.
+#config RAUC_GRUB
+#	bool "GRUB support"
+#	help
+#	  To interact with GRUB2, grub-editenv from grub is used.
+#	  Auto-select this package for installation on the target.
+config RAUC_EFI
+	bool "EFI support"
+	help
+	  To interact with EFI, efibootmgr from efibootmgr is used.
+	  Auto-select this package for installation on the target.
+
 endif
-- 
2.19.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

      parent reply	other threads:[~2019-07-01 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 17:01 [ptxdist] [PATCH] " Andreas Pretzsch
2019-05-31 17:18 ` Andreas Pretzsch
2019-05-31 18:10 ` Michael Olbrich
2019-07-01 16:57 ` Andreas Pretzsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562000273-13003-1-git-send-email-apr@cn-eng.de \
    --to=apr@cn-eng.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox