mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] f2fs-tools: version bump 1.8.0 => 1.12.0
@ 2019-02-12 18:39 jon
  0 siblings, 0 replies; only message in thread
From: jon @ 2019-02-12 18:39 UTC (permalink / raw)
  To: ptxdist; +Cc: Jon Ringle

From: Jon Ringle <jringle@gridpoint.com>

f2fs-tools-1.8.0 fails to build with OSELAS.Toolchain-2018.12.0 due to
changes done in glibc-2.28 that moved 'major', 'minor' and 'makedev'.

The failure is this:
libf2fs.c: In function 'get_rootdev':
libf2fs.c:508:3: warning: implicit declaration of function 'major' [-Wimplicit-function-declaration]
   major(sb.st_dev), minor(sb.st_dev));
   ^~~~~
libf2fs.c:508:21: warning: implicit declaration of function 'minor'; did you mean 'mknod'? [-Wimplicit-function-declaration]
   major(sb.st_dev), minor(sb.st_dev));
                     ^~~~~
                     mknod
libf2fs.c: In function 'get_device_info':
libf2fs.c:794:36: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
   MSG(0, "      %lu blocks per zone\n",
                                    ^~~~
  CCLD     libf2fs.la
make[3]: Leaving directory `/home/local/GRIDPOINT/jringle/git/linux-initramfs/platform-EC1K/build-target/f2fs-tools-1.8.0/lib'
Making all in mkfs
make[3]: Entering directory `/home/local/GRIDPOINT/jringle/git/linux-initramfs/platform-EC1K/build-target/f2fs-tools-1.8.0/mkfs'
  CC       f2fs_format_main.o
  CC       libf2fs_format_la-f2fs_format_utils.lo
  CC       libf2fs_format_la-f2fs_format.lo
  CC       f2fs_format.o
  CC       libf2fs_format_la-f2fs_format_main.lo
  CC       f2fs_format_utils.o
  CCLD     mkfs.f2fs
/opt/OSELAS.Toolchain-2018.12.0/arm-v5te-linux-gnueabi/gcc-8.2.1-glibc-2.28-binutils-2.31.1-kernel-4.19-sanitized/lib/gcc/arm-v5te-linux-gnueabi/8.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ../lib/.libs/libf2fs.so: undefined reference to `minor'
/opt/OSELAS.Toolchain-2018.12.0/arm-v5te-linux-gnueabi/gcc-8.2.1-glibc-2.28-binutils-2.31.1-kernel-4.19-sanitized/lib/gcc/arm-v5te-linux-gnueabi/8.2.1/../../../../arm-v5te-linux-gnueabi/bin/ld: ../lib/.libs/libf2fs.so: undefined reference to `major'
collect2: error: ld returned 1 exit status

Upstream commit fixes the issue:
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?id=191a60fb4b3a761aea0877d02c0ee8d86baf1e93

Signed-off-by: Jon Ringle <jringle@gridpoint.com>
---
 patches/f2fs-tools-1.12.0/autogen.sh | 1 +
 patches/f2fs-tools-1.8.0/autogen.sh  | 1 -
 rules/f2fs-tools.make                | 4 ++--
 3 files changed, 3 insertions(+), 3 deletions(-)
 create mode 120000 patches/f2fs-tools-1.12.0/autogen.sh
 delete mode 120000 patches/f2fs-tools-1.8.0/autogen.sh

diff --git a/patches/f2fs-tools-1.12.0/autogen.sh b/patches/f2fs-tools-1.12.0/autogen.sh
new file mode 120000
index 0000000..9f8a4cb
--- /dev/null
+++ b/patches/f2fs-tools-1.12.0/autogen.sh
@@ -0,0 +1 @@
+../autogen.sh
\ No newline at end of file
diff --git a/patches/f2fs-tools-1.8.0/autogen.sh b/patches/f2fs-tools-1.8.0/autogen.sh
deleted file mode 120000
index 9f8a4cb..0000000
--- a/patches/f2fs-tools-1.8.0/autogen.sh
+++ /dev/null
@@ -1 +0,0 @@
-../autogen.sh
\ No newline at end of file
diff --git a/rules/f2fs-tools.make b/rules/f2fs-tools.make
index 3df61c6..84a835a 100644
--- a/rules/f2fs-tools.make
+++ b/rules/f2fs-tools.make
@@ -18,8 +18,8 @@ endif
 #
 # Paths and names
 #
-F2FS_TOOLS_VERSION	:= 1.8.0
-F2FS_TOOLS_MD5		:= d4132ab388d30da729cb270aeac32bf1
+F2FS_TOOLS_VERSION	:= 1.12.0
+F2FS_TOOLS_MD5		:= 52d8ab4d6b6e7b8d416cb1c0da518fb0
 F2FS_TOOLS		:= f2fs-tools-$(F2FS_TOOLS_VERSION)
 F2FS_TOOLS_SUFFIX	:= tar.xz
 F2FS_TOOLS_URL		:= git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git;tag=v$(F2FS_TOOLS_VERSION)
-- 
1.9.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-02-12 18:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 18:39 [ptxdist] [PATCH] f2fs-tools: version bump 1.8.0 => 1.12.0 jon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox