[ptxdist] [PATCH] kconfig: fix warnings on format

[ptxdist] [PATCH] kconfig: fix warnings on format

[Denis OSTERLAND]

Fixes warnings like:
conf.c:79:3: warning: format not a string literal and no format arguments [-Wformat-security]
   printf(_("aborted!\n\n"));
   ^

Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
---
 scripts/kconfig/lkc.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
index 91ca126ea..6be5da701 100644
--- a/scripts/kconfig/lkc.h
+++ b/scripts/kconfig/lkc.h
@@ -11,6 +11,8 @@
 #ifndef KBUILD_NO_NLS
 # include <libintl.h>
 #else
+# include <features.h>
+__attribute_format_arg__(1)
 static inline const char *gettext(const char *txt) { return txt; }
 static inline void textdomain(const char *domainname) {}
 static inline void bindtextdomain(const char *name, const char *dir) {}
-- 
2.19.2



Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kconfig: fix warnings on format

[Michael Olbrich]

On Wed, Dec 12, 2018 at 10:31:27AM +0000, Denis OSTERLAND wrote:
> Fixes warnings like:
> conf.c:79:3: warning: format not a string literal and no format arguments [-Wformat-security]
>    printf(_("aborted!\n\n"));
>    ^

Can you elaborate what triggers this? I don't get this warning here.
Please add this to the commit message.

In general, I'd prefer to follow upstream and drop the nls support
completely, but that won't happen until I update this stuff to the new
upstream version.

Michael

> Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
> ---
>  scripts/kconfig/lkc.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
> index 91ca126ea..6be5da701 100644
> --- a/scripts/kconfig/lkc.h
> +++ b/scripts/kconfig/lkc.h
> @@ -11,6 +11,8 @@
>  #ifndef KBUILD_NO_NLS
>  # include <libintl.h>
>  #else
> +# include <features.h>
> +__attribute_format_arg__(1)
>  static inline const char *gettext(const char *txt) { return txt; }
>  static inline void textdomain(const char *domainname) {}
>  static inline void bindtextdomain(const char *name, const char *dir) {}
> -- 
> 2.19.2
> 
> 
> 
> Diehl Connectivity Solutions GmbH
> Geschäftsführung: Horst Leonberger
> Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> Nürnberg: HRB 32315
> ___________________________________________________________________________________________________
> 
> Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kconfig: fix warnings on format

[Denis OSTERLAND]

Hi,

Am Mittwoch, den 12.12.2018, 14:29 +0100 schrieb Michael Olbrich:
> On Wed, Dec 12, 2018 at 10:31:27AM +0000, Denis OSTERLAND wrote:
> > 
> > Fixes warnings like:
> > conf.c:79:3: warning: format not a string literal and no format arguments [-Wformat-security]
> >    printf(_("aborted!\n\n"));
> >    ^
> Can you elaborate what triggers this? I don't get this warning here.
> Please add this to the commit message.
Just call make clean all.
Maybe it depends on GCC.
I tested with:
 - gcc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010
 - gcc (Ubuntu 8.1.0-5ubuntu1~16.04) 8.1.0

> 
> In general, I'd prefer to follow upstream and drop the nls support
> completely, but that won't happen until I update this stuff to the new
> upstream version.
Obviously the better solution.

> 
> Michael

Regards Denis

Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kconfig: fix warnings on format

[Denis OSTERLAND]

Hi,

Am Mittwoch, den 12.12.2018, 14:06 +0000 schrieb Denis OSTERLAND:
> Hi,
> 
> Am Mittwoch, den 12.12.2018, 14:29 +0100 schrieb Michael Olbrich:
> > 
> > On Wed, Dec 12, 2018 at 10:31:27AM +0000, Denis OSTERLAND wrote:
> > > 
> > > 
> > > Fixes warnings like:
> > > conf.c:79:3: warning: format not a string literal and no format arguments [-Wformat-security]
> > >    printf(_("aborted!\n\n"));
> > >    ^
> > Can you elaborate what triggers this? I don't get this warning here.
> > Please add this to the commit message.
> Just call make clean all.
> Maybe it depends on GCC.
> I tested with:
>  - gcc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010
>  - gcc (Ubuntu 8.1.0-5ubuntu1~16.04) 8.1.0
I have tested with Debian Buster and Ubuntu Bionic now.
On Ubuntu I get these warnings, but on Debian not.
Maybe Ubuntu configures GCC other than Debian on compile time.

Regards Denis

Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] kconfig: fix warnings on format

[Michael Olbrich]

On Tue, Dec 18, 2018 at 01:26:37PM +0000, Denis OSTERLAND wrote:
> Am Mittwoch, den 12.12.2018, 14:06 +0000 schrieb Denis OSTERLAND:
> > Am Mittwoch, den 12.12.2018, 14:29 +0100 schrieb Michael Olbrich:
> > > 
> > > On Wed, Dec 12, 2018 at 10:31:27AM +0000, Denis OSTERLAND wrote:
> > > > 
> > > > 
> > > > Fixes warnings like:
> > > > conf.c:79:3: warning: format not a string literal and no format arguments [-Wformat-security]
> > > >    printf(_("aborted!\n\n"));
> > > >    ^
> > > Can you elaborate what triggers this? I don't get this warning here.
> > > Please add this to the commit message.
> > Just call make clean all.
> > Maybe it depends on GCC.
> > I tested with:
> >  - gcc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010
> >  - gcc (Ubuntu 8.1.0-5ubuntu1~16.04) 8.1.0
> I have tested with Debian Buster and Ubuntu Bionic now.
> On Ubuntu I get these warnings, but on Debian not.
> Maybe Ubuntu configures GCC other than Debian on compile time.

Ok, I'll apply this. This code will be gone anyways once we update kconfig
to the latest version from Linux.

Michael


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de