mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Guillermo Rodríguez" <guille.rodriguez@gmail.com>
To: ptxdist@pengutronix.de
Cc: "Guillermo Rodríguez" <guille.rodriguez@gmail.com>
Subject: [ptxdist] [PATCH] classpath: Fix building with OpenJDK 1.8
Date: Wed, 31 Oct 2018 16:12:06 +0100	[thread overview]
Message-ID: <1540998726-5238-1-git-send-email-guille.rodriguez@gmail.com> (raw)

Also move back from staging.

Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
---
 .../0001-Fix-building-with-OpenJDK-1.8.patch       | 50 ++++++++++++++++++++++
 patches/classpath-0.99/series                      |  1 +
 rules/classpath.in                                 |  7 +--
 3 files changed, 52 insertions(+), 6 deletions(-)
 create mode 100644 patches/classpath-0.99/0001-Fix-building-with-OpenJDK-1.8.patch
 create mode 100644 patches/classpath-0.99/series

diff --git a/patches/classpath-0.99/0001-Fix-building-with-OpenJDK-1.8.patch b/patches/classpath-0.99/0001-Fix-building-with-OpenJDK-1.8.patch
new file mode 100644
index 0000000..fe7d3ba
--- /dev/null
+++ b/patches/classpath-0.99/0001-Fix-building-with-OpenJDK-1.8.patch
@@ -0,0 +1,50 @@
+This patch makes it possible to build GNU Classpath using javac
+from OpenJDK 1.7 and 1.8.
+
+- From the javac docs: "Classes found through the classpath are
+subject to automatic recompilation if their sources are found."
+javac from OpenJDK 1.7+ will try (and fail) to recompile "standard"
+Java classes (e.g. java/lang/Object.java) when compiling the Java
+test class. Fix this by explicitly passing an empty -sourcepath.
+
+- Test for 1.6 instead of 1.5, as -source/-target 1.5 is deprecated
+in Java 8, and the Makefiles already use -source/-target 1.6 anyway.
+
+---
+ m4/ac_prog_java_works.m4  | 3 ++-
+ m4/ac_prog_javac_works.m4 | 4 ++--
+ 2 files changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/m4/ac_prog_java_works.m4 b/m4/ac_prog_java_works.m4
+index d3f2744..f36318b 100644
+--- a/m4/ac_prog_java_works.m4
++++ b/m4/ac_prog_java_works.m4
+@@ -62,7 +62,8 @@ EOF
+ changequote([, ])dnl
+ if test x$ac_cv_prog_uudecode_base64 != xyes; then
+    	AC_REQUIRE([AC_PROG_JAVAC_WORKS])
+-        if AC_TRY_COMMAND($JAVAC $JAVACFLAGS $JAVA_TEST) && test -s $CLASS_TEST; then
++   	CMD="$JAVAC $JAVACFLAGS -sourcepath '' $JAVA_TEST"
++        if AC_TRY_COMMAND($CMD) && test -s $CLASS_TEST; then
+                 :
+         else
+           echo "configure: failed program was:" >&AC_FD_CC
+diff --git a/m4/ac_prog_javac_works.m4 b/m4/ac_prog_javac_works.m4
+index 7fb298d..fbe24ce 100644
+--- a/m4/ac_prog_javac_works.m4
++++ b/m4/ac_prog_javac_works.m4
+@@ -33,9 +33,9 @@ public class Object
+ }
+ EOF
+ if test x$JAVAC_IS_GCJ = xyes; then
+-  CMD="$JAVAC $JAVACFLAGS -fsource=1.5 -ftarget=1.5 $JAVA_TEST"
++  CMD="$JAVAC $JAVACFLAGS -fsource=1.6 -ftarget=1.6 $JAVA_TEST"
+ else
+-  CMD="$JAVAC $JAVACFLAGS -source 1.5 -target 1.5 $JAVA_TEST"
++  CMD="$JAVAC $JAVACFLAGS -sourcepath '' -source 1.6 -target 1.6 $JAVA_TEST"
+ fi
+ if AC_TRY_COMMAND($CMD) >/dev/null 2>&1; then
+   ac_cv_prog_javac_works=yes
+-- 
+1.9.1
+
diff --git a/patches/classpath-0.99/series b/patches/classpath-0.99/series
new file mode 100644
index 0000000..1fffdbd
--- /dev/null
+++ b/patches/classpath-0.99/series
@@ -0,0 +1 @@
+0001-Fix-building-with-OpenJDK-1.8.patch
diff --git a/rules/classpath.in b/rules/classpath.in
index 67b5dca..16017b2 100644
--- a/rules/classpath.in
+++ b/rules/classpath.in
@@ -1,6 +1,4 @@
-## SECTION=staging
-## old section:
-### SECTION=bytecode_engines
+## SECTION=bytecode_engines
 
 config CLASSPATH
 	tristate
@@ -12,6 +10,3 @@ config CLASSPATH
 	  free core class libraries for use with virtual machines and compilers
 	  for the java programming language.
 
-	  STAGING: remove in ptxdist-2019.04.0
-	  Old, obsolete package that fails to build with OpenJDK 9.
-
-- 
1.9.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2018-10-31 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 15:12 Guillermo Rodríguez [this message]
2018-11-08 16:26 ` Guillermo Rodriguez Garcia
2018-11-16  8:07   ` Michael Olbrich
2018-11-16 11:18     ` Guillermo Rodriguez Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1540998726-5238-1-git-send-email-guille.rodriguez@gmail.com \
    --to=guille.rodriguez@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox