Re: [ptxdist] [PATCH] libgpiod: add support for python3 bindings.

[Denis OSTERLAND <denis.osterland@diehl.com>]

Am Freitag, den 24.08.2018, 15:58 +0200 schrieb Boerje Sewing:
> Signed-off-by: Boerje Sewing <Boerje.Sewing@who-ing.de>
> ---
>  rules/libgpiod.in   |  8 ++++++++
>  rules/libgpiod.make | 20 ++++++++++++++++++--
>  2 files changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/libgpiod.in b/rules/libgpiod.in
> index d3d0c6002..ad52d6f10 100644
> --- a/rules/libgpiod.in
> +++ b/rules/libgpiod.in
> @@ -55,4 +55,12 @@ config LIBGPIOD_GPIOMON
>  	help
>  	  Waits for events on a GPIO line
>  
> +config LIBGPIOD_PYTHON3
> +        bool
> +	prompt "Install python3 bindings"
> +	select PYTHON3
> +	select HOST_SYSTEM_PYTHON3
> +	help
> +	  Provides bindings for Python 3
> +
>  endif
> diff --git a/rules/libgpiod.make b/rules/libgpiod.make
> index ed677c2d5..888597ce3 100644
> --- a/rules/libgpiod.make
> +++ b/rules/libgpiod.make
> @@ -35,8 +35,16 @@ LIBGPIOD_CONF_OPT	:= \
>  	$(CROSS_AUTOCONF_USR) \
>  	--$(call ptx/endis, PTXCONF_LIBGPIOD_TOOLS)-tools \
>  	--disable-tests \
> -	--disable-bindings-cxx \
> -	--disable-bindings-python
> +	--disable-bindings-cxx
> +
> +ifdef PTXCONF_LIBGPIOD_PYTHON3
> +LIBGPIOD_CONF_OPT	+= --enable-bindings-python
> +LIBGPIOD_CONF_ENV := \
> +	$(CROSS_ENV) \
> +	ac_cv_path_PYTHON=$(CROSS_PYTHON3)
> +else
> +LIBGPIOD_CONF_OPT	+= --disable-bindings-python
> +endif
I would suggest:
	--$(call ptx/endis, PTXCONF_LIBGPIOD_PYTHON3)-bindings-python
and
LIBGPIOD_CONF_ENV := \
	$(CROSS_ENV) \
	$(if $(PTXCONF_PYTHON3), ac_cv_path_PYTHON=$(CROSS_PYTHON3))
>  
>  # libgpiod requires kernel headers >= 4.8
>  ifdef PTXCONF_KERNEL_HEADER
> @@ -71,6 +79,14 @@ $(STATEDIR)/libgpiod.targetinstall:
>  			/usr/bin/$$tool); \
>  	done
>  
> +ifdef PTXCONF_LIBGPIOD_PYTHON3
> +	@$(call install_copy, libgpiod, 0, 0, 0755, $(PYTHON3_SITEPACKAGES))
> +	@for file in $(shell cd $(LIBGPIOD_PKGDIR) && find . -name "gpiod.*"); \
> +	do \
> +		$(call install_copy, libgpiod, 0, 0, 0644, -, /$$file); \
> +	done
> +endif
> +
>  	@$(call install_finish, libgpiod)
>  
>  	@$(call touch)
Regards Denis

Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de