mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Denis OSTERLAND <denis.osterland@diehl.com>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>,
	"ada@thorsis.com" <ada@thorsis.com>
Subject: Re: [ptxdist] [PATCH v2] yajl: add new package
Date: Fri, 22 Jun 2018 09:07:58 +0000	[thread overview]
Message-ID: <1529658477.4757.26.camel@diehl.com> (raw)
In-Reply-To: <2841062.rOQmo8klO0@ada>

Am Freitag, den 22.06.2018, 10:52 +0200 schrieb Alexander Dahl:
> Hello Denis,
> 
> > 
> > > 
> > > > 
> > > > +#
> > > > +# autoconf
> > > > +#
> > > > +YAJL_CONF_TOOL	:= cmake
> > > Comment does not match assignment. ;-)
> > You are guess configtool as comment would be better.
> From the 'src-cmake-prog' template you would get:
> 
> #                                                                                                                                                                                    
> # cmake                                                                                                                                                                              
> #                                                                                                                                                                                    
> FOO_CONF_TOOL     := cmake                                                                                                                                                     
> 
> > 
> > Shall we patch it in the template?
> I guess you used the 'target' template, which got you this:
> 
> #                                                                                                                                                                                    
> # autoconf                                                                                                                                                                           
> #                                                                                                                                                                                    
> FOO_CONF_TOOL     := autoconf                                                                                                                                                  
> 
> I would not touch this in the template, it is consistent.
> 
> So I would say, just change the comment to 'cmake' or remove those comment 
> lines. The line assigning the conf tool speaks for itself.
> 
> Greets
> Alex
> 
So I just used the wrong template.
Thanks for that hint.
I will remove the useless comment.

Regards Denis
Diehl AKO Stiftung & Co. KG, Pfannerstraße 75-83, 88239 Wangen im Allgäu
Bereichsvorstand: Dipl.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied)
Sitz der Gesellschaft: Wangen i.A. – Registergericht: Amtsgericht Ulm HRA 620609 – Persönlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung – Sitz: Nürnberg – Registergericht: Amtsgericht Nürnberg HRA 11756 –
Vorstand: Dr.-Ing. Karl Tragl (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus Günther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier
___________________________________________________________________________________________________
Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2018-06-22  9:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 12:56 [ptxdist] [PATCH] " Denis OSTERLAND
2018-06-22  7:19 ` Michael Olbrich
2018-06-22  7:37   ` Denis OSTERLAND
2018-06-22  8:12 ` [ptxdist] [PATCH v2] " Denis OSTERLAND
2018-06-22  8:25   ` Alexander Dahl
2018-06-22  8:32     ` Denis OSTERLAND
2018-06-22  8:52       ` Alexander Dahl
2018-06-22  9:07         ` Denis OSTERLAND [this message]
2018-06-22  9:15           ` Alexander Dahl
2018-06-22  9:42   ` [ptxdist] [PATCH v3] " Denis OSTERLAND

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529658477.4757.26.camel@diehl.com \
    --to=denis.osterland@diehl.com \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox