Re: [ptxdist] [PATCH 2/2] scripts/lib: also create CSV lists on "ptxdist make license-report"

[Andreas Pretzsch <apr@cn-eng.de>]

On Do, 2018-03-29 at 11:46 +0200, Michael Olbrich wrote:
> Please create separate ptxd_make_license_report_tex /
> ptxd_make_license_report_csv functions that are called by
> ptxd_make_license_report.

Ok.

> > +ptxd_make_world_license_write_csv_header() {
> > +	local -r STRING_QUOTE='"'
> > +	local -r CSV_SEPARATOR='|'
> 
> Lower case for local variables.

Ok.

>  Also, I think a helper to write one line
> makes sense. Untested:
> 
> helper() {
> 	string_quote='"'
> 	csv_separator='|'
> 	while [ ${#} -gt 0 ]; do
> 		if [ -n "${1}" ]; then
> 			echo -n "${string_quote}${1}${string_quote}"
> 		fi
> 		shift
> 		if [ [ ${#} -gt 0 ]; do
> 			echo -n ${csv_separator}"
> 		fi
> 	done
> 	echo
> }

Good point. Will do.


> > +ptxd_make_world_license_write_csv() {
> > +	local -r STRING_QUOTE='"'
> > +	local -r CSV_SEPARATOR='|'
> > +	local -a flags=( "${!pkg_license_flags[@]}" )
> > +	local l
> > +
> > +	# not required, seems to be filtered before:
> > +	#case "${pkg_license}" in
> > +	#*ignore*)
> > +	#	# ignore this package, e.g. do not list it in the report
> > +	#	return 0
> > +	#	;;
> > +	#esac

Any comment on this commented section ?
Back then, I copied the logic from somewhere, but filtering was not
required in a real run. Still, kept it as reference.


I'll rework the patch as above over Easter time, plus
  - include section tag (see Denis' patch)
  - squash it into one with "add suffix _tex"


Best regards,
  Andreas

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de