From: "Christoph G. Baumann" <chris@sgoc.de>
To: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>
Subject: [ptxdist] PTXdist 2024.11.0 doesn't seem to check for already downloaded archives
Date: Mon, 25 Nov 2024 15:26:28 +0100 (CET) [thread overview]
Message-ID: <1507610582.167516.1732544788381@email.ionos.de> (raw)
Hello,
recently I wanted to upgrade my project to PTXdist 2024.11.0.
When rerunning a build I was surprised that the 'get' stage downloaded all the archives again despite them already being present in the src directory.
Then I tried to trace this in the files in scripts/lib. It boiled down to a line in scripts/lib/ptxd_make_world_get.sh.
According to 'git log' it was changed in this commit:
commit ca7217db7bf2afe1104b074843403209f7f65aa3
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date: Thu Mar 7 08:28:42 2024 +0100
ptxd_make_world_report_yaml: add source git commit if requested and available
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
When I restored the changed line to
"if [ -n "${pkg_src}" -a \( \! -e "${pkg_src}" -o "${ptxd_make_get_dryrun}" = "y" \) ]; then"
everything worked again as expected.
Was this done intentionally?
Best regards,
Christoph
reply other threads:[~2024-11-25 14:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507610582.167516.1732544788381@email.ionos.de \
--to=chris@sgoc.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox