mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Markus Niebel <niebelm@tqsc.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [RFC PATCH 1/2] nettle: add explicit support for libhogweed
Date: Thu, 09 Mar 2017 18:32:03 +0100	[thread overview]
Message-ID: <1489080723.3690.18.camel@niebel-ws> (raw)
In-Reply-To: <20170309172540.562tq4723mst6hg5@pengutronix.de>

Am Donnerstag, den 09.03.2017, 18:25 +0100 schrieb Michael Olbrich:
> On Thu, Mar 09, 2017 at 05:41:04PM +0100, Markus Niebel wrote:
> > Am Donnerstag, den 09.03.2017, 16:19 +0100 schrieb Michael Olbrich:
> > > On Thu, Mar 09, 2017 at 10:37:06AM +0100, Markus Niebel wrote:
> > > > From: Markus Niebel <Markus.Niebel@tq-group.com>
> > > > 
> > > > the libhogweed part requires libgmp. Let's make it configurable.
> > > > 
> > > 
> > > This seems wrong. My understanding is, that the --enable-mini-gmp options
> > > exists to avoid the libgmp dependency by providing a minimalistic version
> > > of libgmp.
> > > If we want to use the 'real' libgmp (Are there any compelling reasons to do
> > > so?) then the --enable-mini-gmp must be _disabled_ if libhogweed is
> > > installed not the other way around.
> > > 
> > > Also, the '--with-nettle-mini' of gnutls must be changed to 'without'. And
> > > all other nettle users must be reviewed to check if they need libhogweed.
> > > 
> > 
> > I did't noticed that in gnutls. But I came up with this because I
> > noticed a build break during a clean rebuild on our buildserver using
> > ptxdist 2017.01:
> [...]
> 
> Check master (or 2017.03.0): e0749034b9d6f48e61b57eeb3fa331419d1aa397
> ("gnutls: bugfix: remove dependency on libgmp") should fix the problem.
> With --with-nettle-mini the libgmp check is skipped.
> 

Ah, good. Didn't notice that, thank you and sorry for the noise

> Michael
> 

Markus


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2017-03-09 17:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09  9:37 [ptxdist] [RFC PATCH 0/2] fix indirect gnutls dependency Markus Niebel
2017-03-09  9:37 ` [ptxdist] [RFC PATCH 1/2] nettle: add explicit support for libhogweed Markus Niebel
2017-03-09 15:19   ` Michael Olbrich
2017-03-09 16:41     ` Markus Niebel
2017-03-09 17:25       ` Michael Olbrich
2017-03-09 17:32         ` Markus Niebel [this message]
2017-03-09 17:27       ` Clemens Gruber
2017-03-09  9:37 ` [ptxdist] [RFC PATCH 2/2] gnutls: needs libhogweed from nettle Markus Niebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489080723.3690.18.camel@niebel-ws \
    --to=niebelm@tqsc.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox