mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH RFC] ptxdist: Toplevel.make: make ptxdist print work again
@ 2017-03-09 10:16 Markus Niebel
  2017-03-09 11:53 ` Michael Olbrich
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Niebel @ 2017-03-09 10:16 UTC (permalink / raw)
  To: ptxdist; +Cc: m.olbrich, Markus Niebel

From: Markus Niebel <Markus.Niebel@tq-group.com>

The changed print rule broke most of the print functionality resulting
in no output / error return. Splitting the combinded rule into two targets
seems to fix this

Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 rules/other/Toplevel.make | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/rules/other/Toplevel.make b/rules/other/Toplevel.make
index d8c9fc3..4287fb2 100644
--- a/rules/other/Toplevel.make
+++ b/rules/other/Toplevel.make
@@ -107,10 +107,12 @@ include $(PTX_DGEN_DEPS_POST)
 # just the "print" target
 # ----------------------------------------------------------------------------
 
-print-% /print-%: FORCE
+/print-%: FORCE
 	$(if $(filter k,$(MAKEFLAGS)),,$($(if $(filter undefined,$(origin $(*))),$(error $(*) undefined))))
 	@echo "$(if $(filter 1,$(PTXDIST_VERBOSE)),$(*)=)$($(*))"
 
+print-%: /print-%
+
 .PHONY: $(PHONY)
 
 # vim600:set foldmethod=marker:
-- 
1.9.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ptxdist] [PATCH RFC] ptxdist: Toplevel.make: make ptxdist print work again
  2017-03-09 10:16 [ptxdist] [PATCH RFC] ptxdist: Toplevel.make: make ptxdist print work again Markus Niebel
@ 2017-03-09 11:53 ` Michael Olbrich
  2017-03-09 13:54   ` Markus Niebel
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Olbrich @ 2017-03-09 11:53 UTC (permalink / raw)
  To: ptxdist

On Thu, Mar 09, 2017 at 11:16:33AM +0100, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
> 
> The changed print rule broke most of the print functionality resulting
> in no output / error return. Splitting the combinded rule into two targets
> seems to fix this

This seems to be make version dependent. 4.1 works but 3.81 does not.
With this change both seem to work fine.

What's your make version?

Michael

> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> ---
>  rules/other/Toplevel.make | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/other/Toplevel.make b/rules/other/Toplevel.make
> index d8c9fc3..4287fb2 100644
> --- a/rules/other/Toplevel.make
> +++ b/rules/other/Toplevel.make
> @@ -107,10 +107,12 @@ include $(PTX_DGEN_DEPS_POST)
>  # just the "print" target
>  # ----------------------------------------------------------------------------
>  
> -print-% /print-%: FORCE
> +/print-%: FORCE
>  	$(if $(filter k,$(MAKEFLAGS)),,$($(if $(filter undefined,$(origin $(*))),$(error $(*) undefined))))
>  	@echo "$(if $(filter 1,$(PTXDIST_VERBOSE)),$(*)=)$($(*))"
>  
> +print-%: /print-%
> +
>  .PHONY: $(PHONY)
>  
>  # vim600:set foldmethod=marker:
> -- 
> 1.9.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ptxdist] [PATCH RFC] ptxdist: Toplevel.make: make ptxdist print work again
  2017-03-09 11:53 ` Michael Olbrich
@ 2017-03-09 13:54   ` Markus Niebel
  0 siblings, 0 replies; 3+ messages in thread
From: Markus Niebel @ 2017-03-09 13:54 UTC (permalink / raw)
  To: ptxdist

Hello,

Am Donnerstag, den 09.03.2017, 12:53 +0100 schrieb Michael Olbrich:
> On Thu, Mar 09, 2017 at 11:16:33AM +0100, Markus Niebel wrote:
> > From: Markus Niebel <Markus.Niebel@tq-group.com>
> > 
> > The changed print rule broke most of the print functionality resulting
> > in no output / error return. Splitting the combinded rule into two targets
> > seems to fix this
> 
> This seems to be make version dependent. 4.1 works but 3.81 does not.
> With this change both seem to work fine.
> 
> What's your make version?
> 

It's 3.81. I had some thoughts about version deps but did not test -
therefore the RFC.

> Michael
> 

Markus

> > Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> > ---
> >  rules/other/Toplevel.make | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/rules/other/Toplevel.make b/rules/other/Toplevel.make
> > index d8c9fc3..4287fb2 100644
> > --- a/rules/other/Toplevel.make
> > +++ b/rules/other/Toplevel.make
> > @@ -107,10 +107,12 @@ include $(PTX_DGEN_DEPS_POST)
> >  # just the "print" target
> >  # ----------------------------------------------------------------------------
> >  
> > -print-% /print-%: FORCE
> > +/print-%: FORCE
> >  	$(if $(filter k,$(MAKEFLAGS)),,$($(if $(filter undefined,$(origin $(*))),$(error $(*) undefined))))
> >  	@echo "$(if $(filter 1,$(PTXDIST_VERBOSE)),$(*)=)$($(*))"
> >  
> > +print-%: /print-%
> > +
> >  .PHONY: $(PHONY)
> >  
> >  # vim600:set foldmethod=marker:
> > -- 
> > 1.9.1
> > 
> > 
> 



_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-09 13:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-09 10:16 [ptxdist] [PATCH RFC] ptxdist: Toplevel.make: make ptxdist print work again Markus Niebel
2017-03-09 11:53 ` Michael Olbrich
2017-03-09 13:54   ` Markus Niebel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox