From: Markus Niebel <niebelm@tqsc.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH RFC] ptxdist: Toplevel.make: make ptxdist print work again
Date: Thu, 09 Mar 2017 14:54:28 +0100 [thread overview]
Message-ID: <1489067668.3690.5.camel@niebel-ws> (raw)
In-Reply-To: <20170309115312.zmxvgkpka6lm5iti@pengutronix.de>
Hello,
Am Donnerstag, den 09.03.2017, 12:53 +0100 schrieb Michael Olbrich:
> On Thu, Mar 09, 2017 at 11:16:33AM +0100, Markus Niebel wrote:
> > From: Markus Niebel <Markus.Niebel@tq-group.com>
> >
> > The changed print rule broke most of the print functionality resulting
> > in no output / error return. Splitting the combinded rule into two targets
> > seems to fix this
>
> This seems to be make version dependent. 4.1 works but 3.81 does not.
> With this change both seem to work fine.
>
> What's your make version?
>
It's 3.81. I had some thoughts about version deps but did not test -
therefore the RFC.
> Michael
>
Markus
> > Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> > ---
> > rules/other/Toplevel.make | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/rules/other/Toplevel.make b/rules/other/Toplevel.make
> > index d8c9fc3..4287fb2 100644
> > --- a/rules/other/Toplevel.make
> > +++ b/rules/other/Toplevel.make
> > @@ -107,10 +107,12 @@ include $(PTX_DGEN_DEPS_POST)
> > # just the "print" target
> > # ----------------------------------------------------------------------------
> >
> > -print-% /print-%: FORCE
> > +/print-%: FORCE
> > $(if $(filter k,$(MAKEFLAGS)),,$($(if $(filter undefined,$(origin $(*))),$(error $(*) undefined))))
> > @echo "$(if $(filter 1,$(PTXDIST_VERBOSE)),$(*)=)$($(*))"
> >
> > +print-%: /print-%
> > +
> > .PHONY: $(PHONY)
> >
> > # vim600:set foldmethod=marker:
> > --
> > 1.9.1
> >
> >
>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2017-03-09 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 10:16 Markus Niebel
2017-03-09 11:53 ` Michael Olbrich
2017-03-09 13:54 ` Markus Niebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489067668.3690.5.camel@niebel-ws \
--to=niebelm@tqsc.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox