Re: [ptxdist] [PATCH] ntp: remove dependency on libmd (ntp has internal MD5 code)

[Andreas Pretzsch <apr@cn-eng.de>]

On Di, 2016-10-04 at 15:57 +0200, Michael Olbrich wrote:
> > > diff --git a/rules/ntp.in b/rules/ntp.in
> > > index a1aa6d9..9f85406 100644
> > > --- a/rules/ntp.in
> > > +++ b/rules/ntp.in
> > > @@ -8,7 +8,6 @@ menuconfig NTP
> > >  	select LIBC_M
> > >  	select LIBC_RT
> > >  	select GCCLIBS_GCC_S
> > > -	select LIBMD
> > >  	help
> > >  	  Build the standard NTP Daemon Process and supplementary programs.
> > >  	  This conflicts with BSD openntpd.
> > 
> > Michael, you added this dependency with the commit 3ad9148 from
> > 2011-01-18 called "[ntp] fix dependencies". Guess you don't remember
> > exactly why, do you ? ;-)
> 
> I think the version we used back then didn't have the internal
> implementation. And if I read the code correctly, then the current version
> doesn't even check any more and always used the internal version, so this
> patch looks good.

Depending on what is found, it will define its MD5 functions to match
the internal or an external one. I think the old version I'm using even
used the one from libmd when found, but well, it takes its internal one
when there is no libmd or similar. And the internal one looks as good as
the one from libmd, from a very short check.
Anyway, I'd say lets drop the dependency. Best way to handle it.

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de