Re: [ptxdist] [PATCH 4/4] zip: add license information and license file for report generation

[Andreas Pretzsch <apr@cn-eng.de>]

On Di, 2016-10-04 at 15:30 +0200, Michael Olbrich wrote:
> On Mon, Oct 03, 2016 at 09:01:24PM +0200, Andreas Pretzsch wrote:
> > License information is pretty much the same as with unzip, just a newer
> > revision of the (BSD-like) Info-ZIP license (here: version 2007-Mar-4).
> > 
> > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > ---
> >  rules/zip.make | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/rules/zip.make b/rules/zip.make
> > index 09ba4a0..ec59e72 100644
> > --- a/rules/zip.make
> > +++ b/rules/zip.make
> > @@ -26,6 +26,8 @@ ZIP		:= zip$(ZIP_AVERSION)
> >  ZIP_URL		:= $(call ptx/mirror, SF, infozip/$(ZIP_ARCHIVE))
> >  ZIP_SOURCE	:= $(SRCDIR)/$(ZIP_ARCHIVE)
> >  ZIP_DIR		:= $(BUILDDIR)/$(ZIP)
> > +ZIP_LICENSE	:= Info-ZIP, BSD-like
> 
> Nothing with ',' here please. I think only 'Info-ZIP' is correct here, the
> 'BSD-like' is just a different description for the same license, right? And
> 'Info-ZIP' ist the correct SPDX identifiere.

All correct. Just followed the way it is stated in unzip.
But true, descriptive texts ("BSD-like") do not belong here, but should
come out of the real license, resp. from a link/addition to it, on
another place. Not from above tag.

I'll make a V2 of the patch, this time both for unzip and zip packages.
You prefer this patch combined or separate ?


-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de