[ptxdist] [PATCH] ntp: remove dependency on libmd (ntp has internal MD5 code)

[ptxdist] [PATCH] ntp: remove dependency on libmd (ntp has internal MD5 code)

[Andreas Pretzsch]

libmd provides various message digest algorithms.
From these, ntp only uses MD5.
In case there is no system-wide MD5 (e.g. from libmd), ntp will use
its own implementation from lib/isc/md5.c instead.
Therefore, external dependency on libmd can be removed.

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
build-tested with ntp-4.2.6p5, but code still present in ntp-4.2.8p7, so
I expect this will still work. Same applies for only using MD5 from libmd.

 rules/ntp.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rules/ntp.in b/rules/ntp.in
index a1aa6d9..9f85406 100644
--- a/rules/ntp.in
+++ b/rules/ntp.in
@@ -8,7 +8,6 @@ menuconfig NTP
 	select LIBC_M
 	select LIBC_RT
 	select GCCLIBS_GCC_S
-	select LIBMD
 	help
 	  Build the standard NTP Daemon Process and supplementary programs.
 	  This conflicts with BSD openntpd.
-- 
2.9.3


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ntp: remove dependency on libmd (ntp has internal MD5 code)

[Andreas Pretzsch]

On Mo, 2016-10-03 at 21:27 +0200, Andreas Pretzsch wrote:
> libmd provides various message digest algorithms.
> From these, ntp only uses MD5.
> In case there is no system-wide MD5 (e.g. from libmd), ntp will use
> its own implementation from lib/isc/md5.c instead.
> Therefore, external dependency on libmd can be removed.

Main reason I did this is that libmd license tagging is not that easy.
See my parallel mail "libmd: specification of license tags".

Beside, having an external lib just to externalize MD5, esp. one that
seems to be not touched since 2009, might be a bit overkill.


> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> ---
> build-tested with ntp-4.2.6p5, but code still present in ntp-4.2.8p7, so
> I expect this will still work. Same applies for only using MD5 from libmd.

Would be great if someone could check with a more recent ntp, i.e. the
one in ptxdist mainline.
On the concerned BSP here, I have some local
work-around-ntp-tools-behaviour hacks, which I'm not keen on investing
the time for porting...

> 
>  rules/ntp.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/rules/ntp.in b/rules/ntp.in
> index a1aa6d9..9f85406 100644
> --- a/rules/ntp.in
> +++ b/rules/ntp.in
> @@ -8,7 +8,6 @@ menuconfig NTP
>  	select LIBC_M
>  	select LIBC_RT
>  	select GCCLIBS_GCC_S
> -	select LIBMD
>  	help
>  	  Build the standard NTP Daemon Process and supplementary programs.
>  	  This conflicts with BSD openntpd.

Michael, you added this dependency with the commit 3ad9148 from
2011-01-18 called "[ntp] fix dependencies". Guess you don't remember
exactly why, do you ? ;-)


-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ntp: remove dependency on libmd (ntp has internal MD5 code)

[Michael Olbrich]

On Mon, Oct 03, 2016 at 10:31:32PM +0200, Andreas Pretzsch wrote:
> On Mo, 2016-10-03 at 21:27 +0200, Andreas Pretzsch wrote:
> > libmd provides various message digest algorithms.
> > From these, ntp only uses MD5.
> > In case there is no system-wide MD5 (e.g. from libmd), ntp will use
> > its own implementation from lib/isc/md5.c instead.
> > Therefore, external dependency on libmd can be removed.
> 
> Main reason I did this is that libmd license tagging is not that easy.
> See my parallel mail "libmd: specification of license tags".
> 
> Beside, having an external lib just to externalize MD5, esp. one that
> seems to be not touched since 2009, might be a bit overkill.
> 
> 
> > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > ---
> > build-tested with ntp-4.2.6p5, but code still present in ntp-4.2.8p7, so
> > I expect this will still work. Same applies for only using MD5 from libmd.
> 
> Would be great if someone could check with a more recent ntp, i.e. the
> one in ptxdist mainline.
> On the concerned BSP here, I have some local
> work-around-ntp-tools-behaviour hacks, which I'm not keen on investing
> the time for porting...
> 
> > 
> >  rules/ntp.in | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/rules/ntp.in b/rules/ntp.in
> > index a1aa6d9..9f85406 100644
> > --- a/rules/ntp.in
> > +++ b/rules/ntp.in
> > @@ -8,7 +8,6 @@ menuconfig NTP
> >  	select LIBC_M
> >  	select LIBC_RT
> >  	select GCCLIBS_GCC_S
> > -	select LIBMD
> >  	help
> >  	  Build the standard NTP Daemon Process and supplementary programs.
> >  	  This conflicts with BSD openntpd.
> 
> Michael, you added this dependency with the commit 3ad9148 from
> 2011-01-18 called "[ntp] fix dependencies". Guess you don't remember
> exactly why, do you ? ;-)

I think the version we used back then didn't have the internal
implementation. And if I read the code correctly, then the current version
doesn't even check any more and always used the internal version, so this
patch looks good.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ntp: remove dependency on libmd (ntp has internal MD5 code)

[Andreas Pretzsch]

On Di, 2016-10-04 at 15:57 +0200, Michael Olbrich wrote:
> > > diff --git a/rules/ntp.in b/rules/ntp.in
> > > index a1aa6d9..9f85406 100644
> > > --- a/rules/ntp.in
> > > +++ b/rules/ntp.in
> > > @@ -8,7 +8,6 @@ menuconfig NTP
> > >  	select LIBC_M
> > >  	select LIBC_RT
> > >  	select GCCLIBS_GCC_S
> > > -	select LIBMD
> > >  	help
> > >  	  Build the standard NTP Daemon Process and supplementary programs.
> > >  	  This conflicts with BSD openntpd.
> > 
> > Michael, you added this dependency with the commit 3ad9148 from
> > 2011-01-18 called "[ntp] fix dependencies". Guess you don't remember
> > exactly why, do you ? ;-)
> 
> I think the version we used back then didn't have the internal
> implementation. And if I read the code correctly, then the current version
> doesn't even check any more and always used the internal version, so this
> patch looks good.

Depending on what is found, it will define its MD5 functions to match
the internal or an external one. I think the old version I'm using even
used the one from libmd when found, but well, it takes its internal one
when there is no libmd or similar. And the internal one looks as good as
the one from libmd, from a very short check.
Anyway, I'd say lets drop the dependency. Best way to handle it.

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch        Tel. +49-(0)7307-936088-1
Lange Strasse 28a                       Fax: +49-(0)7307-936088-9
89250 Senden, Germany                   email: apr@cn-eng.de


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de