* [ptxdist] [PATCH] ssmtp: bugfix for linking error
@ 2015-10-12 14:23 Oliver Graute
2015-10-29 11:54 ` Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Oliver Graute @ 2015-10-12 14:23 UTC (permalink / raw)
To: ptxdist; +Cc: Oliver Graute
this fixes a linking error if ssl is enabled
Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
---
.../0005-added-lcrypto-in-configure.patch | 21 ++++++++++++++++++++
patches/ssmtp-2.64/series | 1 +
2 files changed, 22 insertions(+)
create mode 100644 patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch
diff --git a/patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch b/patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch
new file mode 100644
index 0000000..9d4af9a
--- /dev/null
+++ b/patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch
@@ -0,0 +1,21 @@
+From: OGR <oliver.graute@neuhaus.de>
+Date: Mon, 12 Oct 2015 16:11:43 +0200
+Subject: [PATCH] added -lcrypto in configure
+
+---
+ configure | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure b/configure
+index 5b6e2c7..7146fdf 100755
+--- a/configure
++++ b/configure
+@@ -1562,7 +1562,7 @@ if test x$enableval = xyes ; then
+ #define HAVE_SSL 1
+ EOF
+
+- LIBS="$LIBS -lssl"
++ LIBS="$LIBS -lssl -lcrypto"
+ fi
+ enableval=""
+
diff --git a/patches/ssmtp-2.64/series b/patches/ssmtp-2.64/series
index b89ac63..9428329 100644
--- a/patches/ssmtp-2.64/series
+++ b/patches/ssmtp-2.64/series
@@ -4,4 +4,5 @@
0002-use-DESTDIR-when-installing.patch
0003-make-installing-non-interactive.patch
0004-configure-if-using-ssl-link-against-libcrypto-too.patch
+0005-added-lcrypto-in-configure.patch
# 4ac054ecac57de7c903a18a4dfcd2270 - git-ptx-patches magic
--
1.7.9.5
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] ssmtp: bugfix for linking error
2015-10-12 14:23 [ptxdist] [PATCH] ssmtp: bugfix for linking error Oliver Graute
@ 2015-10-29 11:54 ` Michael Olbrich
2015-10-29 12:16 ` Oliver Graute
0 siblings, 1 reply; 3+ messages in thread
From: Michael Olbrich @ 2015-10-29 11:54 UTC (permalink / raw)
To: ptxdist
On Mon, Oct 12, 2015 at 04:23:41PM +0200, Oliver Graute wrote:
> this fixes a linking error if ssl is enabled
>
> Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> ---
> .../0005-added-lcrypto-in-configure.patch | 21 ++++++++++++++++++++
> patches/ssmtp-2.64/series | 1 +
> 2 files changed, 22 insertions(+)
> create mode 100644 patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch
>
> diff --git a/patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch b/patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch
> new file mode 100644
> index 0000000..9d4af9a
> --- /dev/null
> +++ b/patches/ssmtp-2.64/0005-added-lcrypto-in-configure.patch
> @@ -0,0 +1,21 @@
> +From: OGR <oliver.graute@neuhaus.de>
> +Date: Mon, 12 Oct 2015 16:11:43 +0200
> +Subject: [PATCH] added -lcrypto in configure
> +
> +---
> + configure | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/configure b/configure
> +index 5b6e2c7..7146fdf 100755
> +--- a/configure
> ++++ b/configure
> +@@ -1562,7 +1562,7 @@ if test x$enableval = xyes ; then
> + #define HAVE_SSL 1
> + EOF
> +
> +- LIBS="$LIBS -lssl"
> ++ LIBS="$LIBS -lssl -lcrypto"
This should not be necessary:
0004-configure-if-using-ssl-link-against-libcrypto-too.patch makes this
change for configure.in and autogen.sh should generate configure from this.
Maybe you copied the patches to a BSP and got a broken autogen.sh?
Michael
> + fi
> + enableval=""
> +
> diff --git a/patches/ssmtp-2.64/series b/patches/ssmtp-2.64/series
> index b89ac63..9428329 100644
> --- a/patches/ssmtp-2.64/series
> +++ b/patches/ssmtp-2.64/series
> @@ -4,4 +4,5 @@
> 0002-use-DESTDIR-when-installing.patch
> 0003-make-installing-non-interactive.patch
> 0004-configure-if-using-ssl-link-against-libcrypto-too.patch
> +0005-added-lcrypto-in-configure.patch
> # 4ac054ecac57de7c903a18a4dfcd2270 - git-ptx-patches magic
> --
> 1.7.9.5
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] ssmtp: bugfix for linking error
2015-10-29 11:54 ` Michael Olbrich
@ 2015-10-29 12:16 ` Oliver Graute
0 siblings, 0 replies; 3+ messages in thread
From: Oliver Graute @ 2015-10-29 12:16 UTC (permalink / raw)
To: ptxdist
On 29/10/15, Michael Olbrich wrote:
> On Mon, Oct 12, 2015 at 04:23:41PM +0200, Oliver Graute wrote:
> > this fixes a linking error if ssl is enabled
> >
> > Signed-off-by: Oliver Graute <oliver.graute@neuhaus.de>
> > +- LIBS="$LIBS -lssl"
> > ++ LIBS="$LIBS -lssl -lcrypto"
>
> This should not be necessary:
> 0004-configure-if-using-ssl-link-against-libcrypto-too.patch makes this
> change for configure.in and autogen.sh should generate configure from this.
> Maybe you copied the patches to a BSP and got a broken autogen.sh?
yes I copied the ssmtp patches to my BSP and missed the autogen.sh link.
What is the right method to prevent such errors?
Best Regards,
Oliver
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-29 12:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-12 14:23 [ptxdist] [PATCH] ssmtp: bugfix for linking error Oliver Graute
2015-10-29 11:54 ` Michael Olbrich
2015-10-29 12:16 ` Oliver Graute
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox