mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] sox: new package for SoX 14.4.2
@ 2015-04-18  0:40 Andreas Pretzsch
  2015-04-27  9:43 ` Michael Olbrich
  2015-05-11 17:56 ` [ptxdist] [PATCH v2] " Andreas Pretzsch
  0 siblings, 2 replies; 4+ messages in thread
From: Andreas Pretzsch @ 2015-04-18  0:40 UTC (permalink / raw)
  To: ptxdist

SoX is the Swiss Army Knife of sound processing utilities.
It can convert audio files to other popular audio file types
and also apply sound effects and filters during the conversion.
See http://sox.sourceforge.net/ for more information.

In addition to libsox, optionally the command-line tool "sox"
and its shortcuts "soxi", "play", "rec" can be installed.

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
The "--disable-openmp" is required, as sox configure detects
OpenMP support.............yes, -fopenmp
but won't run on targets without libgomp (GCC OpenMP) or similar.
As I don't care about this here (probably like most users), just
disable it, like some other packages in ptxdist do it.

Regarding other configure options (like mp3 support and whatnot),
rely on configure auto-detection, instead of adding with/without
options by the dozen. Whoever needs this is welcome to step in.

 rules/sox.in   | 46 +++++++++++++++++++++++++++++++++++++++++++
 rules/sox.make | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 108 insertions(+)
 create mode 100644 rules/sox.in
 create mode 100644 rules/sox.make

diff --git a/rules/sox.in b/rules/sox.in
new file mode 100644
index 0000000..0622f3e
--- /dev/null
+++ b/rules/sox.in
@@ -0,0 +1,46 @@
+## SECTION=multimedia_sound
+
+menuconfig SOX
+	tristate
+	prompt "sox                           "
+	help
+	  SoX is the Swiss Army Knife of sound processing utilities.
+	  It can convert audio files to other popular audio file types
+	  and also apply sound effects and filters during the conversion.
+	  See http://sox.sourceforge.net/ for more information.
+
+if SOX
+
+config SOX_SOX
+	bool
+	default y
+	prompt "Install sox command-line tool"
+	help
+	  Install command-line tool providing all libSoX functionality.
+	  Note: libsox is installed regardless of this option.
+
+config SOX_SOXI
+	bool
+	depends on SOX_SOX
+	prompt "Install symlink soxi => sox"
+	help
+	  Add "soxi" command to display sound file metadata.
+	  Same effect can be achieved with "sox --info".
+
+config SOX_PLAY
+	bool
+	depends on SOX_SOX
+	prompt "Install symlink play => sox"
+	help
+	  Add "play" command to use sox for basic playing.
+	  Same effect can be achieved with "sox <file> -d".
+
+config SOX_REC
+	bool
+	depends on SOX_SOX
+	prompt "Install symlink rec => sox"
+	help
+	  Add "rec" command to use sox for basic recording.
+	  Same effect can be achieved with "sox -d <file>".
+
+endif
diff --git a/rules/sox.make b/rules/sox.make
new file mode 100644
index 0000000..bd03bdc
--- /dev/null
+++ b/rules/sox.make
@@ -0,0 +1,62 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2015 by Andreas Pretzsch <apr@cn-eng.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+PACKAGES-$(PTXCONF_SOX) += sox
+
+SOX_VERSION	:= 14.4.2
+SOX_MD5		:= ba804bb1ce5c71dd484a102a5b27d0dd
+SOX		:= sox-$(SOX_VERSION)
+SOX_SUFFIX	:= tar.bz2
+SOX_URL		:= $(call ptx/mirror, SF, sox/$(SOX).$(SOX_SUFFIX))
+SOX_SOURCE	:= $(SRCDIR)/$(SOX).$(SOX_SUFFIX)
+SOX_DIR		:= $(BUILDDIR)/$(SOX)
+SOX_LICENSE	:= GPLv2+ (tools), LGPLv2.1+ (libs)
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+SOX_CONF_TOOL	:= autoconf
+SOX_CONF_OPT	:= \
+	$(CROSS_AUTOCONF_USR) \
+	--disable-openmp
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/sox.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, sox)
+	@$(call install_fixup, sox,PRIORITY,optional)
+	@$(call install_fixup, sox,SECTION,base)
+	@$(call install_fixup, sox,AUTHOR,"Andreas Pretzsch <apr@cn-eng.de>")
+	@$(call install_fixup, sox,DESCRIPTION,"Sound eXchange, the Swiss Army knife of audio manipulation")
+
+	@$(call install_lib, sox, 0, 0, 0644, libsox)
+ifdef PTXCONF_SOX_SOX
+	@$(call install_copy, sox, 0, 0, 0755, -, /usr/bin/sox)
+endif
+ifdef PTXCONF_SOX_SOXI
+	@$(call install_link, sox, sox, /usr/bin/soxi)
+endif
+ifdef PTXCONF_SOX_PLAY
+	@$(call install_link, sox, sox, /usr/bin/play)
+endif
+ifdef PTXCONF_SOX_REC
+	@$(call install_link, sox, sox, /usr/bin/rec)
+endif
+
+	@$(call install_finish, sox)
+
+	@$(call touch)
+
+# vim: syntax=make
-- 
2.1.3


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] sox: new package for SoX 14.4.2
  2015-04-18  0:40 [ptxdist] [PATCH] sox: new package for SoX 14.4.2 Andreas Pretzsch
@ 2015-04-27  9:43 ` Michael Olbrich
  2015-05-11 17:56   ` Andreas Pretzsch
  2015-05-11 17:56 ` [ptxdist] [PATCH v2] " Andreas Pretzsch
  1 sibling, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2015-04-27  9:43 UTC (permalink / raw)
  To: ptxdist

On Sat, Apr 18, 2015 at 02:40:51AM +0200, Andreas Pretzsch wrote:
> SoX is the Swiss Army Knife of sound processing utilities.
> It can convert audio files to other popular audio file types
> and also apply sound effects and filters during the conversion.
> See http://sox.sourceforge.net/ for more information.
> 
> In addition to libsox, optionally the command-line tool "sox"
> and its shortcuts "soxi", "play", "rec" can be installed.
> 
> Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> ---
> The "--disable-openmp" is required, as sox configure detects
> OpenMP support.............yes, -fopenmp
> but won't run on targets without libgomp (GCC OpenMP) or similar.
> As I don't care about this here (probably like most users), just
> disable it, like some other packages in ptxdist do it.
> 
> Regarding other configure options (like mp3 support and whatnot),
> rely on configure auto-detection, instead of adding with/without
> options by the dozen. Whoever needs this is welcome to step in.
> 
>  rules/sox.in   | 46 +++++++++++++++++++++++++++++++++++++++++++
>  rules/sox.make | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 108 insertions(+)
>  create mode 100644 rules/sox.in
>  create mode 100644 rules/sox.make
> 
> diff --git a/rules/sox.in b/rules/sox.in
> new file mode 100644
> index 0000000..0622f3e
> --- /dev/null
> +++ b/rules/sox.in
> @@ -0,0 +1,46 @@
> +## SECTION=multimedia_sound
> +
> +menuconfig SOX
> +	tristate
> +	prompt "sox                           "
> +	help
> +	  SoX is the Swiss Army Knife of sound processing utilities.
> +	  It can convert audio files to other popular audio file types
> +	  and also apply sound effects and filters during the conversion.
> +	  See http://sox.sourceforge.net/ for more information.
> +
> +if SOX
> +
> +config SOX_SOX
> +	bool
> +	default y
> +	prompt "Install sox command-line tool"
> +	help
> +	  Install command-line tool providing all libSoX functionality.
> +	  Note: libsox is installed regardless of this option.
> +
> +config SOX_SOXI
> +	bool
> +	depends on SOX_SOX
> +	prompt "Install symlink soxi => sox"
> +	help
> +	  Add "soxi" command to display sound file metadata.
> +	  Same effect can be achieved with "sox --info".

I think we can just install this with sox

> +
> +config SOX_PLAY
> +	bool
> +	depends on SOX_SOX
> +	prompt "Install symlink play => sox"
> +	help
> +	  Add "play" command to use sox for basic playing.
> +	  Same effect can be achieved with "sox <file> -d".
> +
> +config SOX_REC
> +	bool
> +	depends on SOX_SOX
> +	prompt "Install symlink rec => sox"
> +	help
> +	  Add "rec" command to use sox for basic recording.
> +	  Same effect can be achieved with "sox -d <file>".

Same for these two, or maybe one option for both.

> +
> +endif
> diff --git a/rules/sox.make b/rules/sox.make
> new file mode 100644
> index 0000000..bd03bdc
> --- /dev/null
> +++ b/rules/sox.make
> @@ -0,0 +1,62 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2015 by Andreas Pretzsch <apr@cn-eng.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +PACKAGES-$(PTXCONF_SOX) += sox
> +
> +SOX_VERSION	:= 14.4.2
> +SOX_MD5		:= ba804bb1ce5c71dd484a102a5b27d0dd
> +SOX		:= sox-$(SOX_VERSION)
> +SOX_SUFFIX	:= tar.bz2
> +SOX_URL		:= $(call ptx/mirror, SF, sox/$(SOX).$(SOX_SUFFIX))
> +SOX_SOURCE	:= $(SRCDIR)/$(SOX).$(SOX_SUFFIX)
> +SOX_DIR		:= $(BUILDDIR)/$(SOX)
> +SOX_LICENSE	:= GPLv2+ (tools), LGPLv2.1+ (libs)
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +SOX_CONF_TOOL	:= autoconf
> +SOX_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	--disable-openmp

You're missing a lot of options here and probably some depencencies in the
.in file as well. Use the global largefile option, --disable-dl-*,
--ensable-symlinks, and either disable, enable (with correct dependency) or
add an option (use ptx/wwo for configure) for each exernal dependency.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/sox.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, sox)
> +	@$(call install_fixup, sox,PRIORITY,optional)
> +	@$(call install_fixup, sox,SECTION,base)
> +	@$(call install_fixup, sox,AUTHOR,"Andreas Pretzsch <apr@cn-eng.de>")
> +	@$(call install_fixup, sox,DESCRIPTION,"Sound eXchange, the Swiss Army knife of audio manipulation")
> +
> +	@$(call install_lib, sox, 0, 0, 0644, libsox)
> +ifdef PTXCONF_SOX_SOX
> +	@$(call install_copy, sox, 0, 0, 0755, -, /usr/bin/sox)
> +endif
> +ifdef PTXCONF_SOX_SOXI
> +	@$(call install_link, sox, sox, /usr/bin/soxi)
> +endif
> +ifdef PTXCONF_SOX_PLAY
> +	@$(call install_link, sox, sox, /usr/bin/play)
> +endif
> +ifdef PTXCONF_SOX_REC
> +	@$(call install_link, sox, sox, /usr/bin/rec)
> +endif
> +
> +	@$(call install_finish, sox)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.1.3
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ptxdist] [PATCH v2] sox: new package for SoX 14.4.2
  2015-04-18  0:40 [ptxdist] [PATCH] sox: new package for SoX 14.4.2 Andreas Pretzsch
  2015-04-27  9:43 ` Michael Olbrich
@ 2015-05-11 17:56 ` Andreas Pretzsch
  1 sibling, 0 replies; 4+ messages in thread
From: Andreas Pretzsch @ 2015-05-11 17:56 UTC (permalink / raw)
  To: ptxdist

SoX is the Swiss Army Knife of sound processing utilities.
It can convert audio files to other popular audio file types
and also apply sound effects and filters during the conversion.
See http://sox.sourceforge.net/ for more information.

In addition to libsox, optionally the command-line tool "sox"
and its shortcuts "soxi", "play", "rec" can be installed.

Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
---
 rules/sox.in   | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 rules/sox.make | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 176 insertions(+)
 create mode 100644 rules/sox.in
 create mode 100644 rules/sox.make

diff --git a/rules/sox.in b/rules/sox.in
new file mode 100644
index 0000000..abaffc3
--- /dev/null
+++ b/rules/sox.in
@@ -0,0 +1,91 @@
+## SECTION=multimedia_sound
+
+menuconfig SOX
+	tristate
+	prompt "sox                           "
+	select FILE		if SOX_MAGIC
+	select LIBPNG		if SOX_PNG
+	# no LADSPA in PTXdist
+	select LIBMAD		if SOX_MAD
+	select LIBID3TAG	if SOX_ID3TAG
+	select LAME		if SOX_LAME
+	select TWOLAME		if SOX_TWOLAME
+	help
+	  SoX is the Swiss Army Knife of sound processing utilities.
+
+	  It can convert audio files to other popular audio file types
+	  and also apply sound effects and filters during the conversion.
+	  See http://sox.sourceforge.net/ for more information.
+
+	  Selecting this option installs libsox. For sox binary, see menu.
+
+if SOX
+
+# features using external libraries
+# ---------------------------------
+
+config SOX_MAGIC
+	bool
+	prompt "MAGIC support"
+	help
+	  Include support for libmagic based file type autodetection.
+	  libmagic is part of file utils.
+
+config SOX_PNG
+	bool
+	prompt "PNG support"
+	help
+	  Include support for libpng based PNG generation.
+	  Used in sox for spectrogram generation.
+
+# no LADSPA in PTXdist
+
+config SOX_MAD
+	bool
+	prompt "MAD support"
+	help
+	  Include support for libmad based MP3 decoding.
+
+config SOX_ID3TAG
+	bool
+	prompt "ID3TAG support"
+	help
+	  Include support for libid3tag based ID3 tag handling.
+
+config SOX_LAME
+	bool
+	prompt "LAME support"
+	help
+	  Include support for libmp3lame based MP3 encoding.
+
+config SOX_TWOLAME
+	bool
+	prompt "TWOLAME support"
+	help
+	  Include support for libtwolame based MP2 encoding.
+
+
+# sox command-line tools
+# ----------------------
+
+config SOX_TOOLS_SOX_SOXI
+	bool
+	default y
+	prompt "Install sox command-line tools sox, soxi"
+	help
+	  Install command-line tool 'sox' providing all libSoX functionality.
+	  Also install symlink 'soxi' pointing to 'sox'. soxi displays
+	  sound file metadata and is a shortcut for "sox --info".
+
+config SOX_TOOLS_PLAY_REC
+	bool
+	depends on SOX_TOOLS_SOX_SOXI
+	prompt "Install sox command-line tools play, rec"
+	help
+	  Install symlinks 'play' and 'rec' pointing to 'sox'.
+	  play will use sox for basic playing and is a shortcut
+	  for "sox <file> -d".
+	  rec will use sox for basic recording and is a shortcut
+	  for "sox -d <file>".
+
+endif
diff --git a/rules/sox.make b/rules/sox.make
new file mode 100644
index 0000000..b3c4e87
--- /dev/null
+++ b/rules/sox.make
@@ -0,0 +1,85 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2015 by Andreas Pretzsch <apr@cn-eng.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+PACKAGES-$(PTXCONF_SOX) += sox
+
+SOX_VERSION	:= 14.4.2
+SOX_MD5		:= ba804bb1ce5c71dd484a102a5b27d0dd
+SOX		:= sox-$(SOX_VERSION)
+SOX_SUFFIX	:= tar.bz2
+SOX_URL		:= $(call ptx/mirror, SF, sox/$(SOX).$(SOX_SUFFIX))
+SOX_SOURCE	:= $(SRCDIR)/$(SOX).$(SOX_SUFFIX)
+SOX_DIR		:= $(BUILDDIR)/$(SOX)
+SOX_LICENSE	:= GPLv2+ (tools), LGPLv2.1+ (libs)
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+SOX_CONF_TOOL	:= autoconf
+
+SOX_CONF_OPT	:= \
+	$(CROSS_AUTOCONF_USR) \
+	$(GLOBAL_LARGE_FILE_OPTION)
+
+# --disable-openmp  : configure detects OpenMP support but won't run on
+#                     targets without libgomp (GCC OpenMP) or similar
+SOX_CONF_OPT	+= \
+	--disable-openmp
+
+# --disable-dl-*    : configure default ; link instead if Dlopen library
+# --enable-symlinks : configure default ; for soxi, play, rec
+SOX_CONF_OPT	+= \
+	--disable-dl-mad \
+	--disable-dl-lame \
+	--disable-dl-twolame \
+	--disable-dl-amrwb \
+	--disable-dl-amrnb \
+	--disable-dl-sndfile \
+	--enable-symlinks
+
+# --without-ladspa  : no LADSPA in PTXdist
+SOX_CONF_OPT	+= \
+	--$(call ptx/wwo, PTXCONF_SOX_MAGIC)-magic \
+	--$(call ptx/wwo, PTXCONF_SOX_PNG)-png \
+	--without-ladspa \
+	--$(call ptx/wwo, PTXCONF_SOX_MAD)-mad \
+	--$(call ptx/wwo, PTXCONF_SOX_ID3TAG)-id3tag \
+	--$(call ptx/wwo, PTXCONF_SOX_LAME)-lame \
+	--$(call ptx/wwo, PTXCONF_SOX_TWOLAME)-twolame
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/sox.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, sox)
+	@$(call install_fixup, sox,PRIORITY,optional)
+	@$(call install_fixup, sox,SECTION,base)
+	@$(call install_fixup, sox,AUTHOR,"Andreas Pretzsch <apr@cn-eng.de>")
+	@$(call install_fixup, sox,DESCRIPTION,"Sound eXchange")
+
+	@$(call install_lib, sox, 0, 0, 0644, libsox)
+ifdef PTXCONF_SOX_TOOLS_SOX_SOXI
+	@$(call install_copy, sox, 0, 0, 0755, -, /usr/bin/sox)
+	@$(call install_link, sox, sox, /usr/bin/soxi)
+endif
+ifdef PTXCONF_SOX_TOOLS_PLAY_REC
+	@$(call install_link, sox, sox, /usr/bin/play)
+	@$(call install_link, sox, sox, /usr/bin/rec)
+endif
+
+	@$(call install_finish, sox)
+
+	@$(call touch)
+
+# vim: syntax=make
-- 
2.1.3


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] sox: new package for SoX 14.4.2
  2015-04-27  9:43 ` Michael Olbrich
@ 2015-05-11 17:56   ` Andreas Pretzsch
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Pretzsch @ 2015-05-11 17:56 UTC (permalink / raw)
  To: ptxdist

On Mo, 2015-04-27 at 11:43 +0200, Michael Olbrich wrote:
> On Sat, Apr 18, 2015 at 02:40:51AM +0200, Andreas Pretzsch wrote:
> > SoX is the Swiss Army Knife of sound processing utilities.
> > It can convert audio files to other popular audio file types
> > and also apply sound effects and filters during the conversion.
> > See http://sox.sourceforge.net/ for more information.
> > 
> > In addition to libsox, optionally the command-line tool "sox"
> > and its shortcuts "soxi", "play", "rec" can be installed.
> > 
> > Signed-off-by: Andreas Pretzsch <apr@cn-eng.de>
> > ---
> > The "--disable-openmp" is required, as sox configure detects
> > OpenMP support.............yes, -fopenmp
> > but won't run on targets without libgomp (GCC OpenMP) or similar.
> > As I don't care about this here (probably like most users), just
> > disable it, like some other packages in ptxdist do it.
> > 
> > Regarding other configure options (like mp3 support and whatnot),
> > rely on configure auto-detection, instead of adding with/without
> > options by the dozen. Whoever needs this is welcome to step in.
> > 
> >  rules/sox.in   | 46 +++++++++++++++++++++++++++++++++++++++++++
> >  rules/sox.make | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 108 insertions(+)
> >  create mode 100644 rules/sox.in
> >  create mode 100644 rules/sox.make
> > 
> > diff --git a/rules/sox.in b/rules/sox.in
> > new file mode 100644
> > index 0000000..0622f3e
> > --- /dev/null
> > +++ b/rules/sox.in
> > @@ -0,0 +1,46 @@
> > +## SECTION=multimedia_sound
> > +
> > +menuconfig SOX
> > +	tristate
> > +	prompt "sox                           "
> > +	help
> > +	  SoX is the Swiss Army Knife of sound processing utilities.
> > +	  It can convert audio files to other popular audio file types
> > +	  and also apply sound effects and filters during the conversion.
> > +	  See http://sox.sourceforge.net/ for more information.
> > +
> > +if SOX
> > +
> > +config SOX_SOX
> > +	bool
> > +	default y
> > +	prompt "Install sox command-line tool"
> > +	help
> > +	  Install command-line tool providing all libSoX functionality.
> > +	  Note: libsox is installed regardless of this option.
> > +
> > +config SOX_SOXI
> > +	bool
> > +	depends on SOX_SOX
> > +	prompt "Install symlink soxi => sox"
> > +	help
> > +	  Add "soxi" command to display sound file metadata.
> > +	  Same effect can be achieved with "sox --info".
> 
> I think we can just install this with sox

Ok. Fixed in v2.


> > +
> > +config SOX_PLAY
> > +	bool
> > +	depends on SOX_SOX
> > +	prompt "Install symlink play => sox"
> > +	help
> > +	  Add "play" command to use sox for basic playing.
> > +	  Same effect can be achieved with "sox <file> -d".
> > +
> > +config SOX_REC
> > +	bool
> > +	depends on SOX_SOX
> > +	prompt "Install symlink rec => sox"
> > +	help
> > +	  Add "rec" command to use sox for basic recording.
> > +	  Same effect can be achieved with "sox -d <file>".
> 
> Same for these two, or maybe one option for both.

One option for both. I like to see this as an optional thing, esp. given
the naming. "play" and "rec" are to "global" for my taste...


> > +
> > +endif
> > diff --git a/rules/sox.make b/rules/sox.make
> > new file mode 100644
> > index 0000000..bd03bdc
> > --- /dev/null
> > +++ b/rules/sox.make
> > @@ -0,0 +1,62 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2015 by Andreas Pretzsch <apr@cn-eng.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +PACKAGES-$(PTXCONF_SOX) += sox
> > +
> > +SOX_VERSION	:= 14.4.2
> > +SOX_MD5		:= ba804bb1ce5c71dd484a102a5b27d0dd
> > +SOX		:= sox-$(SOX_VERSION)
> > +SOX_SUFFIX	:= tar.bz2
> > +SOX_URL		:= $(call ptx/mirror, SF, sox/$(SOX).$(SOX_SUFFIX))
> > +SOX_SOURCE	:= $(SRCDIR)/$(SOX).$(SOX_SUFFIX)
> > +SOX_DIR		:= $(BUILDDIR)/$(SOX)
> > +SOX_LICENSE	:= GPLv2+ (tools), LGPLv2.1+ (libs)
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +SOX_CONF_TOOL	:= autoconf
> > +SOX_CONF_OPT	:= \
> > +	$(CROSS_AUTOCONF_USR) \
> > +	--disable-openmp
> 
> You're missing a lot of options here and probably some depencencies in the
> .in file as well. Use the global largefile option, --disable-dl-*,
> --ensable-symlinks, and either disable, enable (with correct dependency) or
> add an option (use ptx/wwo for configure) for each exernal dependency.

Regarding largefile, correct, missed that, sorry. Fixed in v2.

Regarding enable-symlinks and disable-dl-*, these are default in
configure, so passing them is redundant IMHO. And will miss future new
options in this field.
But as they won't harm (and are sox local), I add these by your request.
Also added a comment that these are default, in case somebody wonders
why they are in there.

About the external dependencies, strictly speaking, there are none.
But there are options to stop sox trying to use libraries present:
  --without-magic         Don't try to use magic
  --without-png           Don't try to use png
  --without-ladspa        Don't try to use LADSPA
  --with-ladspa-path      Default search path for LADSPA plugins
  --without-mad           Don't try to use MAD (MP3 Audio Decoder)
  --without-id3tag        Don't try to use id3tag
  --without-lame          Don't try to use LAME (LAME Ain't an MP3 Encoder)
  --without-twolame       Don't try to use Twolame (MP2 Audio Encoder)

Anyway, I added the wwo support by your request, selecting the
appropriate libs like other packages do it.
For LADSPA (where there is no package in PTXdist), "--without-ladspa" is
passed, as we forcefully override the autodetection for all these libs.
Of course, there is a suitable comment.

Last, sox configure does some autodetection for Opus, Ogg Vorbis, etc.
but provides no configure option here, beside some CFLAGS passing.
So for this, there is no support in the PTXdist config. And at least
from my side, there won't be any, until I need it for a project.


Best regards,
  Andreas

-- 

carpe noctem engineering
Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch
Dipl.-Ing. (FH) Andreas Pretzsch          Tel. +49-(0)731-5521572
Hahnengasse 3                             Fax: +49-(0)731-5521571
89073 Ulm, Germany                        email: apr@cn-eng.de


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-05-11 17:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-18  0:40 [ptxdist] [PATCH] sox: new package for SoX 14.4.2 Andreas Pretzsch
2015-04-27  9:43 ` Michael Olbrich
2015-05-11 17:56   ` Andreas Pretzsch
2015-05-11 17:56 ` [ptxdist] [PATCH v2] " Andreas Pretzsch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox