mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Markus Niebel <list-09_ptxdist@tqsc.de>
To: ptxdist@pengutronix.de
Cc: m.olbrich@pengutronix.de, Markus Niebel <Markus.Niebel@tq-group.com>
Subject: [ptxdist] [PATCH v2] systemd: add SYSTEMD_CPPFLAGS for local kernel headers
Date: Wed, 26 Nov 2014 13:03:16 +0100	[thread overview]
Message-ID: <1417003396-14336-1-git-send-email-list-09_ptxdist@tqsc.de> (raw)

From: Markus Niebel <Markus.Niebel@tq-group.com>

systemd uses cpp to generate tables for keymappings. Without setting
CPPFLAGS the toolchain headers will be used for generation but
local kernel headers for compilation. This can break compile.

Since CPPFLAGS are implicitly used when calling compiler directly,
we can drop the CFLAGS settings for local kernel headers.

tested with kernel 3.9

changes:

v2: drop SYSTEMD_CFLAGS, add this fact to the comments

Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 rules/systemd.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/systemd.make b/rules/systemd.make
index b0f7ce0..b2de3d7 100644
--- a/rules/systemd.make
+++ b/rules/systemd.make
@@ -41,7 +41,7 @@ SYSTEMD_CONF_ENV	:= \
 
 SYSTEMD_CONF_ENV += cc_cv_CFLAGS__flto=no
 
-SYSTEMD_CFLAGS		:= \
+SYSTEMD_CPPFLAGS	:= \
 	-I$(KERNEL_HEADERS_INCLUDE_DIR)
 
 #
-- 
2.1.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2014-11-26 12:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 12:03 Markus Niebel [this message]
2014-11-26 15:27 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417003396-14336-1-git-send-email-list-09_ptxdist@tqsc.de \
    --to=list-09_ptxdist@tqsc.de \
    --cc=Markus.Niebel@tq-group.com \
    --cc=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox