[ptxdist] oprofile: 2 patches

[ptxdist] oprofile: 2 patches

[Alexander Dahl]

Hei hei,

I use oprofile today on at91sam9 which is armv5te and came cross some
things. First is the kernel header path. In the previous version
oprofile added an additional "include" to the path so it could not
find the kernel headers. I made this dependent on the kernel-header
config, one could also just fix the path.

The second patch contains one important fix for an executable called
by opcontrol, see the comment on the patch. The other one is open for
comments. Upstream dropped support for the legacy tools and recommends
usage of operf and ocount so I added it in one patch.

Greets
Alex


-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH 1/2] oprofile: fix kernel header path

[Alexander Dahl]

Signed-off-by: Alexander Dahl <post@lespocky.de>
---
 rules/oprofile.make |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/rules/oprofile.make b/rules/oprofile.make
index af4a883..dabf5f8 100644
--- a/rules/oprofile.make
+++ b/rules/oprofile.make
@@ -36,10 +36,15 @@ OPROFILE_CONF_OPT	:= \
 	$(CROSS_AUTOCONF_USR) \
 	--target=$(PTXCONF_GNU_TARGET) \
 	--disable-gui \
-	--with-kernel=$(KERNEL_HEADERS_INCLUDE_DIR) \
 	--without-java \
 	--without-x
 
+ifdef PTXCONF_KERNEL_HEADER
+    OPROFILE_CONF_OPT   += --with-kernel=$(KERNEL_HEADERS_DIR)
+else
+    OPROFILE_CONF_OPT   += --without-kernel
+endif
+
 # ----------------------------------------------------------------------------
 # Target-Install
 # ----------------------------------------------------------------------------
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH 2/2] oprofile: targetinstall missing and additional binaries

[Alexander Dahl]

'op-check-perfevents' is called by 'opcontrol' and 'oparchive' may be
useful for easier examination. 'ocount' and 'operf' are only build if
kernel headers are installed, but recommended to use with newer kernels
and hardware supporting it.

Signed-off-by: Alexander Dahl <post@lespocky.de>
---
 rules/oprofile.make |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/rules/oprofile.make b/rules/oprofile.make
index dabf5f8..f1e7589 100644
--- a/rules/oprofile.make
+++ b/rules/oprofile.make
@@ -58,10 +58,17 @@ $(STATEDIR)/oprofile.targetinstall:
 	@$(call install_fixup, oprofile,AUTHOR,"Robert Schwebel <r.schwebel@pengutronix.de>")
 	@$(call install_fixup, oprofile,DESCRIPTION,missing)
 
+	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/op-check-perfevents)
 	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/opcontrol)
 	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/ophelp)
 	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/opreport)
 	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/oprofiled)
+	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/oparchive)
+
+ifdef PTXCONF_KERNEL_HEADER
+	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/ocount)
+	@$(call install_copy, oprofile, 0, 0, 0755, -, /usr/bin/operf)
+endif
 
 	@$(call install_tree, oprofile, 0, 0, -, /usr/share/oprofile)
 
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] oprofile: 2 patches

[Michael Olbrich]

On Tue, Oct 21, 2014 at 11:49:12PM +0200, Alexander Dahl wrote:
> Hei hei,
> 
> I use oprofile today on at91sam9 which is armv5te and came cross some
> things. First is the kernel header path. In the previous version
> oprofile added an additional "include" to the path so it could not
> find the kernel headers. I made this dependent on the kernel-header
> config, one could also just fix the path.
> 
> The second patch contains one important fix for an executable called
> by opcontrol, see the comment on the patch. The other one is open for
> comments. Upstream dropped support for the legacy tools and recommends
> usage of operf and ocount so I added it in one patch.

I've simplified the patches by making the kernel headers mandatory.
Please test if it still works for you.

Michael

> 
> Greets
> Alex
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] oprofile: 2 patches

[Alexander Dahl]

Hallo Michael, 

Am 2014-11-13 17:44, schrieb Michael Olbrich:
> I've simplified the patches by making the kernel headers mandatory.
> Please test if it still works for you.

Seems to work. Thank you. :-)

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de