From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.mars-solutions.de ([213.239.212.107]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1XZKqU-00030o-7I for ptxdist@pengutronix.de; Wed, 01 Oct 2014 16:25:35 +0200 Message-ID: <1412173521.13601.47.camel@ws-apr.office.loc> From: Andreas Pretzsch Date: Wed, 01 Oct 2014 16:25:21 +0200 In-Reply-To: <20141001102934.GE16481@pengutronix.de> References: <1412010731-18154-1-git-send-email-apr@cn-eng.de> <20141001102934.GE16481@pengutronix.de> Mime-Version: 1.0 Subject: Re: [ptxdist] [PATCH] openocd: new package for openocd-0.8.0 (host, target) Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mi, 2014-10-01 at 12:29 +0200, Michael Olbrich wrote: > On Mon, Sep 29, 2014 at 07:12:11PM +0200, Andreas Pretzsch wrote: > > [host-openocd] > > I think we should drop host-openocd for now. I'm not familiar OpenOCD but > unless you need exactly the same version on the PC and the Target, I think > we can let the Desktop Linux Distribution provide it. We can drop the host package. Host and target are independent and have different use cases. Target can be used for ISP and debugging on the target of an additional controller accessed by the main controller. Which is my use case here. Host is a classical development debugging tool and either provided by the host distri or local compiled by the developer anyway, often from git. I just added it as Michael Grzeschik made a preliminary packet back then, so there seems to be some use. And is was an easy by-product. I'll split up the patch, in a target one (including openocd/patches) and a host one. The target one should be merged, the host one is optional. I'll just put the host one on the list, so anyone can pick it up again later or use it locally, if they need it. And in this case, preserving some comments ;-) > [...] > > diff --git a/rules/openocd.in b/rules/openocd.in > [...] Will work in your suggestions in v2. > > +++ b/rules/openocd.make > > [...] > > +# ---------------------------------------------------------------------------- > > +# Target-Install > > +# ---------------------------------------------------------------------------- > > + > > +$(STATEDIR)/openocd.targetinstall: > > + @$(call targetinfo) > > + > > + @$(call install_init, openocd) > > + @$(call install_fixup, openocd,PRIORITY,optional) > > + @$(call install_fixup, openocd,SECTION,base) > > + @$(call install_fixup, openocd,AUTHOR,"Andreas Pretzsch ") > > + @$(call install_fixup, openocd,DESCRIPTION,"OpenOCD - Open On-Chip Debugger") > > + > > + @$(call install_copy, openocd, 0, 0, 0755, -, /usr/bin/openocd) > > +# @$(call install_tree, openocd, 0, 0, -, /usr/share/openocd/) > > don't add comments like this either remove this or actually install any > useful files. >From your other reply: > > + @$(call install_copy, openocd, 0, 0, 0755, -, /usr/bin/openocd) > > > +# @$(call install_tree, openocd, 0, 0, -, /usr/share/openocd/) > > > > Intentionally disabled. 700kB generic extra data on the target makes no > > sense. I doubt there won't be one real use case where the makefile is > > not pulled into platform local rules and adapted to copy only the 5 > > relevant files from this tree. So this is more of a reminder where to > > look, so I kept is as comment. > > I missed this when I commented the patch. Are there any files in > /usr/share/openocd/ that are required on the target? Not strictly out from there. Beside device-specific firmware and examples, it contains some 500 config files and tcl scripts. Core and SoC specific configs and setups, interface (debug adapter) specific configs, RAM and flash layout definitions, (eval) board init routines, some helpers, and so on. For the myriad targets OpenOCD supports. In practice on the target, one will use maybe 5 out of them, sometimes even merged into one file, and also adapt it to the specific hardware. So a mixture of a few selected ones plus maybe some not even in the official package. I see no sensible way for a preselection here, and in 99% of the cases, it will be project specific. So no pre-install. But I like to keep the comment for those who will adapt it to their needs, to ease things. What I'll do in v2 is to switch from install_tree to install_alternative_tree, missed that one. But still commented out. -- carpe noctem engineering Ingenieurbuero fuer Hard- & Software-Entwicklung Andreas Pretzsch Dipl.-Ing. (FH) Andreas Pretzsch Tel. +49-(0)731-5521572 Hahnengasse 3 Fax: +49-(0)731-5521571 89073 Ulm, Germany email: apr@cn-eng.de -- ptxdist mailing list ptxdist@pengutronix.de