mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: jon@ringle.org
To: ptxdist@pengutronix.de
Cc: Jon Ringle <jringle@gridpoint.com>
Subject: [ptxdist] [PATCH 2/2] systemd: PTXCONF_SYSTEMD_COREDUMP
Date: Tue, 30 Sep 2014 00:18:44 -0400	[thread overview]
Message-ID: <1412050724-11845-2-git-send-email-jon@ringle.org> (raw)
In-Reply-To: <1412050724-11845-1-git-send-email-jon@ringle.org>

From: Jon Ringle <jringle@gridpoint.com>

Allow coredumpctl to be built and installed to debug crashing systemd
services

Signed-off-by: Jon Ringle <jringle@gridpoint.com>
---
 rules/systemd.in   | 6 ++++++
 rules/systemd.make | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/rules/systemd.in b/rules/systemd.in
index ba69d8b..b6cdc1b 100644
--- a/rules/systemd.in
+++ b/rules/systemd.in
@@ -81,5 +81,11 @@ config SYSTEMD_TIMEDATE
 	help
 	  NTP client for time synchronization and local timezone handling.
 
+config SYSTEMD_COREDUMP
+	bool
+	prompt "enable generating coredumps"
+	help
+	  Enable this only if you need to debug a crashing systemd service
+
 endif
 
diff --git a/rules/systemd.make b/rules/systemd.make
index 51ffcac..7173812 100644
--- a/rules/systemd.make
+++ b/rules/systemd.make
@@ -102,7 +102,7 @@ SYSTEMD_CONF_OPT	:= \
 	--$(call ptx/endis,PTXCONF_SYSTEMD_TIMEDATE)-timedated \
 	--$(call ptx/endis,PTXCONF_SYSTEMD_TIMEDATE)-timesyncd \
 	--$(call ptx/endis,PTXCONF_SYSTEMD_LOCALES)-localed \
-	--disable-coredump \
+	--$(call ptx/endis,PTXCONF_SYSTEMD_COREDUMP)-coredump \
 	--disable-polkit \
 	--$(call ptx/endis,PTXCONF_SYSTEMD_NETWORK)-resolved \
 	--$(call ptx/endis,PTXCONF_SYSTEMD_NETWORK)-networkd \
@@ -170,6 +170,7 @@ SYSTEMD_HELPER := \
 	systemd-bootchart \
 	systemd-bus-proxyd \
 	systemd-cgroups-agent \
+	$(call ptx/ifdef, PTXCONF_SYSTEMD_COREDUMP,systemd-coredump,) \
 	systemd-fsck \
 	systemd-hostnamed \
 	systemd-initctl \
@@ -309,8 +310,9 @@ endif
 
 	@$(call install_copy, systemd, 0, 0, 0755, /var/lib/systemd)
 
-#	# systemd expects this directory to exist.
+ifdef PTXCONF_SYSTEMD_COREDUMP
 	@$(call install_copy, systemd, 0, 0, 0755, /var/lib/systemd/coredump)
+endif
 
 	@$(call install_alternative, systemd, 0, 0, 0644, /etc/profile.d/systemd.sh)
 
-- 
1.8.5.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-09-30  4:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30  4:18 [ptxdist] [PATCH 1/2] systemd: install_alternative_tree /lib/systemd/system/ jon
2014-09-30  4:18 ` jon [this message]
2014-09-30  8:20   ` [ptxdist] [PATCH 2/2] systemd: PTXCONF_SYSTEMD_COREDUMP Michael Olbrich
2014-09-30  8:12 ` [ptxdist] [PATCH 1/2] systemd: install_alternative_tree /lib/systemd/system/ Michael Olbrich
2014-10-01 12:06   ` Jon Ringle
2014-10-01 13:12     ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412050724-11845-2-git-send-email-jon@ringle.org \
    --to=jon@ringle.org \
    --cc=jringle@gridpoint.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox