[ptxdist] [PATCH 0/1] ptxd_make_xpkg_pkg: handle SIGPIPE correctly

[ptxdist] [PATCH 0/1] ptxd_make_xpkg_pkg: handle SIGPIPE correctly

[Tim Niemeyer]

Hi

I had some problems building my root filesystem. The problem was only
reproducible on one of our machines. The failing one is a bit slower.
PTXdist wasn't able to targetinstall e.g. libffi.  When I restarted the
build process, the targetinstall worked and PTXdists stopped on another
library (e.g. libncurses).

Example log from failing libffi targetinstall:
---%<---
install_init:   preparing for image creation of 'libffi'...
install_init:   @ARCH@ -> armel
install_init:   @PACKAGE@ -> libffi
install_init:   @VERSION@ -> 3.0.13
install_init:   @DEPENDS@ ->
install_init:   preinst not available
install_init:   postinst not available
install_init:   prerm not available
install_init:   postrm not available
install_fixup:  @PRIORITY@ -> optional ... done.
install_fixup:  @SECTION@ -> base ... done.
install_fixup:  @AUTHOR@ -> "Robert Schwebel <r.schwebel\@pengutronix.de>" ... done.
install_fixup:  @DESCRIPTION@ -> missing ... done.
xpkg_finish:    collecting license (MIT) ... done.
xpkg_finish:    creating ipkg package ...
install file:
  src=rootfs/platform-tricorder/packages/libffi-3.0.13/usr/lib/libffi.so.6.0.1
  dst=/usr/lib/libffi.so.6.0.1
  owner=0
  group=0
  permissions=0644

chmod: cannot access `/home/tniemeyer/rootfs/platform-tricorder/root/usr/lib/.debug/libffi.so.6.0.1': No such file or directory
Error: install_file failed!
make: *** [/home/tniemeyer/rootfs/platform-tricorder/state/libffi.targetinstall] Error 1
failed
--->%---

Regards
Tim


Tim Niemeyer (1):
  ptxd_make_xpkg_pkg: handle SIGPIPE correctly

 scripts/lib/ptxd_make_xpkg_pkg.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH] ptxd_make_xpkg_pkg: handle SIGPIPE correctly

[Tim Niemeyer]

grep -q exits as soon as the first expression is found. This leads to a
SIGPIPE to the objcopy process. SIGPIPE results in an exit code of 141.
So ptxd_install_file_extract_debug must handle the 141 return value as
,,didn't work'' because the grep found the expected error string.

Signed-off-by: Tim Niemeyer <tim.niemeyer@corscience.de>
---

 scripts/lib/ptxd_make_xpkg_pkg.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh b/scripts/lib/ptxd_make_xpkg_pkg.sh
index c80adea..86196a2 100644
--- a/scripts/lib/ptxd_make_xpkg_pkg.sh
+++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
@@ -230,7 +230,7 @@ ptxd_install_file_extract_debug() {
     "${CROSS_OBJCOPY}" ${ptxd_install_file_objcopy_args} "${dir}${dst}" "${dbg}" |&
 	grep -q "\(unrecognized option\|unable to initialize commpress status\)"
     local -a status=( "${PIPESTATUS[@]}" )
-    if [ ${status[0]} -eq 1 ]; then
+    if [ ${status[0]} -ne 0 ]; then
 	if [ ${status[1]} -eq 0 ]; then
 	    ptxd_install_file_objcopy_args="--only-keep-debug"
 	    "${CROSS_OBJCOPY}" ${ptxd_install_file_objcopy_args} "${dir}${dst}" "${dbg}"
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de