[ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0

[ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0

[Markus Niebel]

From: Markus Niebel <Markus.Niebel@tq-group.com>

Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>

---
 rules/memtester.make |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/memtester.make b/rules/memtester.make
index 8fd3dd7..e83a0b8 100644
--- a/rules/memtester.make
+++ b/rules/memtester.make
@@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_MEMTESTER) += memtester
 #
 # Paths and names
 #
-MEMTESTER_VERSION	:= 4.0.8
-MEMTESTER_MD5		:= a4971ed1ccaf5b2e2148fd66b0eb7363
+MEMTESTER_VERSION	:= 4.3.0
+MEMTESTER_MD5		:= 598f41b7308e1f736164bca3ab84ddbe
 MEMTESTER		:= memtester-$(MEMTESTER_VERSION)
 MEMTESTER_SUFFIX	:= tar.gz
 MEMTESTER_URL		:= http://pyropus.ca/software/memtester/old-versions/$(MEMTESTER).$(MEMTESTER_SUFFIX)
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0

[Michael Olbrich]

On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
> 

Thanks, applied.

Unrelated to this patch, but I noticed that the code is compiled without
optimization. Do you think it makes sense to add something like this to the
prepare stage:

	@echo "CFLAGS = -O2 -g"               >> $(MEMTESTER_DIR)/Makefile

Michael

> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> 
> ---
>  rules/memtester.make |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/memtester.make b/rules/memtester.make
> index 8fd3dd7..e83a0b8 100644
> --- a/rules/memtester.make
> +++ b/rules/memtester.make
> @@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_MEMTESTER) += memtester
>  #
>  # Paths and names
>  #
> -MEMTESTER_VERSION	:= 4.0.8
> -MEMTESTER_MD5		:= a4971ed1ccaf5b2e2148fd66b0eb7363
> +MEMTESTER_VERSION	:= 4.3.0
> +MEMTESTER_MD5		:= 598f41b7308e1f736164bca3ab84ddbe
>  MEMTESTER		:= memtester-$(MEMTESTER_VERSION)
>  MEMTESTER_SUFFIX	:= tar.gz
>  MEMTESTER_URL		:= http://pyropus.ca/software/memtester/old-versions/$(MEMTESTER).$(MEMTESTER_SUFFIX)
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0

[Markus Niebel]

Hello,

Am 23.06.2014 15:45, schrieb Michael Olbrich:
> On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
>> From: Markus Niebel <Markus.Niebel@tq-group.com>
>>
>
> Thanks, applied.
>
> Unrelated to this patch, but I noticed that the code is compiled without
> optimization. Do you think it makes sense to add something like this to the
> prepare stage:
>
> 	@echo "CFLAGS = -O2 -g"               >> $(MEMTESTER_DIR)/Makefile

maybe changing in:

@echo "$(CROSS_CC) -O2 -DPOSIX -D_POSIX_C_SOURCE=200809L 
-D_FILE_OFFSET_BITS=64 -DTEST_NARROW_WRITES -c" > $(MEMTESTER_DIR)/conf-cc
@echo "$(CROSS_CC) -s" > $(MEMTESTER_DIR)/conf-ld

and using package's own build system would be even better?
>
> Michael
>

Markus


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0

[Michael Olbrich]

On Tue, Jun 24, 2014 at 03:12:03PM +0200, Markus Niebel wrote:
> Hello,
> 
> Am 23.06.2014 15:45, schrieb Michael Olbrich:
> >On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
> >>From: Markus Niebel <Markus.Niebel@tq-group.com>
> >>
> >
> >Thanks, applied.
> >
> >Unrelated to this patch, but I noticed that the code is compiled without
> >optimization. Do you think it makes sense to add something like this to the
> >prepare stage:
> >
> >	@echo "CFLAGS = -O2 -g"               >> $(MEMTESTER_DIR)/Makefile
> 
> maybe changing in:
> 
> @echo "$(CROSS_CC) -O2 -DPOSIX -D_POSIX_C_SOURCE=200809L
> -D_FILE_OFFSET_BITS=64 -DTEST_NARROW_WRITES -c" >
> $(MEMTESTER_DIR)/conf-cc
> @echo "$(CROSS_CC) -s" > $(MEMTESTER_DIR)/conf-ld
> 
> and using package's own build system would be even better?

Indeed. Or maybe:
@sed -i 's/^cc\>/$(CROSS_CC)/' $(MEMTESTER_DIR)/conf-cc $(MEMTESTER_DIR)/conf-ld

So we don't have to duplicate the arguments.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de