Re: [ptxdist] [PATCH] Add support for stunnel (resending)

[Guillermo Rodriguez <guille.rodriguez@gmail.com>]

Hi Michael,

El mar, 10-06-2014 a las 07:59 +0200, Michael Olbrich escribió:
[...]
> > +#
> > +# Paths and names
> > +#
> > +STUNNEL_VERSION	:= 5.01
> > +STUNNEL_MD5		:= 7b63266b6fa05da696729e245100da65
> > +STUNNEL		:= stunnel-$(STUNNEL_VERSION)
> > +STUNNEL_SUFFIX	:= tar.gz
> > +STUNNEL_URL		:= http://ftp.nluug.nl/pub/networking/stunnel/$(STUNNEL).$(STUNNEL_SUFFIX)
> > +STUNNEL_SOURCE	:= $(SRCDIR)/$(STUNNEL).$(STUNNEL_SUFFIX)
> > +STUNNEL_DIR		:= $(BUILDDIR)/$(STUNNEL)
> > +STUNNEL_LICENSE	:= stunnel (GPL2 or later with openssl exception)
> 
> this must be aligned in the final file, not the diff

:) I did not align it in the diff -- in fact I did not align it at all;
this was generated from the ptxdist template.

> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +#
> > +# autoconf
> > +#
> > +STUNNEL_CONF_TOOL	:= autoconf
> > +STUNNEL_AUTOCONF	:= \
> > +	$(CROSS_AUTOCONF_USR) \
> > +	--with-ssl=$(PTXDIST_SYSROOT_TARGET)/usr
> 
> 	$(GLOBAL_IPV6_OPTION) \
> 	--disable-libwrap \
> 	--{en,dis}able-fips
> 
> I don't care what set for the last one, but it must not be autodetected.

OK. Do you have any doc with "best practices" on what options should be
passed to autoconf when writing these rules files ?

> 
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/stunnel.targetinstall:
> > +	@$(call targetinfo)
> > +
> > +	@$(call install_init, stunnel)
> > +	@$(call install_fixup, stunnel,PRIORITY,optional)
> > +	@$(call install_fixup, stunnel,SECTION,base)
> > +	@$(call install_fixup, stunnel,AUTHOR,"Guillermo Rodriguez <guille.rodriguez@gmail.com>")
> > +	@$(call install_fixup, stunnel,DESCRIPTION,missing)
> > +
> > +	@$(call install_copy, stunnel, 0, 0, 0755, $(STUNNEL_DIR)/src/stunnel, /usr/bin/stunnel)
> 
> 	@$(call install_copy, stunnel, 0, 0, 0755, -, /usr/bin/stunnel)

Ah! This was not clear to me from the documentation of the install_copy
macro. I'll change this (and the other bits) and resend.

Thank you for reviewing.

Best,

Guillermo Rodriguez


-- 
ptxdist mailing list
ptxdist@pengutronix.de