[ptxdist] [PATCH] barebox: select host-lzop

[ptxdist] [PATCH] barebox: select host-lzop

[Markus Niebel]

From: Markus Niebel <Markus.Niebel@tq-group.com>

    creation of barebox.z requires lzop. As this may be not installed,
    let's handle this inside of our build logic.

Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 platforms/barebox.in |    1 +
 1 file changed, 1 insertion(+)

diff --git a/platforms/barebox.in b/platforms/barebox.in
index 6e65f83..6f66d1f 100644
--- a/platforms/barebox.in
+++ b/platforms/barebox.in
@@ -10,6 +10,7 @@ config BAREBOX_ARCH_STRING
 menuconfig BAREBOX
 	select BOOTLOADER
 	select HOST_LIBUSB if BAREBOX_NEEDS_HOST_LIBUSB
+	select HOST_LZOP
 	prompt "barebox                       "
 	bool
 	help
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] barebox: select host-lzop

[Michael Olbrich]

On Thu, May 15, 2014 at 04:19:21PM +0200, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
> 
>     creation of barebox.z requires lzop. As this may be not installed,
>     let's handle this inside of our build logic.

True, but that's not always built, right? The kernel has the same problem
with the various compressions. I'd rather not built all tools that might be
used.

Michael

> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> ---
>  platforms/barebox.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/platforms/barebox.in b/platforms/barebox.in
> index 6e65f83..6f66d1f 100644
> --- a/platforms/barebox.in
> +++ b/platforms/barebox.in
> @@ -10,6 +10,7 @@ config BAREBOX_ARCH_STRING
>  menuconfig BAREBOX
>  	select BOOTLOADER
>  	select HOST_LIBUSB if BAREBOX_NEEDS_HOST_LIBUSB
> +	select HOST_LZOP
>  	prompt "barebox                       "
>  	bool
>  	help
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] barebox: select host-lzop

[Markus Niebel]

Am 13.06.2014 08:29, wrote Michael Olbrich:
> On Thu, May 15, 2014 at 04:19:21PM +0200, Markus Niebel wrote:
>> From: Markus Niebel <Markus.Niebel@tq-group.com>
>>
>>     creation of barebox.z requires lzop. As this may be not installed,
>>     let's handle this inside of our build logic.
> 
> True, but that's not always built, right? The kernel has the same problem
> with the various compressions. I'd rather not built all tools that might be
> used.
> 

I see. BTW I came over this because a costumers BSP faile to build due to not
installed lzop on the build machine and not built lzop in the BSP.

Mh - there is an option to select and build lzop under the linux menu - I must be blind.
Maybe it is helpful to have something similar for barebox (or to have a menu for
host tools under platform)

Markus

> Michael
> 
>> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
>> ---
>>  platforms/barebox.in |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/platforms/barebox.in b/platforms/barebox.in
>> index 6e65f83..6f66d1f 100644
>> --- a/platforms/barebox.in
>> +++ b/platforms/barebox.in
>> @@ -10,6 +10,7 @@ config BAREBOX_ARCH_STRING
>>  menuconfig BAREBOX
>>  	select BOOTLOADER
>>  	select HOST_LIBUSB if BAREBOX_NEEDS_HOST_LIBUSB
>> +	select HOST_LZOP
>>  	prompt "barebox                       "
>>  	bool
>>  	help
>> -- 
>> 1.7.9.5
>>
>>
>> -- 
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>>
> 


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] barebox: select host-lzop

[Michael Olbrich]

On Fri, Jun 13, 2014 at 06:47:10PM +0200, Markus Niebel wrote:
> Am 13.06.2014 08:29, wrote Michael Olbrich:
> > On Thu, May 15, 2014 at 04:19:21PM +0200, Markus Niebel wrote:
> >> From: Markus Niebel <Markus.Niebel@tq-group.com>
> >>
> >>     creation of barebox.z requires lzop. As this may be not installed,
> >>     let's handle this inside of our build logic.
> > 
> > True, but that's not always built, right? The kernel has the same problem
> > with the various compressions. I'd rather not built all tools that might be
> > used.
> > 
> 
> I see. BTW I came over this because a costumers BSP faile to build due to not
> installed lzop on the build machine and not built lzop in the BSP.
> 
> Mh - there is an option to select and build lzop under the linux menu - I must be blind.
> Maybe it is helpful to have something similar for barebox (or to have a menu for
> host tools under platform)

It would have to be barebox specific, otherweise the build order cannot be
defined. All of that is rather ugly. What we really want is to just build
the necessary tools, but that's not really possible, because the
information comes from a different config file...

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de