mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas@biessmann.de>
To: PTXdist ML <ptxdist@pengutronix.de>
Cc: "Andreas Bießmann" <andreas@biessmann.de>
Subject: [ptxdist] [PATCH v2] configure: consolidate compiler checks
Date: Wed, 23 Apr 2014 11:15:08 +0200	[thread overview]
Message-ID: <1398244508-16554-1-git-send-email-andreas@biessmann.de> (raw)
In-Reply-To: <1398118166-4200-1-git-send-email-andreas@biessmann.de>

Remove redundant check for GCC and move compiler checks to the beginning.
Before the AC_HEADERS_STDC checked for compilers implicitly and later on we
checked again explicitly for them.

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---

Changes in v2:
* remove redundant error messages for CC and CXX

 configure.ac |   20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/configure.ac b/configure.ac
index 390fcaf..22c8df0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -23,6 +23,11 @@ else
 	AC_MSG_ERROR([install the ptxdist-patches archive into the same directory as ptxdist.])
 fi
 
+dnl
+dnl Check for C and C++ compilers
+dnl
+AC_PROG_CC
+AC_PROG_CXX
 
 dnl
 dnl Check header files, mostly for lxdialog & kconfig
@@ -160,18 +165,6 @@ GNU_TOOL(xargs, findutils)
 dnl Check for egrep
 AC_PROG_EGREP
 
-dnl Check for gcc
-AC_PROG_CC
-if test -z "$CC"; then
-	AC_MSG_ERROR([gcc could not be found, please install])
-fi
-
-dnl Check for g++
-AC_PROG_CXX
-if test -z "$CXX"; then
-	AC_MSG_ERROR([g++ could not be found, please install])
-fi
-
 dnl Check for awk
 AC_PROG_AWK
 AC_PATH_PROGS(AWK, ${AWK},)
@@ -285,9 +278,6 @@ if test -z "$MSGFMT"; then
 	AC_MSG_ERROR([gettext could not be found, please install])
 fi
 
-dnl Check for gcc
-AC_PATH_PROGS(GCC, gcc,, $PATH)
-
 dnl
 dnl Checks for Python, needed for ipkg-utils
 dnl
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  parent reply	other threads:[~2014-04-23  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 22:09 [ptxdist] [PATCH] " Andreas Bießmann
2014-04-23  6:50 ` Michael Olbrich
2014-04-23  9:15 ` Andreas Bießmann [this message]
2014-04-23 12:45   ` [ptxdist] [PATCH v2] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398244508-16554-1-git-send-email-andreas@biessmann.de \
    --to=andreas@biessmann.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox