* [ptxdist] [PATCH 1/2] configure: search for GNU mktemp
2014-04-20 7:45 [ptxdist] [PATCH 0/2] Changes for BSD systems Andreas Bießmann
@ 2014-04-20 7:45 ` Andreas Bießmann
2014-04-20 7:45 ` [ptxdist] [PATCH 2/2] configure: search for GNU ln Andreas Bießmann
2014-04-21 8:53 ` [ptxdist] [PATCH 0/2] Changes for BSD systems Michael Olbrich
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2014-04-20 7:45 UTC (permalink / raw)
To: ptxdist
Commit d35a034a99d4bd6053dfe4bd9b1e2169b951430e broke ptxdist on machines with
BSD mktemp in $PATH. The introduced -t switch is different in BSD variants and
therefore the resulting path is somethink like
---8<---
% mktemp -t -d ptxdist.XXXXXX
/var/folders/mp/g80tgyd55bbc9vqjp9zd20600000gp/T/-d.bQehko2k
ptxdist.gaZrCM
--->8---
which is obviously wrong. Prevent that by providing always the GNU mktemp
variant in $PATH.
Also remove the now redundant check for installed mktemp.
Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
Makefile.in | 1 +
configure.ac | 7 +------
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/Makefile.in b/Makefile.in
index 72509a2..0c8098d 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -50,6 +50,7 @@ environment:
@ln -sf @GNU_rmdir@ "$(abs_srcdir)/bin/rmdir"
@ln -sf @GNU_md5sum@ "$(abs_srcdir)/bin/md5sum"
@ln -sf @GNU_mkdir@ "$(abs_srcdir)/bin/mkdir"
+ @ln -sf @GNU_mktemp@ "$(abs_srcdir)/bin/mktemp"
@ln -sf @GNU_install@ "$(abs_srcdir)/bin/install"
@ln -sf @GNU_stat@ "$(abs_srcdir)/bin/stat"
@ln -sf @GNU_mknod@ "$(abs_srcdir)/bin/mknod"
diff --git a/configure.ac b/configure.ac
index 2a97944..64d7af0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -143,6 +143,7 @@ GNU_TOOL(rm, coreutils)
GNU_TOOL(rmdir, coreutils)
GNU_TOOL(md5sum, coreutils)
GNU_TOOL(mkdir, coreutils)
+GNU_TOOL(mktemp, coreutils)
GNU_TOOL(install, coreutils)
GNU_TOOL(stat, coreutils)
GNU_TOOL(mknod, coreutils)
@@ -241,12 +242,6 @@ if test -z "$UNZIP"; then
AC_MSG_ERROR([unzip could not be found, please install])
fi
-dnl Check for mktemp
-AC_PATH_PROGS(MKTEMP, mktemp,, $PATH)
-if test -z "$MKTEMP"; then
- AC_MSG_ERROR([mktemp could not be found, please install])
-fi
-
dnl Check for wget
AC_PATH_PROGS(WGET, wget,, $PATH)
if test -z "$WGET"; then
--
1.9.2
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ptxdist] [PATCH 2/2] configure: search for GNU ln
2014-04-20 7:45 [ptxdist] [PATCH 0/2] Changes for BSD systems Andreas Bießmann
2014-04-20 7:45 ` [ptxdist] [PATCH 1/2] configure: search for GNU mktemp Andreas Bießmann
@ 2014-04-20 7:45 ` Andreas Bießmann
2014-04-21 8:53 ` [ptxdist] [PATCH 0/2] Changes for BSD systems Michael Olbrich
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2014-04-20 7:45 UTC (permalink / raw)
To: ptxdist
Commit e9b63339f6377df5d15feb4bd0685bb49a675593 broke ptxdist on machines with
BSD ln in $PATH. The introduced -T switch is not known to BSD variant and
therefore the ln command stops with error.
Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
Makefile.in | 1 +
configure.ac | 1 +
2 files changed, 2 insertions(+)
diff --git a/Makefile.in b/Makefile.in
index 0c8098d..5387f1d 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -47,6 +47,7 @@ environment:
@ln -sf @GNU_mv@ "$(abs_srcdir)/bin/mv"
@ln -sf @GNU_cp@ "$(abs_srcdir)/bin/cp"
@ln -sf @GNU_rm@ "$(abs_srcdir)/bin/rm"
+ @ln -sf @GNU_ln@ "$(abs_srcdir)/bin/ln"
@ln -sf @GNU_rmdir@ "$(abs_srcdir)/bin/rmdir"
@ln -sf @GNU_md5sum@ "$(abs_srcdir)/bin/md5sum"
@ln -sf @GNU_mkdir@ "$(abs_srcdir)/bin/mkdir"
diff --git a/configure.ac b/configure.ac
index 64d7af0..503d12c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -140,6 +140,7 @@ GNU_TOOL(chown, coreutils)
GNU_TOOL(mv, coreutils)
GNU_TOOL(cp, coreutils)
GNU_TOOL(rm, coreutils)
+GNU_TOOL(ln, coreutils)
GNU_TOOL(rmdir, coreutils)
GNU_TOOL(md5sum, coreutils)
GNU_TOOL(mkdir, coreutils)
--
1.9.2
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH 0/2] Changes for BSD systems
2014-04-20 7:45 [ptxdist] [PATCH 0/2] Changes for BSD systems Andreas Bießmann
2014-04-20 7:45 ` [ptxdist] [PATCH 1/2] configure: search for GNU mktemp Andreas Bießmann
2014-04-20 7:45 ` [ptxdist] [PATCH 2/2] configure: search for GNU ln Andreas Bießmann
@ 2014-04-21 8:53 ` Michael Olbrich
2 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2014-04-21 8:53 UTC (permalink / raw)
To: ptxdist
On Sun, Apr 20, 2014 at 09:45:53AM +0200, Andreas Bießmann wrote:
> This series add some required changes getting ptxdist work again on OS X.
>
>
Thanks, both applied. Good to know, that there is still someone out there
making sure things work on !Linux systems.
Michael
> Andreas Bießmann (2):
> configure: search for GNU mktemp
> configure: search for GNU ln
>
> Makefile.in | 2 ++
> configure.ac | 8 ++------
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> --
> 1.9.2
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread