mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas@biessmann.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 1/2] configure: search for GNU mktemp
Date: Sun, 20 Apr 2014 09:45:54 +0200	[thread overview]
Message-ID: <1397979956-86357-2-git-send-email-andreas@biessmann.de> (raw)
In-Reply-To: <1397979956-86357-1-git-send-email-andreas@biessmann.de>

Commit d35a034a99d4bd6053dfe4bd9b1e2169b951430e broke ptxdist on machines with
BSD mktemp in $PATH. The introduced -t switch is different in BSD variants and
therefore the resulting path is somethink like

---8<---
% mktemp -t -d ptxdist.XXXXXX
/var/folders/mp/g80tgyd55bbc9vqjp9zd20600000gp/T/-d.bQehko2k
ptxdist.gaZrCM
--->8---

which is obviously wrong. Prevent that by providing always the GNU mktemp
variant in $PATH.

Also remove the now redundant check for installed mktemp.

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---

 Makefile.in  | 1 +
 configure.ac | 7 +------
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 72509a2..0c8098d 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -50,6 +50,7 @@ environment:
 	@ln -sf @GNU_rmdir@ "$(abs_srcdir)/bin/rmdir"
 	@ln -sf @GNU_md5sum@ "$(abs_srcdir)/bin/md5sum"
 	@ln -sf @GNU_mkdir@ "$(abs_srcdir)/bin/mkdir"
+	@ln -sf @GNU_mktemp@ "$(abs_srcdir)/bin/mktemp"
 	@ln -sf @GNU_install@ "$(abs_srcdir)/bin/install"
 	@ln -sf @GNU_stat@ "$(abs_srcdir)/bin/stat"
 	@ln -sf @GNU_mknod@ "$(abs_srcdir)/bin/mknod"
diff --git a/configure.ac b/configure.ac
index 2a97944..64d7af0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -143,6 +143,7 @@ GNU_TOOL(rm, coreutils)
 GNU_TOOL(rmdir, coreutils)
 GNU_TOOL(md5sum, coreutils)
 GNU_TOOL(mkdir, coreutils)
+GNU_TOOL(mktemp, coreutils)
 GNU_TOOL(install, coreutils)
 GNU_TOOL(stat, coreutils)
 GNU_TOOL(mknod, coreutils)
@@ -241,12 +242,6 @@ if test -z "$UNZIP"; then
 	AC_MSG_ERROR([unzip could not be found, please install])
 fi
 
-dnl Check for mktemp
-AC_PATH_PROGS(MKTEMP, mktemp,, $PATH)
-if test -z "$MKTEMP"; then
-	AC_MSG_ERROR([mktemp could not be found, please install])
-fi
-
 dnl Check for wget
 AC_PATH_PROGS(WGET, wget,, $PATH)
 if test -z "$WGET"; then
-- 
1.9.2


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-04-20  7:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-20  7:45 [ptxdist] [PATCH 0/2] Changes for BSD systems Andreas Bießmann
2014-04-20  7:45 ` Andreas Bießmann [this message]
2014-04-20  7:45 ` [ptxdist] [PATCH 2/2] configure: search for GNU ln Andreas Bießmann
2014-04-21  8:53 ` [ptxdist] [PATCH 0/2] Changes for BSD systems Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397979956-86357-2-git-send-email-andreas@biessmann.de \
    --to=andreas@biessmann.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox