mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] net-snmp: clean up rule file
@ 2014-04-08 13:13 Bruno Thomsen
  2014-04-08 15:43 ` Michael Olbrich
  0 siblings, 1 reply; 3+ messages in thread
From: Bruno Thomsen @ 2014-04-08 13:13 UTC (permalink / raw)
  To: ptxdist; +Cc: m.olbrich, Bruno Thomsen

Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
---
 rules/net-snmp.make |   98 ++++++++-------------------------------------------
 1 file changed, 14 insertions(+), 84 deletions(-)

diff --git a/rules/net-snmp.make b/rules/net-snmp.make
index 6ddb954..a2efc59 100644
--- a/rules/net-snmp.make
+++ b/rules/net-snmp.make
@@ -60,91 +60,27 @@ NET_SNMP_AUTOCONF := \
 	--disable-static \
 	--$(call ptx/endis, PTXCONF_NET_SNMP_PRIVACY)-privacy \
 	--disable-internal-md5 \
+	--with-endianness=$(call ptx/ifdef, PTXCONF_ENDIAN_LITTLE, little, big)
 	--$(call ptx/endis, PTXCONF_NET_SNMP_DOM_SOCK_ONLY)-agentx-dom-sock-only \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_MINI_AGENT)-mini-agent \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_AGENT)-agent \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_APPLICATIONS)-applications \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_SCRIPTS)-scripts \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_MIBS)-mibs \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_MIB_LOADING)-mib-loading \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_SNMPV1)-snmpv1 \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_SNMPV2C)-snmpv2c \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_DES)-des \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_MD5)-md5 \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_SNMPTRAPD)-snmptrapd-subagent \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_LOCAL_SMUX)-local-smux \
+	--$(call ptx/endis, PTXCONF_NET_SNMP_DEVELOPER)-developer \
 	--enable-mib-config-checking \
 	--enable-mfd-rewrites \
 	--disable-testing-code \
 	--disable-reentrant \
 	--disable-ucd-snmp-compatibility
 
-ifdef PTXCONF_ENDIAN_LITTLE
-NET_SNMP_AUTOCONF += --with-endianness=little
-else
-NET_SNMP_AUTOCONF += --with-endianness=big
-endif
-
-ifdef PTXCONF_NET_SNMP_MINI_AGENT
-NET_SNMP_AUTOCONF += --enable-mini-agent
-else
-NET_SNMP_AUTOCONF += --disable-mini-agent
-endif
-
-ifdef PTXCONF_NET_SNMP_AGENT
-NET_SNMP_AUTOCONF += --enable-agent
-else
-NET_SNMP_AUTOCONF += --disable-agent
-endif
-
-ifdef PTXCONF_NET_SNMP_APPLICATIONS
-NET_SNMP_AUTOCONF += --enable-applications
-else
-NET_SNMP_AUTOCONF += --disable-applications
-endif
-
-ifdef PTXCONF_NET_SNMP_SCRIPTS
-NET_SNMP_AUTOCONF += --enable-scripts
-else
-NET_SNMP_AUTOCONF += --disable-scripts
-endif
-
-ifdef PTXCONF_NET_SNMP_MIBS
-NET_SNMP_AUTOCONF += --enable-mibs
-else
-NET_SNMP_AUTOCONF += --disable-mibs
-endif
-
-ifdef PTXCONF_NET_SNMP_MIB_LOADING
-NET_SNMP_AUTOCONF += --enable-mib-loading
-else
-NET_SNMP_AUTOCONF += --disable-mib-loading
-endif
-
-ifdef PTXCONF_NET_SNMP_SNMPV1
-NET_SNMP_AUTOCONF += --enable-snmpv1
-else
-NET_SNMP_AUTOCONF += --disable-snmpv1
-endif
-
-ifdef PTXCONF_NET_SNMP_SNMPV2C
-NET_SNMP_AUTOCONF += --enable-snmpv2c
-else
-NET_SNMP_AUTOCONF += --disable-snmpv2c
-endif
-
-ifdef PTXCONF_NET_SNMP_DES
-NET_SNMP_AUTOCONF += --enable-des
-else
-NET_SNMP_AUTOCONF += --disable-des
-endif
-
-ifdef PTXCONF_NET_SNMP_MD5
-NET_SNMP_AUTOCONF += --enable-md5
-else
-NET_SNMP_AUTOCONF += --disable-md5
-endif
-
-ifdef PTXCONF_NET_SNMP_SNMPTRAPD
-NET_SNMP_AUTOCONF += --enable-snmptrapd-subagent
-else
-NET_SNMP_AUTOCONF += --disable-snmptrapd-subagent
-endif
-
-ifdef PTXCONF_NET_SNMP_LOCAL_SMUX
-NET_SNMP_AUTOCONF += --enable-local-smux
-else
-NET_SNMP_AUTOCONF += --disable-local-smux
-endif
-
 ifdef PTXCONF_NET_SNMP_FORCE_DEBUGGING
 NET_SNMP_AUTOCONF += --enable-debugging
 endif
@@ -153,12 +89,6 @@ ifdef PTXCONF_NET_SNMP_STRIP_DEBUGGING
 NET_SNMP_AUTOCONF += --disable-debugging
 endif
 
-ifdef PTXCONF_NET_SNMP_DEVELOPER
-NET_SNMP_AUTOCONF += --enable-developer
-else
-NET_SNMP_AUTOCONF += --disable-developer
-endif
-
 NET_SNMP_MAKE_PAR := NO
 
 # ----------------------------------------------------------------------------
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ptxdist] [PATCH] net-snmp: clean up rule file
  2014-04-08 13:13 [ptxdist] [PATCH] net-snmp: clean up rule file Bruno Thomsen
@ 2014-04-08 15:43 ` Michael Olbrich
  2014-04-09  6:22   ` Bruno Thomsen
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Olbrich @ 2014-04-08 15:43 UTC (permalink / raw)
  To: ptxdist

On Tue, Apr 08, 2014 at 03:13:51PM +0200, Bruno Thomsen wrote:
> Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
> ---
>  rules/net-snmp.make |   98 ++++++++-------------------------------------------
>  1 file changed, 14 insertions(+), 84 deletions(-)
> 
> diff --git a/rules/net-snmp.make b/rules/net-snmp.make
> index 6ddb954..a2efc59 100644
> --- a/rules/net-snmp.make
> +++ b/rules/net-snmp.make
> @@ -60,91 +60,27 @@ NET_SNMP_AUTOCONF := \
>  	--disable-static \
>  	--$(call ptx/endis, PTXCONF_NET_SNMP_PRIVACY)-privacy \
>  	--disable-internal-md5 \
> +	--with-endianness=$(call ptx/ifdef, PTXCONF_ENDIAN_LITTLE, little, big)

This line is missing '\' at the end.

The rest looks good.

Michael

>  	--$(call ptx/endis, PTXCONF_NET_SNMP_DOM_SOCK_ONLY)-agentx-dom-sock-only \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_MINI_AGENT)-mini-agent \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_AGENT)-agent \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_APPLICATIONS)-applications \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_SCRIPTS)-scripts \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_MIBS)-mibs \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_MIB_LOADING)-mib-loading \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_SNMPV1)-snmpv1 \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_SNMPV2C)-snmpv2c \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_DES)-des \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_MD5)-md5 \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_SNMPTRAPD)-snmptrapd-subagent \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_LOCAL_SMUX)-local-smux \
> +	--$(call ptx/endis, PTXCONF_NET_SNMP_DEVELOPER)-developer \
>  	--enable-mib-config-checking \
>  	--enable-mfd-rewrites \
>  	--disable-testing-code \
>  	--disable-reentrant \
>  	--disable-ucd-snmp-compatibility
>  
> -ifdef PTXCONF_ENDIAN_LITTLE
> -NET_SNMP_AUTOCONF += --with-endianness=little
> -else
> -NET_SNMP_AUTOCONF += --with-endianness=big
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MINI_AGENT
> -NET_SNMP_AUTOCONF += --enable-mini-agent
> -else
> -NET_SNMP_AUTOCONF += --disable-mini-agent
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_AGENT
> -NET_SNMP_AUTOCONF += --enable-agent
> -else
> -NET_SNMP_AUTOCONF += --disable-agent
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_APPLICATIONS
> -NET_SNMP_AUTOCONF += --enable-applications
> -else
> -NET_SNMP_AUTOCONF += --disable-applications
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SCRIPTS
> -NET_SNMP_AUTOCONF += --enable-scripts
> -else
> -NET_SNMP_AUTOCONF += --disable-scripts
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MIBS
> -NET_SNMP_AUTOCONF += --enable-mibs
> -else
> -NET_SNMP_AUTOCONF += --disable-mibs
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MIB_LOADING
> -NET_SNMP_AUTOCONF += --enable-mib-loading
> -else
> -NET_SNMP_AUTOCONF += --disable-mib-loading
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SNMPV1
> -NET_SNMP_AUTOCONF += --enable-snmpv1
> -else
> -NET_SNMP_AUTOCONF += --disable-snmpv1
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SNMPV2C
> -NET_SNMP_AUTOCONF += --enable-snmpv2c
> -else
> -NET_SNMP_AUTOCONF += --disable-snmpv2c
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_DES
> -NET_SNMP_AUTOCONF += --enable-des
> -else
> -NET_SNMP_AUTOCONF += --disable-des
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MD5
> -NET_SNMP_AUTOCONF += --enable-md5
> -else
> -NET_SNMP_AUTOCONF += --disable-md5
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SNMPTRAPD
> -NET_SNMP_AUTOCONF += --enable-snmptrapd-subagent
> -else
> -NET_SNMP_AUTOCONF += --disable-snmptrapd-subagent
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_LOCAL_SMUX
> -NET_SNMP_AUTOCONF += --enable-local-smux
> -else
> -NET_SNMP_AUTOCONF += --disable-local-smux
> -endif
> -
>  ifdef PTXCONF_NET_SNMP_FORCE_DEBUGGING
>  NET_SNMP_AUTOCONF += --enable-debugging
>  endif
> @@ -153,12 +89,6 @@ ifdef PTXCONF_NET_SNMP_STRIP_DEBUGGING
>  NET_SNMP_AUTOCONF += --disable-debugging
>  endif
>  
> -ifdef PTXCONF_NET_SNMP_DEVELOPER
> -NET_SNMP_AUTOCONF += --enable-developer
> -else
> -NET_SNMP_AUTOCONF += --disable-developer
> -endif
> -
>  NET_SNMP_MAKE_PAR := NO
>  
>  # ----------------------------------------------------------------------------
> -- 
> 1.7.9.5
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ptxdist] [PATCH] net-snmp: clean up rule file
  2014-04-08 15:43 ` Michael Olbrich
@ 2014-04-09  6:22   ` Bruno Thomsen
  0 siblings, 0 replies; 3+ messages in thread
From: Bruno Thomsen @ 2014-04-09  6:22 UTC (permalink / raw)
  To: m.olbrich; +Cc: ptxdist

> -----Original Message-----
> From: ptxdist-bounces@pengutronix.de [mailto:ptxdist-bounces@pengutronix.de] On Behalf Of Michael Olbrich
> Sent: 8. april 2014 17:43
> To: ptxdist@pengutronix.de
> Subject: Re: [ptxdist] [PATCH] net-snmp: clean up rule file
> 
> On Tue, Apr 08, 2014 at 03:13:51PM +0200, Bruno Thomsen wrote:
> > Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
> > ---
> >  rules/net-snmp.make |   98 ++++++++-------------------------------------------
> >  1 file changed, 14 insertions(+), 84 deletions(-)
> > 
> > diff --git a/rules/net-snmp.make b/rules/net-snmp.make index 
> > 6ddb954..a2efc59 100644
> > --- a/rules/net-snmp.make
> > +++ b/rules/net-snmp.make
> > @@ -60,91 +60,27 @@ NET_SNMP_AUTOCONF := \
> >  	--disable-static \
> >  	--$(call ptx/endis, PTXCONF_NET_SNMP_PRIVACY)-privacy \
> >  	--disable-internal-md5 \
> > +	--with-endianness=$(call ptx/ifdef, PTXCONF_ENDIAN_LITTLE, little, 
> > +big)
> 
> This line is missing '\' at the end.


Sharp eyes :)
It has been lost somewhere between company SVN and GIT. I will resend a fixed patch.


Venlig hilsen / Best regards

Kamstrup A/S <http://www.kamstrup.dk> 
Bruno Thomsen
Development engineer
Technology

Kamstrup A/S
Industrivej 28
DK-8660 Skanderborg
Tel:	 +45 89 93 10 00	 
Fax:	 +45 89 93 10 01	 
Dir:	 +45 89 93 13 94	 
E-mail:	 bth@kamstrup.dk	 
Web:	 www.kamstrup.dk	 


-- 
ptxdist mailing list
ptxdist@pengutronix.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-04-09  6:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-08 13:13 [ptxdist] [PATCH] net-snmp: clean up rule file Bruno Thomsen
2014-04-08 15:43 ` Michael Olbrich
2014-04-09  6:22   ` Bruno Thomsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox