* [ptxdist] [PATCH 0/3] powertop: add new version with new features
@ 2014-04-01 16:02 Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 1/3] powertop: remove powertop package Alexander Aring
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Alexander Aring @ 2014-04-01 16:02 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Aring
Hi,
this patch removes the old powertop package and add a new one.
The current package URL ends in some 404 and moved to another site.
The new powertop package use autotools and has some pci support, this
is why I also updated the pciutils package with new features for libpci
and libkmod things...
Also fix a missing depends on !BUSYBOX_POWERTOP in the powertop rules.
- Alex
Alexander Aring (3):
powertop: remove powertop package
pciutils: bump version and cleanup
powertop: add new package
...iutils-install-lib-dependency-when-SHARED.patch | 31 ++++++++++++++++++
patches/pciutils-3.2.1/series | 1 +
patches/powertop-1.11/add-ldflags.diff | 31 ------------------
patches/powertop-1.11/remove-bashism.patch | 37 ----------------------
patches/powertop-1.11/series | 2 --
rules/pciutils.in | 23 +++++++++++---
rules/pciutils.make | 24 +++++++-------
rules/powertop.in | 29 ++++++++++++++---
rules/powertop.make | 28 +++++++---------
9 files changed, 97 insertions(+), 109 deletions(-)
create mode 100644 patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
create mode 100644 patches/pciutils-3.2.1/series
delete mode 100644 patches/powertop-1.11/add-ldflags.diff
delete mode 100644 patches/powertop-1.11/remove-bashism.patch
delete mode 100644 patches/powertop-1.11/series
--
1.9.1
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* [ptxdist] [PATCH 1/3] powertop: remove powertop package
2014-04-01 16:02 [ptxdist] [PATCH 0/3] powertop: add new version with new features Alexander Aring
@ 2014-04-01 16:02 ` Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup Alexander Aring
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Alexander Aring @ 2014-04-01 16:02 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Aring
This patch removes the current version of powertop. The URL of the
current version ends up in a 404 not found and there is already a newer
version with autotools support.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
patches/powertop-1.11/add-ldflags.diff | 31 ---------------
patches/powertop-1.11/remove-bashism.patch | 37 -----------------
patches/powertop-1.11/series | 2 -
rules/powertop.in | 21 ----------
rules/powertop.make | 64 ------------------------------
5 files changed, 155 deletions(-)
delete mode 100644 patches/powertop-1.11/add-ldflags.diff
delete mode 100644 patches/powertop-1.11/remove-bashism.patch
delete mode 100644 patches/powertop-1.11/series
delete mode 100644 rules/powertop.in
delete mode 100644 rules/powertop.make
diff --git a/patches/powertop-1.11/add-ldflags.diff b/patches/powertop-1.11/add-ldflags.diff
deleted file mode 100644
index 44c92f0..0000000
--- a/patches/powertop-1.11/add-ldflags.diff
+++ /dev/null
@@ -1,31 +0,0 @@
-From: Marc Kleine-Budde <mkl@pengutronix.de>
-Subject: use LDFLAGS during linking
-
-powertop fails to link, if ncursesw isn't in the
-standard library search path.
-
-It fails even if the LDFLAGS have the appropriate -L.
-This patch add LDFLAGS to the linker invocation.
-
-Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
-
-send upstream to power@bughost.org
-should appear here soon: http://www.bughost.org/pipermail/power/2009-April/thread.html
-
----
- Makefile | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: powertop-1.11/Makefile
-===================================================================
---- powertop-1.11.orig/Makefile
-+++ powertop-1.11/Makefile
-@@ -20,7 +20,7 @@ OBJS = powertop.o config.o process.o mis
-
-
- powertop: $(OBJS) Makefile powertop.h
-- $(CC) ${CFLAGS} $(OBJS) -lncursesw -o powertop
-+ $(CC) ${CFLAGS} $(LDFLAGS) $(OBJS) -lncursesw -o powertop
- @(cd po/ && $(MAKE))
-
- powertop.1.gz: powertop.1
diff --git a/patches/powertop-1.11/remove-bashism.patch b/patches/powertop-1.11/remove-bashism.patch
deleted file mode 100644
index ba2bce8..0000000
--- a/patches/powertop-1.11/remove-bashism.patch
+++ /dev/null
@@ -1,37 +0,0 @@
-From: http://ftp.de.debian.org/debian/pool/main/p/powertop/powertop_1.11-1.diff.gz
-
-Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
-
-#! /bin/sh /usr/share/dpatch/dpatch-run
-## remove-bashism.dpatch by Patrick Winnertz <winnie@debian.org>
-##
-## All lines beginning with `## DP:' are a description of the patch.
-## DP: remove some bashisms in the output
-
-@DPATCH@
-diff --git a/cpufreq.c b/cpufreq.c
-index ab84dc4..a291fdf 100644
---- a/cpufreq.c
-+++ b/cpufreq.c
-@@ -39,7 +39,7 @@ static void activate_ondemand(void)
- FILE *file;
- char filename[PATH_MAX];
-
-- system("/sbin/modprobe cpufreq_ondemand &> /dev/null");
-+ system("/sbin/modprobe cpufreq_ondemand > /dev/null 2>&1");
-
-
- dir = opendir("/sys/devices/system/cpu");
-diff --git a/powertop.c b/powertop.c
-index fc605ec..4d18de8 100644
---- a/powertop.c
-+++ b/powertop.c
-@@ -798,7 +798,7 @@ int main(int argc, char **argv)
- if (!dump)
- ticktime = 5.0;
-
-- system("/sbin/modprobe cpufreq_stats &> /dev/null");
-+ system("/sbin/modprobe cpufreq_stats > /dev/null 2>&1");
- read_data(&start_usage[0], &start_duration[0]);
-
-
diff --git a/patches/powertop-1.11/series b/patches/powertop-1.11/series
deleted file mode 100644
index 1bb7176..0000000
--- a/patches/powertop-1.11/series
+++ /dev/null
@@ -1,2 +0,0 @@
-add-ldflags.diff
-remove-bashism.patch
diff --git a/rules/powertop.in b/rules/powertop.in
deleted file mode 100644
index 56e7521..0000000
--- a/rules/powertop.in
+++ /dev/null
@@ -1,21 +0,0 @@
-## SECTION=debug_tools
-
-config POWERTOP
- tristate
- prompt "powertop"
- select GCCLIBS_GCC_S
- select NCURSES
- help
- PowerTOP is a Linux tool that finds the software
- component(s) that make your laptop use more power than
- necessary while it is idle. As of Linux kernel version
- 2.6.21, the kernel no longer has a fixed 1000Hz timer
- tick. This will (in theory) give a huge power savings
- because the CPU stays in low power mode for longer periods
- of time during system idle.
-
- However... there are many things that can ruin the party,
- both inside the kernel and in userspace. PowerTOP combines
- various sources of information from the kernel into one
- convenient screen so that you can see how well your system
- is doing, and which components are the biggest problem.
diff --git a/rules/powertop.make b/rules/powertop.make
deleted file mode 100644
index a3be360..0000000
--- a/rules/powertop.make
+++ /dev/null
@@ -1,64 +0,0 @@
-# -*-makefile-*-
-#
-# Copyright (C) 2009 by Marc Kleine-Budde <mkl@pengutronix.de>
-#
-# See CREDITS for details about who has contributed to this project.
-#
-# For further information about the PTXdist project and license conditions
-# see the README file.
-#
-
-#
-# We provide this package
-#
-PACKAGES-$(PTXCONF_POWERTOP) += powertop
-
-#
-# Paths and names
-#
-POWERTOP_VERSION := 1.11
-POWERTOP_MD5 := 3498f5983c683c3a57dce7379a722082
-POWERTOP := powertop-$(POWERTOP_VERSION)
-POWERTOP_SUFFIX := tar.gz
-POWERTOP_URL := http://www.lesswatts.org/projects/powertop/download/$(POWERTOP).$(POWERTOP_SUFFIX)
-POWERTOP_SOURCE := $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX)
-POWERTOP_DIR := $(BUILDDIR)/$(POWERTOP)
-
-# ----------------------------------------------------------------------------
-# Prepare
-# ----------------------------------------------------------------------------
-
-POWERTOP_PATH := PATH=$(CROSS_PATH)
-
-POWERTOP_COMPILE_ENV := $(CROSS_ENV)
-POWERTOP_MAKEVARS := BINDIR=/usr/sbin
-
-$(STATEDIR)/powertop.prepare:
- @$(call targetinfo)
-ifdef PTXCONF_NCURSES_WIDE_CHAR
- sed -i -e "s/-lncurses[^ ]*/-lncursesw/g" "$(POWERTOP_DIR)/Makefile"
-else
- sed -i -e "s/-lncurses[^ ]*/-lncurses/g" "$(POWERTOP_DIR)/Makefile"
-endif
- @$(call touch)
-
-# ----------------------------------------------------------------------------
-# Target-Install
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/powertop.targetinstall:
- @$(call targetinfo)
-
- @$(call install_init, powertop)
- @$(call install_fixup, powertop,PRIORITY,optional)
- @$(call install_fixup, powertop,SECTION,base)
- @$(call install_fixup, powertop,AUTHOR,"Marc Kleine-Budde <mkl@pengutronix.de>")
- @$(call install_fixup, powertop,DESCRIPTION,missing)
-
- @$(call install_copy, powertop, 0, 0, 0755, -, /usr/sbin/powertop)
-
- @$(call install_finish, powertop)
-
- @$(call touch)
-
-# vim: syntax=make
--
1.9.1
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup
2014-04-01 16:02 [ptxdist] [PATCH 0/3] powertop: add new version with new features Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 1/3] powertop: remove powertop package Alexander Aring
@ 2014-04-01 16:02 ` Alexander Aring
2014-04-02 9:15 ` Michael Olbrich
2014-04-01 16:02 ` [ptxdist] [PATCH 3/3] powertop: add new package Alexander Aring
2014-04-07 8:03 ` [ptxdist] [PATCH 0/3] powertop: add new version with new features Juergen Beisert
3 siblings, 1 reply; 14+ messages in thread
From: Alexander Aring @ 2014-04-01 16:02 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Aring
This patch bumps the version of pciutils from 3.1.2 to 3.2.1.
Also cleanup the rule files:
- remove of the prepare rule.
- use of call ptx/ifdef instead ifdefs.
- Adding support for installing libpci.
- Also adds a patch with rename the install dependency from
install-pcilib to install-lib, which also install pkg-config files.
Smells like a mainline bug, I don't know powertop doesn't find the
library otherwise.
- Addings support for libkmod feature (sounds cool).
- Add install of /usr/bin/update-pciids.
- fit the help messages in Kconfig in 80 char width.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
...iutils-install-lib-dependency-when-SHARED.patch | 31 ++++++++++++++++++++++
patches/pciutils-3.2.1/series | 1 +
rules/pciutils.in | 23 ++++++++++++----
rules/pciutils.make | 24 ++++++++---------
4 files changed, 61 insertions(+), 18 deletions(-)
create mode 100644 patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
create mode 100644 patches/pciutils-3.2.1/series
diff --git a/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
new file mode 100644
index 0000000..84bc3a5
--- /dev/null
+++ b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
@@ -0,0 +1,31 @@
+From d0d7d419885d98f7d54d0a66b321db08f7974a93 Mon Sep 17 00:00:00 2001
+From: Alexander Aring <alex.aring@gmail.com>
+Date: Tue, 1 Apr 2014 14:40:33 +0200
+Subject: [PATCH] pciutils: install-lib dependency when SHARED
+
+This patch rename the install rule dependency from install-pcilib
+to install-lib, when SHARED=yes. The install-pcilib doesn't install the
+libpci.pc files for pkg-config but install-lib does. This is necessary
+for packages like powertop which search for the libpci library.
+
+Signed-off-by: Alexander Aring <alex.aring@gmail.com>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index 0a21ee8..5b91a5f 100644
+--- a/Makefile
++++ b/Makefile
+@@ -118,7 +118,7 @@ ifeq ($(SHARED),yes)
+ endif
+
+ ifeq ($(SHARED),yes)
+-install: install-pcilib
++install: install-lib
+ endif
+
+ install-pcilib: lib/$(PCILIB)
+--
+1.9.1
+
diff --git a/patches/pciutils-3.2.1/series b/patches/pciutils-3.2.1/series
new file mode 100644
index 0000000..c6edb1c
--- /dev/null
+++ b/patches/pciutils-3.2.1/series
@@ -0,0 +1 @@
+0001-pciutils-install-lib-dependency-when-SHARED.patch
diff --git a/rules/pciutils.in b/rules/pciutils.in
index 1c11d65..d44b158 100644
--- a/rules/pciutils.in
+++ b/rules/pciutils.in
@@ -1,12 +1,14 @@
## SECTION=shell_and_console
menuconfig PCIUTILS
- select ZLIB if PCIUTILS_COMPRESS
+ select ZLIB if PCIUTILS_COMPRESS
+ select LIBKMOD if PCIUTILS_LIBKMOD
depends on !BUSYBOX_LSPCI || ALLYES
tristate
prompt "pciutils "
help
- The PCI Utilities package contains a library for portable access to PCI bus
- configuration registers and several utilities based on this library.
+ The PCI Utilities package contains a library for portable access
+ to PCI bus configuration registers and several utilities based on
+ this library.
if PCIUTILS
@@ -15,9 +17,20 @@ config PCIUTILS_COMPRESS
default y
prompt "compress pci_ids"
help
- Save storage space by compressing the pci-id database. Access will be a
- little bit slower then.
+ Save storage space by compressing the pci-id database. Access will
+ be a little bit slower then.
+config PCIUTILS_LIBPCI
+ bool
+ prompt "install shared libpci library"
+ help
+ Generate and install the shared libpci library.
+
+config PCIUTILS_LIBKMOD
+ bool
+ prompt "libkmod support"
+ help
+ Use libkmod to resolve kernel modules on Linux.
endif
comment "busybox' lspci is selected"
diff --git a/rules/pciutils.make b/rules/pciutils.make
index 1490a53..20365d1 100644
--- a/rules/pciutils.make
+++ b/rules/pciutils.make
@@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_PCIUTILS) += pciutils
#
# Paths and names
#
-PCIUTILS_VERSION := 3.1.2
-PCIUTILS_MD5 := 46387fd7a18c33fbb5311fdb3ab9ea12
+PCIUTILS_VERSION := 3.2.1
+PCIUTILS_MD5 := 425b1acad6854cc2bbb06ac8e48e76fc
PCIUTILS := pciutils-$(PCIUTILS_VERSION)
PCIUTILS_SUFFIX := tar.bz2
PCIUTILS_URL := $(call ptx/mirror, KERNEL, ../software/utils/pciutils/$(PCIUTILS).$(PCIUTILS_SUFFIX))
@@ -29,7 +29,7 @@ PCIUTILS_DIR := $(BUILDDIR)/$(PCIUTILS)
# Prepare
# ----------------------------------------------------------------------------
-PCIUTILS_PATH := PATH=$(CROSS_PATH)
+PCIUTILS_CONF_TOOL := NO
PCIUTILS_COMPILE_ENV := $(CROSS_ENV)
PCIUTILS_MAKEVARS := \
@@ -38,19 +38,12 @@ PCIUTILS_MAKEVARS := \
SBINDIR='\$$(PREFIX)/bin' \
HOST=$(PTXCONF_ARCH_STRING)--linux \
RELEASE=$(KERNEL_HEADER_VERSION) \
+ ZLIB=$(call ptx/ifdef,PTXCONF_PCIUTILS_COMPRESS,yes,no) \
+ LIBKMOD=$(call ptx/ifdef,PTXCONF_PCIUTILS_LIBKMOD,yes,no) \
+ SHARED=$(call ptx/ifdef,PTXCONF_PCIUTILS_LIBPCI,yes,no) \
STRIP= \
DNS=no
-ifdef PTXCONF_PCIUTILS_COMPRESS
-PCIUTILS_MAKEVARS += ZLIB=yes
-else
-PCIUTILS_MAKEVARS += ZLIB=no
-endif
-
-$(STATEDIR)/pciutils.prepare:
- @$(call targetinfo)
- @$(call touch)
-
# ----------------------------------------------------------------------------
# Target-Install
# ----------------------------------------------------------------------------
@@ -64,8 +57,13 @@ $(STATEDIR)/pciutils.targetinstall:
@$(call install_fixup, pciutils,AUTHOR,"Robert Schwebel <r.schwebel@pengutronix.de>")
@$(call install_fixup, pciutils,DESCRIPTION,missing)
+ifdef PTXCONF_PCIUTILS_LIBPCI
+ @$(call install_lib, pciutils, 0, 0, 0644, libpci)
+endif
+
@$(call install_copy, pciutils, 0, 0, 0755, -, /usr/bin/lspci)
@$(call install_copy, pciutils, 0, 0, 0755, -, /usr/bin/setpci)
+ @$(call install_copy, pciutils, 0, 0, 0755, -, /usr/bin/update-pciids)
ifdef PTXCONF_PCIUTILS_COMPRESS
@$(call install_copy, pciutils, 0, 0, 0644, -, \
/usr/share/pci.ids.gz, n)
--
1.9.1
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* [ptxdist] [PATCH 3/3] powertop: add new package
2014-04-01 16:02 [ptxdist] [PATCH 0/3] powertop: add new version with new features Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 1/3] powertop: remove powertop package Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup Alexander Aring
@ 2014-04-01 16:02 ` Alexander Aring
2014-04-02 9:17 ` Michael Olbrich
2014-04-07 8:03 ` [ptxdist] [PATCH 0/3] powertop: add new version with new features Juergen Beisert
3 siblings, 1 reply; 14+ messages in thread
From: Alexander Aring @ 2014-04-01 16:02 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Aring
This patch adds the new powertop package with pci support.
Some notice by adding this package:
The pci support needs the pciutils package which provides the libpci.
This is the reason why we need a depends on !BUSYBOX_LSPCI there. The
pciutils packages can't be installed if BUSYBOX_LSPCI is selected.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
rules/powertop.in | 42 ++++++++++++++++++++++++++++++++++++++
rules/powertop.make | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 100 insertions(+)
create mode 100644 rules/powertop.in
create mode 100644 rules/powertop.make
diff --git a/rules/powertop.in b/rules/powertop.in
new file mode 100644
index 0000000..b1a4dbe
--- /dev/null
+++ b/rules/powertop.in
@@ -0,0 +1,42 @@
+## SECTION=debug_tools
+
+menuconfig POWERTOP
+ tristate
+ prompt "powertop "
+ select LIBNL3
+ select NCURSES
+ select PCIUTILS if POWERTOP_PCI_SUPPORT
+ select PCIUTILS_LIBPCI if POWERTOP_PCI_SUPPORT
+ depends on !BUSYBOX_POWERTOP || ALLYES
+ help
+ PowerTOP is a Linux tool that finds the software
+ component(s) that make your laptop use more power than
+ necessary while it is idle. As of Linux kernel version
+ 2.6.21, the kernel no longer has a fixed 1000Hz timer
+ tick. This will (in theory) give a huge power savings
+ because the CPU stays in low power mode for longer periods
+ of time during system idle.
+
+ However... there are many things that can ruin the party,
+ both inside the kernel and in userspace. PowerTOP combines
+ various sources of information from the kernel into one
+ convenient screen so that you can see how well your system
+ doing, and which components are the biggest problem.
+
+if POWERTOP
+
+config POWERTOP_PCI_SUPPORT
+ bool
+ prompt "pci support"
+ depends on !BUSYBOX_LSPCI || ALLYES
+ help
+ This adds powertop support for the PCI bus. Should only be
+ enabled if you have PCI support.
+
+comment "BusyBox' lspci is selected!"
+ depends on BUSYBOX_LSPCI
+
+endif
+
+comment "BusyBox' powertop is selected!"
+ depends on BUSYBOX_POWERTOP
diff --git a/rules/powertop.make b/rules/powertop.make
new file mode 100644
index 0000000..a5554bc
--- /dev/null
+++ b/rules/powertop.make
@@ -0,0 +1,58 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2009 by Marc Kleine-Budde <mkl@pengutronix.de>
+# 2014 by Alexander Aring <aar@pengutronix.de>
+#
+# See CREDITS for details about who has contributed to this project.
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_POWERTOP) += powertop
+
+#
+# Paths and names
+#
+POWERTOP_VERSION := 2.5
+POWERTOP_MD5 := 806bbcbd44fcea1f807c9582fc1f7d3e
+POWERTOP := powertop-$(POWERTOP_VERSION)
+POWERTOP_SUFFIX := tar.gz
+POWERTOP_URL := https://01.org/sites/default/files/downloads/powertop/$(POWERTOP).$(POWERTOP_SUFFIX)
+POWERTOP_SOURCE := $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX)
+POWERTOP_DIR := $(BUILDDIR)/$(POWERTOP)
+POWERTOP_LICENSE := GPLv2
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+#
+# autoconf
+#
+POWERTOP_CONF_TOOL := autoconf
+POWERTOP_CONF_OPT := $(CROSS_AUTOCONF_USR)
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/powertop.targetinstall:
+ @$(call targetinfo)
+
+ @$(call install_init, powertop)
+ @$(call install_fixup, powertop,PRIORITY,optional)
+ @$(call install_fixup, powertop,SECTION,base)
+ @$(call install_fixup, powertop,AUTHOR,"Alexander Aring <aar@pengutronix.de>")
+ @$(call install_fixup, powertop,DESCRIPTION,missing)
+
+ @$(call install_copy, powertop, 0, 0, 0755, -, /usr/sbin/powertop)
+
+ @$(call install_finish, powertop)
+
+ @$(call touch)
+
+# vim: syntax=make
--
1.9.1
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup
2014-04-01 16:02 ` [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup Alexander Aring
@ 2014-04-02 9:15 ` Michael Olbrich
2014-04-02 10:35 ` Alexander Aring
2014-04-03 8:29 ` Alexander Aring
0 siblings, 2 replies; 14+ messages in thread
From: Michael Olbrich @ 2014-04-02 9:15 UTC (permalink / raw)
To: ptxdist
On Tue, Apr 01, 2014 at 06:02:34PM +0200, Alexander Aring wrote:
> This patch bumps the version of pciutils from 3.1.2 to 3.2.1.
>
> Also cleanup the rule files:
>
> - remove of the prepare rule.
> - use of call ptx/ifdef instead ifdefs.
> - Adding support for installing libpci.
> - Also adds a patch with rename the install dependency from
> install-pcilib to install-lib, which also install pkg-config files.
> Smells like a mainline bug, I don't know powertop doesn't find the
> library otherwise.
> - Addings support for libkmod feature (sounds cool).
> - Add install of /usr/bin/update-pciids.
> - fit the help messages in Kconfig in 80 char width.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> ...iutils-install-lib-dependency-when-SHARED.patch | 31 ++++++++++++++++++++++
> patches/pciutils-3.2.1/series | 1 +
> rules/pciutils.in | 23 ++++++++++++----
> rules/pciutils.make | 24 ++++++++---------
> 4 files changed, 61 insertions(+), 18 deletions(-)
> create mode 100644 patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> create mode 100644 patches/pciutils-3.2.1/series
>
> diff --git a/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> new file mode 100644
> index 0000000..84bc3a5
> --- /dev/null
> +++ b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> @@ -0,0 +1,31 @@
> +From d0d7d419885d98f7d54d0a66b321db08f7974a93 Mon Sep 17 00:00:00 2001
> +From: Alexander Aring <alex.aring@gmail.com>
> +Date: Tue, 1 Apr 2014 14:40:33 +0200
> +Subject: [PATCH] pciutils: install-lib dependency when SHARED
> +
> +This patch rename the install rule dependency from install-pcilib
> +to install-lib, when SHARED=yes. The install-pcilib doesn't install the
> +libpci.pc files for pkg-config but install-lib does. This is necessary
> +for packages like powertop which search for the libpci library.
> +
> +Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> +---
> + Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile b/Makefile
> +index 0a21ee8..5b91a5f 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -118,7 +118,7 @@ ifeq ($(SHARED),yes)
> + endif
> +
> + ifeq ($(SHARED),yes)
> +-install: install-pcilib
> ++install: install-lib
> + endif
We can avoid this patch with:
PCIUTILS_INSTALL_OPT := install install-lib
right?
> +
> + install-pcilib: lib/$(PCILIB)
> +--
> +1.9.1
> +
> diff --git a/patches/pciutils-3.2.1/series b/patches/pciutils-3.2.1/series
> new file mode 100644
> index 0000000..c6edb1c
> --- /dev/null
> +++ b/patches/pciutils-3.2.1/series
> @@ -0,0 +1 @@
> +0001-pciutils-install-lib-dependency-when-SHARED.patch
> diff --git a/rules/pciutils.in b/rules/pciutils.in
> index 1c11d65..d44b158 100644
> --- a/rules/pciutils.in
> +++ b/rules/pciutils.in
> @@ -1,12 +1,14 @@
> ## SECTION=shell_and_console
> menuconfig PCIUTILS
> - select ZLIB if PCIUTILS_COMPRESS
> + select ZLIB if PCIUTILS_COMPRESS
> + select LIBKMOD if PCIUTILS_LIBKMOD
> depends on !BUSYBOX_LSPCI || ALLYES
With the libpci option, I think it makes sense to add a PCIUTILS_TOOLS
option (default y). Then we can move the busybox stuff there and you don't
need to care about it in powertop.
> tristate
> prompt "pciutils "
> help
> - The PCI Utilities package contains a library for portable access to PCI bus
> - configuration registers and several utilities based on this library.
> + The PCI Utilities package contains a library for portable access
> + to PCI bus configuration registers and several utilities based on
> + this library.
>
> if PCIUTILS
>
> @@ -15,9 +17,20 @@ config PCIUTILS_COMPRESS
> default y
> prompt "compress pci_ids"
> help
> - Save storage space by compressing the pci-id database. Access will be a
> - little bit slower then.
> + Save storage space by compressing the pci-id database. Access will
> + be a little bit slower then.
>
> +config PCIUTILS_LIBPCI
> + bool
> + prompt "install shared libpci library"
> + help
> + Generate and install the shared libpci library.
> +
> +config PCIUTILS_LIBKMOD
> + bool
> + prompt "libkmod support"
> + help
> + Use libkmod to resolve kernel modules on Linux.
we usually have an empty line here.
> endif
>
> comment "busybox' lspci is selected"
> diff --git a/rules/pciutils.make b/rules/pciutils.make
> index 1490a53..20365d1 100644
> --- a/rules/pciutils.make
> +++ b/rules/pciutils.make
> @@ -17,8 +17,8 @@ PACKAGES-$(PTXCONF_PCIUTILS) += pciutils
> #
> # Paths and names
> #
> -PCIUTILS_VERSION := 3.1.2
> -PCIUTILS_MD5 := 46387fd7a18c33fbb5311fdb3ab9ea12
> +PCIUTILS_VERSION := 3.2.1
> +PCIUTILS_MD5 := 425b1acad6854cc2bbb06ac8e48e76fc
> PCIUTILS := pciutils-$(PCIUTILS_VERSION)
> PCIUTILS_SUFFIX := tar.bz2
> PCIUTILS_URL := $(call ptx/mirror, KERNEL, ../software/utils/pciutils/$(PCIUTILS).$(PCIUTILS_SUFFIX))
> @@ -29,7 +29,7 @@ PCIUTILS_DIR := $(BUILDDIR)/$(PCIUTILS)
> # Prepare
> # ----------------------------------------------------------------------------
>
> -PCIUTILS_PATH := PATH=$(CROSS_PATH)
> +PCIUTILS_CONF_TOOL := NO
> PCIUTILS_COMPILE_ENV := $(CROSS_ENV)
>
> PCIUTILS_MAKEVARS := \
> @@ -38,19 +38,12 @@ PCIUTILS_MAKEVARS := \
> SBINDIR='\$$(PREFIX)/bin' \
> HOST=$(PTXCONF_ARCH_STRING)--linux \
> RELEASE=$(KERNEL_HEADER_VERSION) \
> + ZLIB=$(call ptx/ifdef,PTXCONF_PCIUTILS_COMPRESS,yes,no) \
> + LIBKMOD=$(call ptx/ifdef,PTXCONF_PCIUTILS_LIBKMOD,yes,no) \
> + SHARED=$(call ptx/ifdef,PTXCONF_PCIUTILS_LIBPCI,yes,no) \
> STRIP= \
> DNS=no
>
> -ifdef PTXCONF_PCIUTILS_COMPRESS
> -PCIUTILS_MAKEVARS += ZLIB=yes
> -else
> -PCIUTILS_MAKEVARS += ZLIB=no
> -endif
> -
> -$(STATEDIR)/pciutils.prepare:
> - @$(call targetinfo)
> - @$(call touch)
> -
> # ----------------------------------------------------------------------------
> # Target-Install
> # ----------------------------------------------------------------------------
> @@ -64,8 +57,13 @@ $(STATEDIR)/pciutils.targetinstall:
> @$(call install_fixup, pciutils,AUTHOR,"Robert Schwebel <r.schwebel@pengutronix.de>")
> @$(call install_fixup, pciutils,DESCRIPTION,missing)
>
> +ifdef PTXCONF_PCIUTILS_LIBPCI
> + @$(call install_lib, pciutils, 0, 0, 0644, libpci)
> +endif
> +
> @$(call install_copy, pciutils, 0, 0, 0755, -, /usr/bin/lspci)
> @$(call install_copy, pciutils, 0, 0, 0755, -, /usr/bin/setpci)
> + @$(call install_copy, pciutils, 0, 0, 0755, -, /usr/bin/update-pciids)
> ifdef PTXCONF_PCIUTILS_COMPRESS
> @$(call install_copy, pciutils, 0, 0, 0644, -, \
> /usr/share/pci.ids.gz, n)
> --
> 1.9.1
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 3/3] powertop: add new package
2014-04-01 16:02 ` [ptxdist] [PATCH 3/3] powertop: add new package Alexander Aring
@ 2014-04-02 9:17 ` Michael Olbrich
2014-04-02 10:38 ` Alexander Aring
0 siblings, 1 reply; 14+ messages in thread
From: Michael Olbrich @ 2014-04-02 9:17 UTC (permalink / raw)
To: ptxdist
On Tue, Apr 01, 2014 at 06:02:35PM +0200, Alexander Aring wrote:
> This patch adds the new powertop package with pci support.
>
> Some notice by adding this package:
> The pci support needs the pciutils package which provides the libpci.
> This is the reason why we need a depends on !BUSYBOX_LSPCI there. The
> pciutils packages can't be installed if BUSYBOX_LSPCI is selected.
Just squash this in the first patch please.
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> rules/powertop.in | 42 ++++++++++++++++++++++++++++++++++++++
> rules/powertop.make | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 100 insertions(+)
> create mode 100644 rules/powertop.in
> create mode 100644 rules/powertop.make
>
> diff --git a/rules/powertop.in b/rules/powertop.in
> new file mode 100644
> index 0000000..b1a4dbe
> --- /dev/null
> +++ b/rules/powertop.in
> @@ -0,0 +1,42 @@
> +## SECTION=debug_tools
> +
> +menuconfig POWERTOP
> + tristate
> + prompt "powertop "
> + select LIBNL3
> + select NCURSES
> + select PCIUTILS if POWERTOP_PCI_SUPPORT
> + select PCIUTILS_LIBPCI if POWERTOP_PCI_SUPPORT
> + depends on !BUSYBOX_POWERTOP || ALLYES
> + help
> + PowerTOP is a Linux tool that finds the software
> + component(s) that make your laptop use more power than
> + necessary while it is idle. As of Linux kernel version
> + 2.6.21, the kernel no longer has a fixed 1000Hz timer
> + tick. This will (in theory) give a huge power savings
> + because the CPU stays in low power mode for longer periods
> + of time during system idle.
> +
> + However... there are many things that can ruin the party,
> + both inside the kernel and in userspace. PowerTOP combines
> + various sources of information from the kernel into one
> + convenient screen so that you can see how well your system
> + doing, and which components are the biggest problem.
> +
> +if POWERTOP
> +
> +config POWERTOP_PCI_SUPPORT
> + bool
> + prompt "pci support"
> + depends on !BUSYBOX_LSPCI || ALLYES
> + help
> + This adds powertop support for the PCI bus. Should only be
> + enabled if you have PCI support.
> +
> +comment "BusyBox' lspci is selected!"
> + depends on BUSYBOX_LSPCI
See my comment about that in my other mail.
> +
> +endif
> +
> +comment "BusyBox' powertop is selected!"
> + depends on BUSYBOX_POWERTOP
> diff --git a/rules/powertop.make b/rules/powertop.make
> new file mode 100644
> index 0000000..a5554bc
> --- /dev/null
> +++ b/rules/powertop.make
> @@ -0,0 +1,58 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2009 by Marc Kleine-Budde <mkl@pengutronix.de>
> +# 2014 by Alexander Aring <aar@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_POWERTOP) += powertop
> +
> +#
> +# Paths and names
> +#
> +POWERTOP_VERSION := 2.5
> +POWERTOP_MD5 := 806bbcbd44fcea1f807c9582fc1f7d3e
> +POWERTOP := powertop-$(POWERTOP_VERSION)
> +POWERTOP_SUFFIX := tar.gz
> +POWERTOP_URL := https://01.org/sites/default/files/downloads/powertop/$(POWERTOP).$(POWERTOP_SUFFIX)
> +POWERTOP_SOURCE := $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX)
> +POWERTOP_DIR := $(BUILDDIR)/$(POWERTOP)
> +POWERTOP_LICENSE := GPLv2
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +POWERTOP_CONF_TOOL := autoconf
> +POWERTOP_CONF_OPT := $(CROSS_AUTOCONF_USR)
No usefull configure options? Remove this line in that case.
Michael
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/powertop.targetinstall:
> + @$(call targetinfo)
> +
> + @$(call install_init, powertop)
> + @$(call install_fixup, powertop,PRIORITY,optional)
> + @$(call install_fixup, powertop,SECTION,base)
> + @$(call install_fixup, powertop,AUTHOR,"Alexander Aring <aar@pengutronix.de>")
> + @$(call install_fixup, powertop,DESCRIPTION,missing)
> +
> + @$(call install_copy, powertop, 0, 0, 0755, -, /usr/sbin/powertop)
> +
> + @$(call install_finish, powertop)
> +
> + @$(call touch)
> +
> +# vim: syntax=make
> --
> 1.9.1
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup
2014-04-02 9:15 ` Michael Olbrich
@ 2014-04-02 10:35 ` Alexander Aring
2014-04-03 8:29 ` Alexander Aring
1 sibling, 0 replies; 14+ messages in thread
From: Alexander Aring @ 2014-04-02 10:35 UTC (permalink / raw)
To: ptxdist
On Wed, Apr 02, 2014 at 11:15:46AM +0200, Michael Olbrich wrote:
> On Tue, Apr 01, 2014 at 06:02:34PM +0200, Alexander Aring wrote:
> > This patch bumps the version of pciutils from 3.1.2 to 3.2.1.
> >
> > Also cleanup the rule files:
> >
> > - remove of the prepare rule.
> > - use of call ptx/ifdef instead ifdefs.
> > - Adding support for installing libpci.
> > - Also adds a patch with rename the install dependency from
> > install-pcilib to install-lib, which also install pkg-config files.
> > Smells like a mainline bug, I don't know powertop doesn't find the
> > library otherwise.
> > - Addings support for libkmod feature (sounds cool).
> > - Add install of /usr/bin/update-pciids.
> > - fit the help messages in Kconfig in 80 char width.
> >
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> > ...iutils-install-lib-dependency-when-SHARED.patch | 31 ++++++++++++++++++++++
> > patches/pciutils-3.2.1/series | 1 +
> > rules/pciutils.in | 23 ++++++++++++----
> > rules/pciutils.make | 24 ++++++++---------
> > 4 files changed, 61 insertions(+), 18 deletions(-)
> > create mode 100644 patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > create mode 100644 patches/pciutils-3.2.1/series
> >
> > diff --git a/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > new file mode 100644
> > index 0000000..84bc3a5
> > --- /dev/null
> > +++ b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > @@ -0,0 +1,31 @@
> > +From d0d7d419885d98f7d54d0a66b321db08f7974a93 Mon Sep 17 00:00:00 2001
> > +From: Alexander Aring <alex.aring@gmail.com>
> > +Date: Tue, 1 Apr 2014 14:40:33 +0200
> > +Subject: [PATCH] pciutils: install-lib dependency when SHARED
> > +
> > +This patch rename the install rule dependency from install-pcilib
> > +to install-lib, when SHARED=yes. The install-pcilib doesn't install the
> > +libpci.pc files for pkg-config but install-lib does. This is necessary
> > +for packages like powertop which search for the libpci library.
> > +
> > +Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > +---
> > + Makefile | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/Makefile b/Makefile
> > +index 0a21ee8..5b91a5f 100644
> > +--- a/Makefile
> > ++++ b/Makefile
> > +@@ -118,7 +118,7 @@ ifeq ($(SHARED),yes)
> > + endif
> > +
> > + ifeq ($(SHARED),yes)
> > +-install: install-pcilib
> > ++install: install-lib
> > + endif
>
>
> We can avoid this patch with:
>
> PCIUTILS_INSTALL_OPT := install install-lib
>
> right?
>
I will test it, but I think it could work with
PCIUTILS_INSTALL_OPT := install-lib
only.
> > +
> > + install-pcilib: lib/$(PCILIB)
> > +--
> > +1.9.1
> > +
> > diff --git a/patches/pciutils-3.2.1/series b/patches/pciutils-3.2.1/series
> > new file mode 100644
> > index 0000000..c6edb1c
> > --- /dev/null
> > +++ b/patches/pciutils-3.2.1/series
> > @@ -0,0 +1 @@
> > +0001-pciutils-install-lib-dependency-when-SHARED.patch
> > diff --git a/rules/pciutils.in b/rules/pciutils.in
> > index 1c11d65..d44b158 100644
> > --- a/rules/pciutils.in
> > +++ b/rules/pciutils.in
> > @@ -1,12 +1,14 @@
> > ## SECTION=shell_and_console
> > menuconfig PCIUTILS
> > - select ZLIB if PCIUTILS_COMPRESS
> > + select ZLIB if PCIUTILS_COMPRESS
> > + select LIBKMOD if PCIUTILS_LIBKMOD
> > depends on !BUSYBOX_LSPCI || ALLYES
>
> With the libpci option, I think it makes sense to add a PCIUTILS_TOOLS
> option (default y). Then we can move the busybox stuff there and you don't
> need to care about it in powertop.
>
Yes, of course this is a nice idea.
> > tristate
> > prompt "pciutils "
> > help
> > - The PCI Utilities package contains a library for portable access to PCI bus
> > - configuration registers and several utilities based on this library.
> > + The PCI Utilities package contains a library for portable access
> > + to PCI bus configuration registers and several utilities based on
> > + this library.
> >
> > if PCIUTILS
> >
> > @@ -15,9 +17,20 @@ config PCIUTILS_COMPRESS
> > default y
> > prompt "compress pci_ids"
> > help
> > - Save storage space by compressing the pci-id database. Access will be a
> > - little bit slower then.
> > + Save storage space by compressing the pci-id database. Access will
> > + be a little bit slower then.
> >
> > +config PCIUTILS_LIBPCI
> > + bool
> > + prompt "install shared libpci library"
> > + help
> > + Generate and install the shared libpci library.
> > +
> > +config PCIUTILS_LIBKMOD
> > + bool
> > + prompt "libkmod support"
> > + help
> > + Use libkmod to resolve kernel modules on Linux.
>
> we usually have an empty line here.
>
oops, I will remember it. Thanks Michael.
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 3/3] powertop: add new package
2014-04-02 9:17 ` Michael Olbrich
@ 2014-04-02 10:38 ` Alexander Aring
2014-04-02 13:45 ` Michael Olbrich
0 siblings, 1 reply; 14+ messages in thread
From: Alexander Aring @ 2014-04-02 10:38 UTC (permalink / raw)
To: ptxdist
On Wed, Apr 02, 2014 at 11:17:36AM +0200, Michael Olbrich wrote:
> On Tue, Apr 01, 2014 at 06:02:35PM +0200, Alexander Aring wrote:
> > This patch adds the new powertop package with pci support.
> >
> > Some notice by adding this package:
> > The pci support needs the pciutils package which provides the libpci.
> > This is the reason why we need a depends on !BUSYBOX_LSPCI there. The
> > pciutils packages can't be installed if BUSYBOX_LSPCI is selected.
>
> Just squash this in the first patch please.
ok.
>
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> > rules/powertop.in | 42 ++++++++++++++++++++++++++++++++++++++
> > rules/powertop.make | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 100 insertions(+)
> > create mode 100644 rules/powertop.in
> > create mode 100644 rules/powertop.make
> >
> > diff --git a/rules/powertop.in b/rules/powertop.in
> > new file mode 100644
> > index 0000000..b1a4dbe
> > --- /dev/null
> > +++ b/rules/powertop.in
> > @@ -0,0 +1,42 @@
> > +## SECTION=debug_tools
> > +
> > +menuconfig POWERTOP
> > + tristate
> > + prompt "powertop "
> > + select LIBNL3
> > + select NCURSES
> > + select PCIUTILS if POWERTOP_PCI_SUPPORT
> > + select PCIUTILS_LIBPCI if POWERTOP_PCI_SUPPORT
> > + depends on !BUSYBOX_POWERTOP || ALLYES
> > + help
> > + PowerTOP is a Linux tool that finds the software
> > + component(s) that make your laptop use more power than
> > + necessary while it is idle. As of Linux kernel version
> > + 2.6.21, the kernel no longer has a fixed 1000Hz timer
> > + tick. This will (in theory) give a huge power savings
> > + because the CPU stays in low power mode for longer periods
> > + of time during system idle.
> > +
> > + However... there are many things that can ruin the party,
> > + both inside the kernel and in userspace. PowerTOP combines
> > + various sources of information from the kernel into one
> > + convenient screen so that you can see how well your system
> > + doing, and which components are the biggest problem.
> > +
> > +if POWERTOP
> > +
> > +config POWERTOP_PCI_SUPPORT
> > + bool
> > + prompt "pci support"
> > + depends on !BUSYBOX_LSPCI || ALLYES
> > + help
> > + This adds powertop support for the PCI bus. Should only be
> > + enabled if you have PCI support.
> > +
> > +comment "BusyBox' lspci is selected!"
> > + depends on BUSYBOX_LSPCI
>
> See my comment about that in my other mail
ok.
>
> > +
> > +endif
> > +
> > +comment "BusyBox' powertop is selected!"
> > + depends on BUSYBOX_POWERTOP
> > diff --git a/rules/powertop.make b/rules/powertop.make
> > new file mode 100644
> > index 0000000..a5554bc
> > --- /dev/null
> > +++ b/rules/powertop.make
> > @@ -0,0 +1,58 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2009 by Marc Kleine-Budde <mkl@pengutronix.de>
> > +# 2014 by Alexander Aring <aar@pengutronix.de>
> > +#
> > +# See CREDITS for details about who has contributed to this project.
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_POWERTOP) += powertop
> > +
> > +#
> > +# Paths and names
> > +#
> > +POWERTOP_VERSION := 2.5
> > +POWERTOP_MD5 := 806bbcbd44fcea1f807c9582fc1f7d3e
> > +POWERTOP := powertop-$(POWERTOP_VERSION)
> > +POWERTOP_SUFFIX := tar.gz
> > +POWERTOP_URL := https://01.org/sites/default/files/downloads/powertop/$(POWERTOP).$(POWERTOP_SUFFIX)
> > +POWERTOP_SOURCE := $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX)
> > +POWERTOP_DIR := $(BUILDDIR)/$(POWERTOP)
> > +POWERTOP_LICENSE := GPLv2
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +#
> > +# autoconf
> > +#
> > +POWERTOP_CONF_TOOL := autoconf
> > +POWERTOP_CONF_OPT := $(CROSS_AUTOCONF_USR)
>
> No usefull configure options? Remove this line in that case.
>
Yes no useful options here, useful options would be a --disable-pci or
--enable-pci explicit, but they search for pkgconfig files and enabled
it if they found some one. I think that's ok.
Thanks.
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 3/3] powertop: add new package
2014-04-02 10:38 ` Alexander Aring
@ 2014-04-02 13:45 ` Michael Olbrich
2014-04-02 14:00 ` Alexander Aring
0 siblings, 1 reply; 14+ messages in thread
From: Michael Olbrich @ 2014-04-02 13:45 UTC (permalink / raw)
To: ptxdist
On Wed, Apr 02, 2014 at 12:38:27PM +0200, Alexander Aring wrote:
> On Wed, Apr 02, 2014 at 11:17:36AM +0200, Michael Olbrich wrote:
> > On Tue, Apr 01, 2014 at 06:02:35PM +0200, Alexander Aring wrote:
> > > This patch adds the new powertop package with pci support.
> > >
> > > Some notice by adding this package:
> > > The pci support needs the pciutils package which provides the libpci.
> > > This is the reason why we need a depends on !BUSYBOX_LSPCI there. The
> > > pciutils packages can't be installed if BUSYBOX_LSPCI is selected.
> >
> > Just squash this in the first patch please.
> ok.
>
> >
> > > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > > ---
> > > rules/powertop.in | 42 ++++++++++++++++++++++++++++++++++++++
> > > rules/powertop.make | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 100 insertions(+)
> > > create mode 100644 rules/powertop.in
> > > create mode 100644 rules/powertop.make
> > >
> > > diff --git a/rules/powertop.in b/rules/powertop.in
> > > new file mode 100644
> > > index 0000000..b1a4dbe
> > > --- /dev/null
> > > +++ b/rules/powertop.in
> > > @@ -0,0 +1,42 @@
> > > +## SECTION=debug_tools
> > > +
> > > +menuconfig POWERTOP
> > > + tristate
> > > + prompt "powertop "
> > > + select LIBNL3
> > > + select NCURSES
> > > + select PCIUTILS if POWERTOP_PCI_SUPPORT
> > > + select PCIUTILS_LIBPCI if POWERTOP_PCI_SUPPORT
> > > + depends on !BUSYBOX_POWERTOP || ALLYES
> > > + help
> > > + PowerTOP is a Linux tool that finds the software
> > > + component(s) that make your laptop use more power than
> > > + necessary while it is idle. As of Linux kernel version
> > > + 2.6.21, the kernel no longer has a fixed 1000Hz timer
> > > + tick. This will (in theory) give a huge power savings
> > > + because the CPU stays in low power mode for longer periods
> > > + of time during system idle.
> > > +
> > > + However... there are many things that can ruin the party,
> > > + both inside the kernel and in userspace. PowerTOP combines
> > > + various sources of information from the kernel into one
> > > + convenient screen so that you can see how well your system
> > > + doing, and which components are the biggest problem.
> > > +
> > > +if POWERTOP
> > > +
> > > +config POWERTOP_PCI_SUPPORT
> > > + bool
> > > + prompt "pci support"
> > > + depends on !BUSYBOX_LSPCI || ALLYES
> > > + help
> > > + This adds powertop support for the PCI bus. Should only be
> > > + enabled if you have PCI support.
> > > +
> > > +comment "BusyBox' lspci is selected!"
> > > + depends on BUSYBOX_LSPCI
> >
> > See my comment about that in my other mail
> ok.
>
> >
> > > +
> > > +endif
> > > +
> > > +comment "BusyBox' powertop is selected!"
> > > + depends on BUSYBOX_POWERTOP
> > > diff --git a/rules/powertop.make b/rules/powertop.make
> > > new file mode 100644
> > > index 0000000..a5554bc
> > > --- /dev/null
> > > +++ b/rules/powertop.make
> > > @@ -0,0 +1,58 @@
> > > +# -*-makefile-*-
> > > +#
> > > +# Copyright (C) 2009 by Marc Kleine-Budde <mkl@pengutronix.de>
> > > +# 2014 by Alexander Aring <aar@pengutronix.de>
> > > +#
> > > +# See CREDITS for details about who has contributed to this project.
> > > +#
> > > +# For further information about the PTXdist project and license conditions
> > > +# see the README file.
> > > +#
> > > +
> > > +#
> > > +# We provide this package
> > > +#
> > > +PACKAGES-$(PTXCONF_POWERTOP) += powertop
> > > +
> > > +#
> > > +# Paths and names
> > > +#
> > > +POWERTOP_VERSION := 2.5
> > > +POWERTOP_MD5 := 806bbcbd44fcea1f807c9582fc1f7d3e
> > > +POWERTOP := powertop-$(POWERTOP_VERSION)
> > > +POWERTOP_SUFFIX := tar.gz
> > > +POWERTOP_URL := https://01.org/sites/default/files/downloads/powertop/$(POWERTOP).$(POWERTOP_SUFFIX)
> > > +POWERTOP_SOURCE := $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX)
> > > +POWERTOP_DIR := $(BUILDDIR)/$(POWERTOP)
> > > +POWERTOP_LICENSE := GPLv2
> > > +
> > > +# ----------------------------------------------------------------------------
> > > +# Prepare
> > > +# ----------------------------------------------------------------------------
> > > +
> > > +#
> > > +# autoconf
> > > +#
> > > +POWERTOP_CONF_TOOL := autoconf
> > > +POWERTOP_CONF_OPT := $(CROSS_AUTOCONF_USR)
> >
> > No usefull configure options? Remove this line in that case.
> >
> Yes no useful options here, useful options would be a --disable-pci or
> --enable-pci explicit, but they search for pkgconfig files and enabled
> it if they found some one. I think that's ok.
Please add it. Otherwise you may get pci support or not when the option is
disabled. That's not good.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 3/3] powertop: add new package
2014-04-02 13:45 ` Michael Olbrich
@ 2014-04-02 14:00 ` Alexander Aring
0 siblings, 0 replies; 14+ messages in thread
From: Alexander Aring @ 2014-04-02 14:00 UTC (permalink / raw)
To: ptxdist
> > >
> > > No usefull configure options? Remove this line in that case.
> > >
> > Yes no useful options here, useful options would be a --disable-pci or
> > --enable-pci explicit, but they search for pkgconfig files and enabled
> > it if they found some one. I think that's ok.
>
> Please add it. Otherwise you may get pci support or not when the option is
> disabled. That's not good.
>
Yes, Sir.
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup
2014-04-02 9:15 ` Michael Olbrich
2014-04-02 10:35 ` Alexander Aring
@ 2014-04-03 8:29 ` Alexander Aring
2014-04-03 8:48 ` Michael Olbrich
1 sibling, 1 reply; 14+ messages in thread
From: Alexander Aring @ 2014-04-03 8:29 UTC (permalink / raw)
To: ptxdist
Hi Michael,
On Wed, Apr 02, 2014 at 11:15:46AM +0200, Michael Olbrich wrote:
> On Tue, Apr 01, 2014 at 06:02:34PM +0200, Alexander Aring wrote:
> > This patch bumps the version of pciutils from 3.1.2 to 3.2.1.
> >
> > Also cleanup the rule files:
> >
> > - remove of the prepare rule.
> > - use of call ptx/ifdef instead ifdefs.
> > - Adding support for installing libpci.
> > - Also adds a patch with rename the install dependency from
> > install-pcilib to install-lib, which also install pkg-config files.
> > Smells like a mainline bug, I don't know powertop doesn't find the
> > library otherwise.
> > - Addings support for libkmod feature (sounds cool).
> > - Add install of /usr/bin/update-pciids.
> > - fit the help messages in Kconfig in 80 char width.
> >
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> > ...iutils-install-lib-dependency-when-SHARED.patch | 31 ++++++++++++++++++++++
> > patches/pciutils-3.2.1/series | 1 +
> > rules/pciutils.in | 23 ++++++++++++----
> > rules/pciutils.make | 24 ++++++++---------
> > 4 files changed, 61 insertions(+), 18 deletions(-)
> > create mode 100644 patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > create mode 100644 patches/pciutils-3.2.1/series
> >
> > diff --git a/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > new file mode 100644
> > index 0000000..84bc3a5
> > --- /dev/null
> > +++ b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > @@ -0,0 +1,31 @@
> > +From d0d7d419885d98f7d54d0a66b321db08f7974a93 Mon Sep 17 00:00:00 2001
> > +From: Alexander Aring <alex.aring@gmail.com>
> > +Date: Tue, 1 Apr 2014 14:40:33 +0200
> > +Subject: [PATCH] pciutils: install-lib dependency when SHARED
> > +
> > +This patch rename the install rule dependency from install-pcilib
> > +to install-lib, when SHARED=yes. The install-pcilib doesn't install the
> > +libpci.pc files for pkg-config but install-lib does. This is necessary
> > +for packages like powertop which search for the libpci library.
> > +
> > +Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > +---
> > + Makefile | 2 +-
> > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > +
> > +diff --git a/Makefile b/Makefile
> > +index 0a21ee8..5b91a5f 100644
> > +--- a/Makefile
> > ++++ b/Makefile
> > +@@ -118,7 +118,7 @@ ifeq ($(SHARED),yes)
> > + endif
> > +
> > + ifeq ($(SHARED),yes)
> > +-install: install-pcilib
> > ++install: install-lib
> > + endif
>
>
> We can avoid this patch with:
>
> PCIUTILS_INSTALL_OPT := install install-lib
>
When I use INSTALL_OPT here I get a:
ptxdist: error: ptxd_make_world_init_compat: <PKG>_MAKEVARS is incompatible with <PKG>_INSTALL_OPT
and I detected we need something like:
PCIUTILS_INSTALL_OPT := $(call ptx/ifdef,PTXCONF_PCIUTILS_LIBPCI,install-pcilib,install)
because we can't run install-pcilib if SHARED MAKEVAR is not yes. Maybe I can
overwrite the install rule for that or should I keep the patch?
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup
2014-04-03 8:29 ` Alexander Aring
@ 2014-04-03 8:48 ` Michael Olbrich
0 siblings, 0 replies; 14+ messages in thread
From: Michael Olbrich @ 2014-04-03 8:48 UTC (permalink / raw)
To: ptxdist
On Thu, Apr 03, 2014 at 10:29:40AM +0200, Alexander Aring wrote:
> Hi Michael,
>
> On Wed, Apr 02, 2014 at 11:15:46AM +0200, Michael Olbrich wrote:
> > On Tue, Apr 01, 2014 at 06:02:34PM +0200, Alexander Aring wrote:
> > > This patch bumps the version of pciutils from 3.1.2 to 3.2.1.
> > >
> > > Also cleanup the rule files:
> > >
> > > - remove of the prepare rule.
> > > - use of call ptx/ifdef instead ifdefs.
> > > - Adding support for installing libpci.
> > > - Also adds a patch with rename the install dependency from
> > > install-pcilib to install-lib, which also install pkg-config files.
> > > Smells like a mainline bug, I don't know powertop doesn't find the
> > > library otherwise.
> > > - Addings support for libkmod feature (sounds cool).
> > > - Add install of /usr/bin/update-pciids.
> > > - fit the help messages in Kconfig in 80 char width.
> > >
> > > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > > ---
> > > ...iutils-install-lib-dependency-when-SHARED.patch | 31 ++++++++++++++++++++++
> > > patches/pciutils-3.2.1/series | 1 +
> > > rules/pciutils.in | 23 ++++++++++++----
> > > rules/pciutils.make | 24 ++++++++---------
> > > 4 files changed, 61 insertions(+), 18 deletions(-)
> > > create mode 100644 patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > > create mode 100644 patches/pciutils-3.2.1/series
> > >
> > > diff --git a/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > > new file mode 100644
> > > index 0000000..84bc3a5
> > > --- /dev/null
> > > +++ b/patches/pciutils-3.2.1/0001-pciutils-install-lib-dependency-when-SHARED.patch
> > > @@ -0,0 +1,31 @@
> > > +From d0d7d419885d98f7d54d0a66b321db08f7974a93 Mon Sep 17 00:00:00 2001
> > > +From: Alexander Aring <alex.aring@gmail.com>
> > > +Date: Tue, 1 Apr 2014 14:40:33 +0200
> > > +Subject: [PATCH] pciutils: install-lib dependency when SHARED
> > > +
> > > +This patch rename the install rule dependency from install-pcilib
> > > +to install-lib, when SHARED=yes. The install-pcilib doesn't install the
> > > +libpci.pc files for pkg-config but install-lib does. This is necessary
> > > +for packages like powertop which search for the libpci library.
> > > +
> > > +Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > > +---
> > > + Makefile | 2 +-
> > > + 1 file changed, 1 insertion(+), 1 deletion(-)
> > > +
> > > +diff --git a/Makefile b/Makefile
> > > +index 0a21ee8..5b91a5f 100644
> > > +--- a/Makefile
> > > ++++ b/Makefile
> > > +@@ -118,7 +118,7 @@ ifeq ($(SHARED),yes)
> > > + endif
> > > +
> > > + ifeq ($(SHARED),yes)
> > > +-install: install-pcilib
> > > ++install: install-lib
> > > + endif
> >
> >
> > We can avoid this patch with:
> >
> > PCIUTILS_INSTALL_OPT := install install-lib
> >
> When I use INSTALL_OPT here I get a:
>
> ptxdist: error: ptxd_make_world_init_compat: <PKG>_MAKEVARS is incompatible with <PKG>_INSTALL_OPT
>
> and I detected we need something like:
>
> PCIUTILS_INSTALL_OPT := $(call ptx/ifdef,PTXCONF_PCIUTILS_LIBPCI,install-pcilib,install)
>
> because we can't run install-pcilib if SHARED MAKEVAR is not yes. Maybe I can
> overwrite the install rule for that or should I keep the patch?
Right. Rename PCIUTILS_MAKEVARS to PCIUTILS_MAKE_OPT and then:
PCIUTILS_INSTALL_OPT := \
$(PCIUTILS_MAKE_OPT) \
$(call ptx/ifdef,PTXCONF_PCIUTILS_LIBPCI,install-pcilib,install)
or something like that.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 0/3] powertop: add new version with new features
2014-04-01 16:02 [ptxdist] [PATCH 0/3] powertop: add new version with new features Alexander Aring
` (2 preceding siblings ...)
2014-04-01 16:02 ` [ptxdist] [PATCH 3/3] powertop: add new package Alexander Aring
@ 2014-04-07 8:03 ` Juergen Beisert
2014-04-07 14:17 ` Alexander Aring
3 siblings, 1 reply; 14+ messages in thread
From: Juergen Beisert @ 2014-04-07 8:03 UTC (permalink / raw)
To: ptxdist; +Cc: Alexander Aring
Hi Alexander,
your package currently fails with:
[...]
parameters/powertop-persistent.o: In function `save_all_results(char const*)':
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:46: undefined reference to `gettext(char const*)'
parameters/powertop-persistent.o: In function `save_parameters(char const*)':
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:140: undefined reference to `gettext(char const*)'
parameters/powertop-persistent.o: In function `load_parameters(char const*)':
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:165: undefined reference to `gettext(char const*)'
parameters/powertop-persistent.o: In function `load_results(char const*)':
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:78: undefined reference to `gettext(char const*)'
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:123: undefined reference to `gettext(char const*)'
cpu/powertop-abstract_cpu.o:OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/cpu/abstract_cpu.cpp:59: more undefined references to `gettext(char const*)' follow
powertop-main.o: In function `main':
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:372: undefined reference to `bindtextdomain(char const*, char const*)'
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:373: undefined reference to `textdomain(char const*)'
powertop-main.o: In function `print_usage':
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:110: undefined reference to `gettext(char const*)'
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:111: undefined reference to `gettext(char const*)'
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:112: undefined reference to `gettext(char const*)'
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:113: undefined reference to `gettext(char const*)'
OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:114: undefined reference to `gettext(char const*)'
powertop-main.o:OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:115: more undefined references to `gettext(char const*)' follow
collect2: error: ld returned 1 exit status
make[4]: Leaving directory `OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src'
make[3]: Leaving directory `OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src'
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [ptxdist] [PATCH 0/3] powertop: add new version with new features
2014-04-07 8:03 ` [ptxdist] [PATCH 0/3] powertop: add new version with new features Juergen Beisert
@ 2014-04-07 14:17 ` Alexander Aring
0 siblings, 0 replies; 14+ messages in thread
From: Alexander Aring @ 2014-04-07 14:17 UTC (permalink / raw)
To: Juergen Beisert; +Cc: ptxdist
Hi Juergen,
On Mon, Apr 07, 2014 at 10:03:54AM +0200, Juergen Beisert wrote:
> Hi Alexander,
>
> your package currently fails with:
>
> [...]
> parameters/powertop-persistent.o: In function `save_all_results(char const*)':
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:46: undefined reference to `gettext(char const*)'
> parameters/powertop-persistent.o: In function `save_parameters(char const*)':
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:140: undefined reference to `gettext(char const*)'
> parameters/powertop-persistent.o: In function `load_parameters(char const*)':
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:165: undefined reference to `gettext(char const*)'
> parameters/powertop-persistent.o: In function `load_results(char const*)':
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:78: undefined reference to `gettext(char const*)'
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/parameters/persistent.cpp:123: undefined reference to `gettext(char const*)'
> cpu/powertop-abstract_cpu.o:OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/cpu/abstract_cpu.cpp:59: more undefined references to `gettext(char const*)' follow
> powertop-main.o: In function `main':
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:372: undefined reference to `bindtextdomain(char const*, char const*)'
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:373: undefined reference to `textdomain(char const*)'
> powertop-main.o: In function `print_usage':
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:110: undefined reference to `gettext(char const*)'
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:111: undefined reference to `gettext(char const*)'
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:112: undefined reference to `gettext(char const*)'
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:113: undefined reference to `gettext(char const*)'
> OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:114: undefined reference to `gettext(char const*)'
> powertop-main.o:OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src/main.cpp:115: more undefined references to `gettext(char const*)' follow
> collect2: error: ld returned 1 exit status
> make[4]: Leaving directory `OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src'
> make[3]: Leaving directory `OSELAS.BSP-Pengutronix-AllYes-trunk/platform-ARM-reference/build-target/powertop-2.5/src'
>
thanks for this report. I sent a patch to disable the native language
support. I hope this will fix the issue.
Apologise for the inconvenience.
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-04-07 14:17 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-01 16:02 [ptxdist] [PATCH 0/3] powertop: add new version with new features Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 1/3] powertop: remove powertop package Alexander Aring
2014-04-01 16:02 ` [ptxdist] [PATCH 2/3] pciutils: bump version and cleanup Alexander Aring
2014-04-02 9:15 ` Michael Olbrich
2014-04-02 10:35 ` Alexander Aring
2014-04-03 8:29 ` Alexander Aring
2014-04-03 8:48 ` Michael Olbrich
2014-04-01 16:02 ` [ptxdist] [PATCH 3/3] powertop: add new package Alexander Aring
2014-04-02 9:17 ` Michael Olbrich
2014-04-02 10:38 ` Alexander Aring
2014-04-02 13:45 ` Michael Olbrich
2014-04-02 14:00 ` Alexander Aring
2014-04-07 8:03 ` [ptxdist] [PATCH 0/3] powertop: add new version with new features Juergen Beisert
2014-04-07 14:17 ` Alexander Aring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox