mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 1/2] net-snmp: drop usage of undefined Kconfig variables
Date: Tue,  3 Sep 2013 22:29:46 +0200	[thread overview]
Message-ID: <1378240187-21469-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)

Some variables that are used in the .make file with ifdef are not defined
in the .in file. So all ifdefs evaluate to false. Hard-code this behaviour
instead.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 rules/net-snmp.make | 65 +++++++++--------------------------------------------
 1 file changed, 10 insertions(+), 55 deletions(-)

diff --git a/rules/net-snmp.make b/rules/net-snmp.make
index 24efa72..6cb0952 100644
--- a/rules/net-snmp.make
+++ b/rules/net-snmp.make
@@ -50,7 +50,16 @@ NET_SNMP_AUTOCONF := \
 	--enable-shared \
 	--disable-embedded-perl \
 	--without-perl-modules \
-	--disable-static
+	--disable-static \
+	--disable-privacy \
+	--disable-internal-md5 \
+	--disable-agentx-dom-sock-only \
+	--disable-mib-config-checking \
+	--disable-mfd-rewrites \
+	--disable-testing-code \
+	--disable-reentrant \
+	--disable-embedded-perl \
+	--disable-ucd-snmp-compatibility
 
 ifdef PTXCONF_ENDIAN_LITTLE
 NET_SNMP_AUTOCONF += --with-endianness=little
@@ -144,60 +153,6 @@ else
 NET_SNMP_AUTOCONF += --disable-developer
 endif
 
-ifdef PTXCONF_NET_SNMP_PRIVACY
-NET_SNMP_AUTOCONF += --enable-privacy
-else
-NET_SNMP_AUTOCONF += --disable-privacy
-endif
-
-ifdef PTXCONF_NET_SNMP_INTERNAL_MD5
-NET_SNMP_AUTOCONF += --enable-internal-md5
-else
-NET_SNMP_AUTOCONF += --disable-internal-md5
-endif
-
-ifdef PTXCONF_NET_SNMP_AGENTX_DOM_SOCK_ONLY
-NET_SNMP_AUTOCONF += --enable-agentx-dom-sock-only
-else
-NET_SNMP_AUTOCONF += --disable-agentx-dom-sock-only
-endif
-
-ifdef PTXCONF_NET_SNMP_MIB_CONFIG_CHECKING
-NET_SNMP_AUTOCONF += --enable-mib-config-checking
-else
-NET_SNMP_AUTOCONF += --disable-mib-config-checking
-endif
-
-ifdef PTXCONF_NET_SNMP_MFD_REWRITES
-NET_SNMP_AUTOCONF += --enable-mfd-rewrites
-else
-NET_SNMP_AUTOCONF += --disable-mfd-rewrites
-endif
-
-ifdef PTXCONF_NET_SNMP_TESTING_CODE
-NET_SNMP_AUTOCONF += --enable-testing-code
-else
-NET_SNMP_AUTOCONF += --disable-testing-code
-endif
-
-ifdef PTXCONF_NET_SNMP_REENTRANT
-NET_SNMP_AUTOCONF += --enable-reentrant
-else
-NET_SNMP_AUTOCONF += --disable-reentrant
-endif
-
-ifdef PTXCONF_NET_SNMP_EMBEDDED_PERL
-NET_SNMP_AUTOCONF += --enable-embedded-perl
-else
-NET_SNMP_AUTOCONF += --disable-embedded-perl
-endif
-
-ifdef PTXCONF_NET_SNMP_UCD_COMPAT
-NET_SNMP_AUTOCONF += --enable-ucd-snmp-compatibility
-else
-NET_SNMP_AUTOCONF += --disable-ucd-snmp-compatibility
-endif
-
 ##NET_SNMP_AUTOCONF	+= --with-mib-modules=mibII
 ##NET_SNMP_AUTOCONF	+= --with-sys-contact=root@localhost
 ##NET_SNMP_AUTOCONF	+= --with-sys-location=unknown
-- 
1.8.4.rc3


-- 
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2013-09-03 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 20:29 Uwe Kleine-König [this message]
2013-09-03 20:29 ` [ptxdist] [PATCH 2/2] net-snmp: make the agent's availability via TCP/UDP configurable Uwe Kleine-König
2013-09-06  7:28 ` [ptxdist] [PATCH 1/2] net-snmp: drop usage of undefined Kconfig variables Uwe Kleine-König
2013-09-10 14:31 ` Alexander Dahl
2013-09-10 19:25   ` Uwe Kleine-König
2013-09-11  7:29     ` Alexander Dahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378240187-21469-1-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox