mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] Fix problem with finding platforms/*.in
Date: Fri, 16 Aug 2013 17:25:53 +0200	[thread overview]
Message-ID: <1376666753-14829-1-git-send-email-bernhard@bwalle.de> (raw)

ptxdist 2013.08 doesn't find my platforms/u-boot.in file. This is
because it looks for ":/path/to/bsp/platforms" instead of the variant
without colon.

Following shell script demonstrates that:

    #!/bin/bash

    oldifs="$IFS"
    IFS=: a="1:2:3:" b="4:5:6:"
    c=(${a}:${b})
    d=(${a} ${b})
    IFS="$oldifs"
    echo ${c[@]} # 1 2 3 :4 5 6
    echo ${d[@]} # 1 2 3 4 5 6

So only the variant without a ':' is correct.

The problem was introduced with 51c5786c16a9a3508af9b6cc69947a2f3b8bc7cf
on 20th June 2013. So I think it was also in 2013.07 although I didn't
test.(

Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
---
 scripts/lib/ptxd_lib_kgen.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/ptxd_lib_kgen.sh b/scripts/lib/ptxd_lib_kgen.sh
index 6c7b54b..c50df13 100644
--- a/scripts/lib/ptxd_lib_kgen.sh
+++ b/scripts/lib/ptxd_lib_kgen.sh
@@ -90,7 +90,7 @@ EOF
     # transmogrify part into subdir
     local oldIFS="$IFS"
     case "${kgen_part}" in
-	ptx|platform) IFS=: kgen_dirs=( ${PTXDIST_PATH_RULES}:${PTXDIST_PATH_PLATFORMS} ) ;;
+	ptx|platform) IFS=: kgen_dirs=( ${PTXDIST_PATH_RULES} ${PTXDIST_PATH_PLATFORMS} ) ;;
 	board|user|collection) return 0 ;;
 	*) cat <<EOF
 
-- 
1.8.3.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2013-08-16 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 15:25 Bernhard Walle [this message]
2013-08-20  9:29 ` Alexander Dahl
2013-08-20 11:05 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376666753-14829-1-git-send-email-bernhard@bwalle.de \
    --to=bernhard@bwalle.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox