[ptxdist] [PATCH] glew: link against libX11

[ptxdist] [PATCH] glew: link against libX11

[Robert Schwebel]

src/visualinfo.c and src/glewinfo.c call XDestroyWindow, so we need to link against libX11.
Otherwhise this breaks down with

/opt/OSELAS.Toolchain-2012.12.0/arm-1136jfs-linux-gnueabi/gcc-4.7.2-glibc-2.16.0-binutils-2.22-kernel-3.6-sanitized/bin/../lib/gcc/arm-1136jfs-linux-gnueabi/4.7.2/../../../../arm-1136jfs-linux-gnueabi/bin/ld: src/glewinfo.o: undefined reference to symbol 'XDestroyWindow'

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
 rules/glew.make |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/glew.make b/rules/glew.make
index 08acaff..9242201 100644
--- a/rules/glew.make
+++ b/rules/glew.make
@@ -41,7 +41,7 @@ GLEW_MAKE_OPT	:= \
 	LD=$(CROSS_CC) \
 	CFLAGS.EXTRA='$(CROSS_CPPFLAGS) $(CROSS_CFLAGS)' \
 	LDFLAGS.EXTRA='$(CROSS_LDFLAGS)' \
-	LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu`' \
+	LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu` -lX11' \
 	GLEW_DEST=$(GLEW_PKGDIR)/usr \
 	LIBDIR=$(GLEW_PKGDIR)/usr/lib \
 	M_ARCH=$(PTXCONF_ARCH_STRING)
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] glew: link against libX11

[Alexander Aring]

Hi Robert,

On Sun, Mar 31, 2013 at 08:17:43PM +0200, Robert Schwebel wrote:
> src/visualinfo.c and src/glewinfo.c call XDestroyWindow, so we need to link against libX11.
> Otherwhise this breaks down with
> 
> /opt/OSELAS.Toolchain-2012.12.0/arm-1136jfs-linux-gnueabi/gcc-4.7.2-glibc-2.16.0-binutils-2.22-kernel-3.6-sanitized/bin/../lib/gcc/arm-1136jfs-linux-gnueabi/4.7.2/../../../../arm-1136jfs-linux-gnueabi/bin/ld: src/glewinfo.o: undefined reference to symbol 'XDestroyWindow'
> 
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
>  rules/glew.make |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/glew.make b/rules/glew.make
> index 08acaff..9242201 100644
> --- a/rules/glew.make
> +++ b/rules/glew.make
> @@ -41,7 +41,7 @@ GLEW_MAKE_OPT	:= \
>  	LD=$(CROSS_CC) \
>  	CFLAGS.EXTRA='$(CROSS_CPPFLAGS) $(CROSS_CFLAGS)' \
>  	LDFLAGS.EXTRA='$(CROSS_LDFLAGS)' \
> -	LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu`' \
> +	LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu` -lX11' \
Or you can do:
LDFLAGS.GL='`$(CROSS_ENV) eval PATH=$(CROSS_PATH) $$PKG_CONFIG --libs glu x11`' \

if X11 change something in their pkg-config ldflag behavior, renaming
library(I hope this will never happen) or something else.

Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de