From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-bk0-x229.google.com ([2a00:1450:4008:c01::229])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <chf.fritz@googlemail.com>) id 1UDBJ2-0004Jz-GS
	for ptxdist@pengutronix.de; Wed, 06 Mar 2013 11:10:41 +0100
Received: by mail-bk0-f41.google.com with SMTP id q16so275332bkw.0
	for <ptxdist@pengutronix.de>; Wed, 06 Mar 2013 02:10:33 -0800 (PST)
From: Christoph Fritz <chf.fritz@googlemail.com>
In-Reply-To: <20130306082132.GH7949@pengutronix.de>
References: <1361395347.22777.1.camel@mars>
	<20130304170456.GY5360@pengutronix.de> <1362512222.4075.334.camel@mars>
	<20130306082132.GH7949@pengutronix.de>
Date: Wed, 06 Mar 2013 11:10:30 +0100
Message-ID: <1362564630.3919.30.camel@mars>
Mime-Version: 1.0
Subject: Re: [ptxdist] [PATCH v2] strongswan: add package
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, 2013-03-06 at 09:21 +0100, Michael Olbrich wrote:
> On Tue, Mar 05, 2013 at 08:37:02PM +0100, Christoph Fritz wrote:
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +STRONGSWAN_CONF_TOOL	:= autoconf
> > +STRONGSWAN_CONF_OPT	:= \
> > +	$(CROSS_AUTOCONF_USR) \
> > +	--with-ipseclibdir=/usr/lib
> 
> I'm not sure if you misunderstood something, but I didn't mean that you
> should remove the configure options.

Thanks for the notice. I got you right. But v2 of this patch is no
"preliminary testing version" any more and the configure script is doing
a fine job with a good handful of plugins to connect to enough peer
configurations.
It's a bit versatile you may think, but this fits my needs best.

> You should explicitly specify all the options from the "Optional Features"
> section from "./configure --help".

And then comment out the ones which will never be used, either by
kconfig opt-in nor opt-out?

> A good starting point  usually is to add a kconfig options for all features
> that have external dependencies (don't forget the 'select' in
> strongswan.in) and choose a reasonable default for all others.

Let me reroll this.

> 
> It's also a good idea to run "readelf -d <binary>" to check if you missed
> any dependencies.

I already did this by using ldd.

Thanks
 -- Christoph



-- 
ptxdist mailing list
ptxdist@pengutronix.de