Re: [ptxdist] [PATCH v2] strongswan: add package

[Christoph Fritz <chf.fritz@googlemail.com>]

On Wed, 2013-03-06 at 09:21 +0100, Michael Olbrich wrote:
> On Tue, Mar 05, 2013 at 08:37:02PM +0100, Christoph Fritz wrote:
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +STRONGSWAN_CONF_TOOL	:= autoconf
> > +STRONGSWAN_CONF_OPT	:= \
> > +	$(CROSS_AUTOCONF_USR) \
> > +	--with-ipseclibdir=/usr/lib
> 
> I'm not sure if you misunderstood something, but I didn't mean that you
> should remove the configure options.

Thanks for the notice. I got you right. But v2 of this patch is no
"preliminary testing version" any more and the configure script is doing
a fine job with a good handful of plugins to connect to enough peer
configurations.
It's a bit versatile you may think, but this fits my needs best.

> You should explicitly specify all the options from the "Optional Features"
> section from "./configure --help".

And then comment out the ones which will never be used, either by
kconfig opt-in nor opt-out?

> A good starting point  usually is to add a kconfig options for all features
> that have external dependencies (don't forget the 'select' in
> strongswan.in) and choose a reasonable default for all others.

Let me reroll this.

> 
> It's also a good idea to run "readelf -d <binary>" to check if you missed
> any dependencies.

I already did this by using ldd.

Thanks
 -- Christoph



-- 
ptxdist mailing list
ptxdist@pengutronix.de