mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] argp-fmtstream.h: Force inlining of 'extern inline' functions
Date: Sat,  7 Apr 2012 20:32:25 +0200	[thread overview]
Message-ID: <1333823545-62787-1-git-send-email-bernhard@bwalle.de> (raw)
In-Reply-To: <20120407183017.GA32754@regiomontanus.bwalle.de>

LLVM GCC (at least i686-apple-darwin11-llvm-gcc-4.2) doesn't generate a
non-inlined version of argp_fmtstream_putc (even if compiled with -O2),
so linking the final program fails:

------------------------------------------------------
Undefined symbols for architecture x86_64:
  "_argp_fmtstream_putc", referenced from:
      _usage_argful_short_opt in argp-help.o
      _argp_args_usage in argp-help.o
ld: symbol(s) not found for architecture x86_64
------------------------------------------------------

FSF GCC doesn't have the problem, BTW.

Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
---
NOTE: This patch applies to ptx branch of mol/localedef, not to PTXdist.

 eglibc/argp/argp-fmtstream.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eglibc/argp/argp-fmtstream.h b/eglibc/argp/argp-fmtstream.h
index f94207a..67d1ea2 100644
--- a/eglibc/argp/argp-fmtstream.h
+++ b/eglibc/argp/argp-fmtstream.h
@@ -203,7 +203,7 @@ extern int __argp_fmtstream_ensure (argp_fmtstream_t __fs, size_t __amount);
 #endif
 
 #ifndef ARGP_FS_EI
-#define ARGP_FS_EI extern inline
+#define ARGP_FS_EI extern inline __attribute__ ((always_inline))
 #endif
 
 ARGP_FS_EI size_t
-- 
1.7.9.5


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2012-04-07 18:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-12 15:44 [ptxdist] localedef: Build fixes for Darwin Bernhard Walle
2012-02-12 15:56 ` [ptxdist] [PATCH 1/3] Darwin: Define __nonnull when it's not defined Bernhard Walle
2012-02-12 15:56   ` [ptxdist] [PATCH 2/3] Re-generate configure Bernhard Walle
2012-02-12 15:56   ` [ptxdist] [PATCH 3/3] Fix build without gettext Bernhard Walle
2012-03-24 12:15 ` [ptxdist] localedef: Build fixes for Darwin Michael Olbrich
2012-04-07 18:30   ` Bernhard Walle
2012-04-07 18:32     ` Bernhard Walle [this message]
2012-04-08  8:10     ` Michael Olbrich
2012-04-08 14:32       ` [ptxdist] [PATCH] host-localedef: Fix build with LLVM GCC Bernhard Walle
2012-04-17  9:17         ` Michael Olbrich
2012-04-08 14:42       ` [ptxdist] localedef: Build fixes for Darwin Bernhard Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1333823545-62787-1-git-send-email-bernhard@bwalle.de \
    --to=bernhard@bwalle.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox