mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Remy Bohmer <linux@bohmer.net>
To: ptxdist@pengutronix.de, Michael Olbrich <m.olbrich@pengutronix.de>
Subject: [ptxdist] [PATCH 2/6 v5] [x86_64, multilib] Remove hardcoded paths from glibc.make
Date: Wed, 28 Mar 2012 21:05:01 +0200	[thread overview]
Message-ID: <1332961505-16641-2-git-send-email-linux@bohmer.net> (raw)
In-Reply-To: <1332961505-16641-1-git-send-email-linux@bohmer.net>

These hardcoded paths do not work for a multilib environment where
libraries are typically installed in /lib64 for x86-64 instead of /lib
All correct paths can be found by interrogating the compiler toolchain
for the location of these files.

Signed-off-by: Remy Bohmer <linux@bohmer.net>
---
 v5:
   - dropped changes to installation of /bin/locale{,def}. Notice that
     this still works on x86_64 and multilib, since binaries are always
     installed in /bin,/usr/bin only libraries can be installed in
     different locations on multilib (/lib,/usr/lib,/lib64,/usr/lib64).
     So, I will not create a new patch to remove the /bin/locale hardcoded
     paths.
   - reverted changes to rules/post/install.make, notice that there is now
     an empty argument before the 'no-stripping' 'n'

 rules/glibc.make                  |   19 +++++++++----------
 scripts/install_copy_toolchain.sh |    2 +-
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/rules/glibc.make b/rules/glibc.make
index 2de7a13..d2c5519 100644
--- a/rules/glibc.make
+++ b/rules/glibc.make
@@ -104,25 +104,24 @@ ifdef PTXCONF_GLIBC_NSL
 endif
 
 ifdef PTXCONF_GLIBC_GCONF_BASE
-	@$(call install_copy, glibc, 0, 0, 0755, /usr/lib/gconv)
-	@$(call install_copy_toolchain_lib, glibc, gconv/gconv-modules, /usr/lib/gconv, n)
+	@$(call install_copy_toolchain_lib, glibc, gconv/gconv-modules,, n)
 endif
 
 ifdef PTXCONF_GLIBC_GCONV_DEF
-	@$(call install_copy_toolchain_lib, glibc, gconv/ISO8859-1.so, /usr/lib/gconv)
-	@$(call install_copy_toolchain_lib, glibc, gconv/ISO8859-15.so, /usr/lib/gconv)
+	@$(call install_copy_toolchain_lib, glibc, gconv/ISO8859-1.so)
+	@$(call install_copy_toolchain_lib, glibc, gconv/ISO8859-15.so)
 endif
 
 ifdef PTXCONF_GLIBC_GCONV_UTF
-	@$(call install_copy_toolchain_lib, glibc, gconv/UNICODE.so, /usr/lib/gconv)
-	@$(call install_copy_toolchain_lib, glibc, gconv/UTF-16.so, /usr/lib/gconv)
-	@$(call install_copy_toolchain_lib, glibc, gconv/UTF-32.so, /usr/lib/gconv)
-	@$(call install_copy_toolchain_lib, glibc, gconv/UTF-7.so, /usr/lib/gconv)
+	@$(call install_copy_toolchain_lib, glibc, gconv/UNICODE.so)
+	@$(call install_copy_toolchain_lib, glibc, gconv/UTF-16.so)
+	@$(call install_copy_toolchain_lib, glibc, gconv/UTF-32.so)
+	@$(call install_copy_toolchain_lib, glibc, gconv/UTF-7.so)
 endif
 
 ifdef PTXCONF_GLIBC_GCONV_ZH
-	@$(call install_copy_toolchain_lib, glibc, gconv/GBBIG5.so, /usr/lib/gconv)
-	@$(call install_copy_toolchain_lib, glibc, gconv/GB18030.so, /usr/lib/gconv)
+	@$(call install_copy_toolchain_lib, glibc, gconv/GBBIG5.so)
+	@$(call install_copy_toolchain_lib, glibc, gconv/GB18030.so)
 endif
 
 ifdef PTXCONF_GLIBC_I18N_BIN_LOCALE
diff --git a/scripts/install_copy_toolchain.sh b/scripts/install_copy_toolchain.sh
index 7b91fc4..0f21fce 100755
--- a/scripts/install_copy_toolchain.sh
+++ b/scripts/install_copy_toolchain.sh
@@ -101,7 +101,7 @@ ptxd_split_lib_prefix_sysroot_eval() {
     lib_dir="${lib_path%/${lib}}"		# abs path to that lib
 
     # try to identify sysroot part of that path
-    for prefix in {/usr,}/lib{64,32,}{/tls,} ""; do
+    for prefix in {/usr,}/lib{64,32,}{/tls,/gconv,} ""; do
 	tmp="${lib_dir%${prefix}}"
 	if test "${lib_dir}" != "${tmp}"; then
 	    break
-- 
1.7.5.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2012-03-28 19:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 19:05 [ptxdist] [PATCH 1/6 v5] [x86_64, multilib] libgcc need to be install in /lib64 instead of /lib Remy Bohmer
2012-03-28 19:05 ` Remy Bohmer [this message]
2012-03-28 19:05 ` [ptxdist] [PATCH 3/6 v5] [x86_64, multilib] Make packages install their libraries at the right place Remy Bohmer
2012-03-28 19:05 ` [ptxdist] [PATCH 4/6 v5] [x86_64, multilib] Install Zlib " Remy Bohmer
2012-03-28 19:05 ` [ptxdist] [PATCH 5/6 v5] [x86_64, multilib] Install Ncurses " Remy Bohmer
2012-03-28 19:05 ` [ptxdist] [PATCH 6/6 v5] [x86_64, multilib] Install Procps " Remy Bohmer
2012-04-04  6:21 ` [ptxdist] [PATCH 1/6 v5] [x86_64, multilib] libgcc need to be install in /lib64 instead of /lib Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332961505-16641-2-git-send-email-linux@bohmer.net \
    --to=linux@bohmer.net \
    --cc=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox