mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] Fix ptxdist -q kernelconfig without extracted kernel
Date: Tue, 20 Mar 2012 21:18:46 +0100	[thread overview]
Message-ID: <1332274726-16487-1-git-send-email-bernhard@bwalle.de> (raw)

Normally if the kernel is not extracted when "ptxdist kernelconfig" is
called, ptxdist extracts the kernel first. However, when used in quiet
mode, that fails with an error like

------------------------------------------------------------------------
bash: -c: line 0: syntax error near unexpected token `;'
bash: -c: line 0: `target="/Users/bwalle/devel/ptxdist-arm-boards/platform-beagle/state/kernel.get"; \
        target="${target##*/}"; dep="/Volumes/Daten/src/linux-3.3.tar.bz2"; dep="${dep##*/}"; \
        echo "${target} : ${dep}" >> /Users/bwalle/devel/ptxdist-arm-boards/platform-beagle/state/depend.out; \
        echo "started : ${target}" >&; target="target: ${target##*/}"; \
        echo -e "\n${target//?/-}\n${target}\n${target//?/-}\n"; 'o
------------------------------------------------------------------------

The problem is also there when calling "ptxdist kernelconfig" from "ptxdist menu".
This patch attempts to fix the problem.

Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
---
 rules/post/function-targetinfo.make |    3 +++
 rules/post/function-touch.make      |    3 +++
 2 files changed, 6 insertions(+)

diff --git a/rules/post/function-targetinfo.make b/rules/post/function-targetinfo.make
index f8bcebe..40e119a 100644
--- a/rules/post/function-targetinfo.make
+++ b/rules/post/function-targetinfo.make
@@ -15,6 +15,9 @@
 # Print out the targetinfo line on the terminal
 #
 ifdef PTXDIST_QUIET
+ifndef PTXDIST_FD_STDOUT
+PTXDIST_FD_STDOUT := 1
+endif
 _targetinfo_opt_output := echo "started : $(PTX_COLOR_BLUE)$${target}$(PTX_COLOR_OFF)" >&$(PTXDIST_FD_STDOUT);
 endif
 
diff --git a/rules/post/function-touch.make b/rules/post/function-touch.make
index 0a7919e..4d8fc28 100644
--- a/rules/post/function-touch.make
+++ b/rules/post/function-touch.make
@@ -13,6 +13,9 @@
 # touch
 #
 ifdef PTXDIST_QUIET
+ifndef PTXDIST_FD_STDOUT
+PTXDIST_FD_STDOUT := 1
+endif
 _touch_opt_output := echo "finished: $(PTX_COLOR_GREEN)$${target}$(PTX_COLOR_OFF)" >&$(PTXDIST_FD_STDOUT);
 endif
 
-- 
1.7.9.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2012-03-20 20:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 20:18 Bernhard Walle [this message]
2012-03-23  8:00 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332274726-16487-1-git-send-email-bernhard@bwalle.de \
    --to=bernhard@bwalle.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox