mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Remy Bohmer <linux@bohmer.net>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 3/5 v4] [busybox] Pass extra platform CFLAGS to busybox make
Date: Wed, 14 Mar 2012 14:38:18 +0100	[thread overview]
Message-ID: <1331732298-18641-1-git-send-email-linux@bohmer.net> (raw)

Busybox make is not properly called in case:
* compiler name tuple does not match target tuple (as used in multilib
 compilers, for example: i686-pc-linux-gnu-gcc can compile for
 x86_64-unknown-linux-gnu targets. To solve this the 'SUBARCH' need to be
 set)
* CONFIG_EXTRA_CFLAGS need to e set to select the proper sysroot to
 compile against in busybox
* LDFLAGS to link against the proper sysroot.

Signed-off-by: Remy Bohmer <linux@bohmer.net>
---
 v2: Reworked review comments from Michael Olbrich
 v3: Convert spaces->tabs + Added '\' after CFLAGS line
     checked after build if build-target/busybox/busybox remains unstripped.
 v4: My authors email-address was wrong

 rules/busybox.make |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/rules/busybox.make b/rules/busybox.make
index 536aa80..54b5367 100644
--- a/rules/busybox.make
+++ b/rules/busybox.make
@@ -49,14 +49,17 @@ $(STATEDIR)/busybox.prepare:
 
 BUSYBOX_MAKE_OPT := \
 	ARCH=$(PTXCONF_ARCH_STRING) \
+	SUBARCH=$(PTXCONF_ARCH_STRING) \
 	CROSS_COMPILE=$(COMPILER_PREFIX) \
-	CONFIG_EXTRA_CFLAGS="$(CROSS_CFLAGS)" \
-	HOSTCC=$(HOSTCC) \
+	HOSTCC=$(HOSTCC)
+
+BUSYBOX_MAKE_ENV := \
+	$(CROSS_ENV) \
+	CFLAGS="$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR)" \
 	SKIP_STRIP=y
 
-ifdef PTXCONF_BUSYBOX_RFKILL
-BUSYBOX_MAKE_OPT += CFLAGS="-I$(KERNEL_HEADERS_INCLUDE_DIR)"
-endif
+BUSYBOX_INSTAL_ENV := \
+	$(BUSYBOX_MAKE_ENV)
 
 BUSYBOX_INSTALL_OPT := \
 	$(BUSYBOX_MAKE_OPT) \
-- 
1.7.0.4



-- 
ptxdist mailing list
ptxdist@pengutronix.de

             reply	other threads:[~2012-03-14 13:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 13:38 Remy Bohmer [this message]
2012-03-14 13:46 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331732298-18641-1-git-send-email-linux@bohmer.net \
    --to=linux@bohmer.net \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox