mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Remy Bohmer <linux@bohmer.net>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH 3/5 v2] [busybox] Pass extra platform CFLAGS to busybox make
Date: Tue, 13 Mar 2012 22:32:16 +0100	[thread overview]
Message-ID: <1331674338-1757-3-git-send-email-linux@bohmer.net> (raw)
In-Reply-To: <1331674338-1757-1-git-send-email-linux@bohmer.net>

Busybox make is not properly called in case:
* compiler name tuple does not match target tuple (as used in multilib
 compilers, for example: i686-pc-linux-gnu-gcc can compile for
 x86_64-unknown-linux-gnu targets. To solve this the 'SUBARCH' need to be
 set)
* CONFIG_EXTRA_CFLAGS need to e set to select the proper sysroot to
 compile against in busybox
* LDFLAGS to link against the proper sysroot.

Signed-off-by: Remy Bohmer <linux@bohmer.net>
---
 v2: Reworked review comments from Michael Olbrich

 rules/busybox.make |   21 ++++++++++++---------
 1 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/rules/busybox.make b/rules/busybox.make
index 536aa80..45fd20f 100644
--- a/rules/busybox.make
+++ b/rules/busybox.make
@@ -48,15 +48,18 @@ $(STATEDIR)/busybox.prepare:
 	@$(call touch)
 
 BUSYBOX_MAKE_OPT := \
-	ARCH=$(PTXCONF_ARCH_STRING) \
-	CROSS_COMPILE=$(COMPILER_PREFIX) \
-	CONFIG_EXTRA_CFLAGS="$(CROSS_CFLAGS)" \
-	HOSTCC=$(HOSTCC) \
-	SKIP_STRIP=y
-
-ifdef PTXCONF_BUSYBOX_RFKILL
-BUSYBOX_MAKE_OPT += CFLAGS="-I$(KERNEL_HEADERS_INCLUDE_DIR)"
-endif
+       ARCH=$(PTXCONF_ARCH_STRING) \
+       SUBARCH=$(PTXCONF_ARCH_STRING) \
+       CROSS_COMPILE=$(COMPILER_PREFIX) \
+       HOSTCC=$(HOSTCC)
+
+BUSYBOX_MAKE_ENV := \
+       $(CROSS_ENV) \
+       CFLAGS="$(CROSS_CFLAGS) -I$(KERNEL_HEADERS_INCLUDE_DIR)"
+       SKIP_STRIP=y
+
+BUSYBOX_INSTAL_ENV := \
+       $(BUSYBOX_MAKE_ENV)
 
 BUSYBOX_INSTALL_OPT := \
 	$(BUSYBOX_MAKE_OPT) \
-- 
1.7.5.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

  parent reply	other threads:[~2012-03-13 21:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 21:32 [ptxdist] [PATCH 1/5 v2] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Remy Bohmer
2012-03-13 21:32 ` [ptxdist] [PATCH 2/5 v2] [x86_64] Add some support for multilib detection in the toolchain Remy Bohmer
2012-03-13 21:32 ` Remy Bohmer [this message]
2012-03-14 10:42   ` [ptxdist] [PATCH 3/5 v2] [busybox] Pass extra platform CFLAGS to busybox make Michael Olbrich
2012-03-14 10:45     ` Michael Olbrich
2012-03-14 11:38       ` Remy Bohmer
2012-03-13 21:32 ` [ptxdist] [PATCH 4/5 v2] [x86_64, glibc] on multilib do not put all dynamic linkers in /lib Remy Bohmer
2012-03-13 21:32 ` [ptxdist] [PATCH 5/5 v2] [x86_64, glibc] Link /usr/lib/libdl.so is not needed and wrong on x86_64 Remy Bohmer
2012-03-15 10:31 ` [ptxdist] [PATCH 1/5 v2] [rt-tests] Use CFLAGS specified by ptxdist platformconfig Michael Olbrich
2012-03-15 11:52   ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331674338-1757-3-git-send-email-linux@bohmer.net \
    --to=linux@bohmer.net \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox