From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay04.ispgateway.de ([80.67.29.8]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1RraEN-0001Vk-L4 for ptxdist@pengutronix.de; Sun, 29 Jan 2012 20:16:04 +0100 Received: from [88.217.120.83] (helo=localhost.localdomain) by smtprelay04.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1RraEG-00084H-Ma for ptxdist@pengutronix.de; Sun, 29 Jan 2012 20:15:56 +0100 From: Bernhard Walle Date: Sun, 29 Jan 2012 20:15:49 +0100 Message-Id: <1327864549-90478-1-git-send-email-bernhard@bwalle.de> Subject: [ptxdist] [PATCH] make 3.82: Don't rely on sorted wildcard expansion Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Since I switched to make 3.82 on my Mac (from MacPorts), "ptxdist images" didn't produce any images. I compared the output of make --debug=all with a working one (from make 3.81 that comes from Apple) and one difference was the order in reading includes Makefiles. With make 3.82, the wildcard command doesn't sort any more. See https://bugzilla.redhat.com/show_bug.cgi?id=635607. This small fix fixed the issue for me. Don't ask my why this doesn't show up on Linux. Maybe the return values of some library function that is make using internally is already sorted. I have no clue. Signed-off-by: Bernhard Walle --- rules/other/Toplevel.make | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/rules/other/Toplevel.make b/rules/other/Toplevel.make index 35c2c27..0cb7e82 100644 --- a/rules/other/Toplevel.make +++ b/rules/other/Toplevel.make @@ -95,7 +95,7 @@ PTX_PACKAGES_INSTALL := \ $(PACKAGES-b) # might be non existent -include $(wildcard $(addsuffix /*.make,$(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES))))) +include $(sort $(wildcard $(addsuffix /*.make,$(call reverse,$(subst :,$(space),$(PTXDIST_PATH_POSTRULES)))))) # install_alternative and install_copy has some configuration defined # dependencies. include the files specifying these dependencies. include $(wildcard $(STATEDIR)/*.deps) -- 1.7.7.4 -- ptxdist mailing list ptxdist@pengutronix.de