From: "Andreas Bießmann" <andreas@biessmann.de>
To: PTXdist ML <ptxdist@pengutronix.de>
Cc: "Andreas Bießmann" <andreas@biessmann.de>
Subject: [ptxdist] [PATCH] setlocalversion: use /bin/bash explicitly
Date: Wed, 14 Dec 2011 00:06:59 +0100 [thread overview]
Message-ID: <1323817619-69036-1-git-send-email-andreas@biessmann.de> (raw)
Using /bin/sh in setlocalversion lead to corrupted $PTXDIST_VERSION_FULL
cause the 'echo -n "$v"' will use the builtin echo which does not know
about -n switch.
Before this patch my version looks like this:
---8<---
$ ptxdist --version
-n 2011.12.0-00047-g9849e20
--->8---
Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
scripts/kernel/setlocalversion | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/kernel/setlocalversion b/scripts/kernel/setlocalversion
index 3e14135..bf467ea 100755
--- a/scripts/kernel/setlocalversion
+++ b/scripts/kernel/setlocalversion
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
#
# This scripts adds local version information from the version
# control systems git, mercurial (hg) and subversion (svn).
--
1.7.8
--
ptxdist mailing list
ptxdist@pengutronix.de
next reply other threads:[~2011-12-13 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 23:06 Andreas Bießmann [this message]
2011-12-14 10:51 ` Michael Olbrich
2011-12-14 11:08 ` Marc Kleine-Budde
2011-12-14 11:20 ` Michael Olbrich
2011-12-16 18:18 ` [ptxdist] [PATCH v2] setlocalversion: replace echo -n with printf Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323817619-69036-1-git-send-email-andreas@biessmann.de \
--to=andreas@biessmann.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox