mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Christian Melki <christian.melki@t2data.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/2] chrony: version bump 3.5 -> 4.1
Date: Fri, 12 Nov 2021 10:53:21 +0100	[thread overview]
Message-ID: <0938dbe2-021a-8166-3f5f-3e967be4a6ae@t2data.com> (raw)
In-Reply-To: <YY4vyn/4RonEPoZM@pengutronix.de>



On 11/12/21 10:11 AM, Michael Olbrich wrote:
> On Fri, Nov 05, 2021 at 09:17:54PM +0100, Christian Melki wrote:
>> Bump.
>>
>> Still hasn't made it to 2021.11?
>> Chrony 3.5 has the following CVE hanging over it:
>> * Create new file when writing pidfile (CVE-2020-14367)
>>
>> Admittedly, not an overly interesting one, but still.
> 
> Right. There was some feedback but a v2 was never sent. Thank you for
> picking this up.
> 
> Michael
> 

I made a version bump only patch if that was easier to accept.
But drop that if you're ready to accept the work Uwe did.

Regards,
Christian

>> On 7/7/21 18:42, Uwe Kleine-König wrote:
>>> On Wed, Jul 07, 2021 at 04:52:23PM +0200, Bruno Thomsen wrote:
>>>> Den ons. 7. jul. 2021 kl. 16.31 skrev Michael Olbrich
>>>> <m.olbrich@pengutronix.de>:
>>>>>
>>>>> On Mon, Jul 05, 2021 at 09:49:25AM +0200, Uwe Kleine-König wrote:
>>>>>> ---
>>>>>>   ...ke-unrecognized-option-a-fatal-error.patch | 25 -----------------
>>>>>>   patches/chrony-3.5/series                     |  4 ---
>>>>>>   ...t-install-docs-to-not-need-additiona.patch | 21 +++++++++++++++
>>>>>>   ...vice-Make-this-a-non-forking-service.patch | 27 +++++++++++++++++++
>>>>>>   patches/chrony-4.1/series                     |  5 ++++
>>>>>>   rules/chrony.make                             |  4 +--
>>>>>>   6 files changed, 55 insertions(+), 31 deletions(-)
>>>>>>   delete mode 100644 patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
>>>>>>   delete mode 100644 patches/chrony-3.5/series
>>>>>>   create mode 100644 patches/chrony-4.1/0001-Makefile.in-Don-t-install-docs-to-not-need-additiona.patch
>>>>>>   create mode 100644 patches/chrony-4.1/0002-chronyd.service-Make-this-a-non-forking-service.patch
>>>>>>   create mode 100644 patches/chrony-4.1/series
>>>>>>
>>>>>> diff --git a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
>>>>>> deleted file mode 100644
>>>>>> index 01f2136338b9..000000000000
>>>>>> --- a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
>>>>>> +++ /dev/null
>>>>>> @@ -1,25 +0,0 @@
>>>>>> -From: Bruno Thomsen <bruno.thomsen@gmail.com>
>>>>>> -Date: Fri, 31 Jul 2020 09:07:49 +0000
>>>>>> -Subject: [PATCH] configure: make unrecognized option a fatal error
>>>>>> -
>>>>>> -This helps catch cases where options has been removed
>>>>>> -and are no longer valid. Including additional cross-build
>>>>>> -options that cannot be used.
>>>>>> -
>>>>>> -Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
>>>>
>>>> Hi,
>>>>
>>>> This patch was added last year to ptxdist, so it's possible to detect
>>>> unrecognized options in new chrony versions as they use a custom
>>>> hand crafted configure script. So unless that situation has changed
>>>> this patch should be kept.
>>>
>>> I dropped it because it is only important when you do a version bump. As
>>> you usually go through all of the configure flags anyhow I didn't
>>> consider it useful enough to keep it.
>>>
>>> However I don't feel strong here, so if you do, I can keep it.
>>>
>>> Best regards
>>> Uwe
>>>
>>>
>>> _______________________________________________
>>> ptxdist mailing list
>>> ptxdist@pengutronix.de
>>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>>>
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-11-12  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05  7:49 [ptxdist] [PATCH 1/2] chrony: unify location of config files Uwe Kleine-König
2021-07-05  7:49 ` [ptxdist] [PATCH 2/2] chrony: version bump 3.5 -> 4.1 Uwe Kleine-König
2021-07-07 14:31   ` Michael Olbrich
2021-07-07 14:52     ` Bruno Thomsen
2021-07-07 16:42       ` Uwe Kleine-König
2021-11-05 20:17         ` Christian Melki
2021-11-12  9:11           ` Michael Olbrich
2021-11-12  9:53             ` Christian Melki [this message]
2021-07-07 14:15 ` [ptxdist] [PATCH 1/2] chrony: unify location of config files Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0938dbe2-021a-8166-3f5f-3e967be4a6ae@t2data.com \
    --to=christian.melki@t2data.com \
    --cc=ptxdist@pengutronix.de \
    --subject='Re: [ptxdist] [PATCH 2/2] chrony: version bump 3.5 -> 4.1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox