From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: References: <20181126102301.31216-1-t.scherer@eckelmann.de> <2cd9be64-4a60-8779-53af-987bbd8ea148@pengutronix.de> <20181203084046.kkhxugkdetb2tl3b@pengutronix.de> From: Marc Kleine-Budde Message-ID: <0618ee76-8e0f-5aae-1e6f-31d651eb3bc5@pengutronix.de> Date: Mon, 10 Dec 2018 13:45:07 +0100 MIME-Version: 1.0 In-Reply-To: <20181203084046.kkhxugkdetb2tl3b@pengutronix.de> Subject: Re: [ptxdist] [PATCH 2/5] ptxdist: add tpm2-tss version 2.1.0 List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============0208019258==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: "Thorsten K. Scherer" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0208019258== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AlTqnNRl8k4IHKWPnj5NMJFxTrS4bDMCr" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AlTqnNRl8k4IHKWPnj5NMJFxTrS4bDMCr Content-Type: multipart/mixed; boundary="YYwiC67C8xZawf9EUEyU4ia35V8Su1IPV"; protected-headers="v1" From: Marc Kleine-Budde To: ptxdist@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: "Thorsten K. Scherer" Message-ID: <0618ee76-8e0f-5aae-1e6f-31d651eb3bc5@pengutronix.de> Subject: Re: [ptxdist] [PATCH 2/5] ptxdist: add tpm2-tss version 2.1.0 References: <20181126102301.31216-1-t.scherer@eckelmann.de> <2cd9be64-4a60-8779-53af-987bbd8ea148@pengutronix.de> <20181203084046.kkhxugkdetb2tl3b@pengutronix.de> In-Reply-To: <20181203084046.kkhxugkdetb2tl3b@pengutronix.de> --YYwiC67C8xZawf9EUEyU4ia35V8Su1IPV Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable On 12/3/18 9:40 AM, Uwe Kleine-K=C3=B6nig wrote: > Hello Marc, >=20 > On Wed, Nov 28, 2018 at 09:02:10AM +0100, Marc Kleine-Budde wrote: >> On 11/26/18 11:23 AM, Thorsten K. Scherer wrote: >>> Signed-off-by: Thorsten K. Scherer >>> --- >>> ...rom-the-list-of-libs-to-link-against.patch | 21 ++++++ >>> patches/tpm2-tss-2.1.0/series | 4 ++ >>> rules/tpm.in | 5 ++ >>> rules/tpm2-tss.in | 22 +++++++ >>> rules/tpm2-tss.make | 66 +++++++++++++++++= ++ >>> 5 files changed, 118 insertions(+) >>> create mode 100644 patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the= -list-of-libs-to-link-against.patch >>> create mode 100644 patches/tpm2-tss-2.1.0/series >>> create mode 100644 rules/tpm.in >>> create mode 100644 rules/tpm2-tss.in >>> create mode 100644 rules/tpm2-tss.make >>> >>> diff --git a/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-o= f-libs-to-link-against.patch b/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-f= rom-the-list-of-libs-to-link-against.patch >>> new file mode 100644 >>> index 0000000..0230570 >>> --- /dev/null >>> +++ b/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-= to-link-against.patch >>> @@ -0,0 +1,21 @@ >>> +From: =3D?UTF-8?q?Uwe=3D20Kleine-K=3DC3=3DB6nig?=3D >>> +Date: Fri, 12 Oct 2018 11:13:42 +0200 >>> +Subject: [PATCH] drop -lgcrypt from the list of libs to link against= >>> + >>> +If --with-crypto=3Dossl is used -lgcrypt is wrong. There shouldn't b= e any need >>> +to explicitly tell the linker because the library already depends th= e chosen >>> +crypto lib >> >> S-o-b missing >=20 > I'm unsure why you think a S-o-b is necessary here. The upstream projec= t > requires a S-o-b by the submitter (who is not necessarily the patch > author) only when the patch is sent to them for application. And in my > eyes the S-o-b on the ptxdist-patch already covers that the whole > content (so including the added patch file) is compatible with ptxdist'= s > license. >=20 > Can you clearify? AFAIK We want to have S-o-bs on all patches in ptxdist. I you don't think this is necessary go ahead as you like. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --YYwiC67C8xZawf9EUEyU4ia35V8Su1IPV-- --AlTqnNRl8k4IHKWPnj5NMJFxTrS4bDMCr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEENrCndlB/VnAEWuH5k9IU1zQoZfEFAlwOX9MACgkQk9IU1zQo ZfFgvggAh/9C5nXMN623V9tCT9Ja1gnnlLRqrbQ8M1XMVmaLYOHLQpeTYlpJ+dSn WnsziLpY98+CV8cMKbsECm8S4EGAUd14M0JWXNYfcQgbE4pNW34405B93zEZA8k4 Y+Ti7pBpM3BKBSwyiYBN4FVqQgvAaywSrqT04OpHhwgg04FPNcN2I1wdeYsSaqvk 5EsLfoFY1C8lOBQXHGxJk65zMpdOnEixhHfYrpjyeikgJtO4SRkdPvTWKrpx8kdV lQEQwP1Tv18kcU8z6c3Fg3CYcdRt4WBmfN1OQ+kJmWhcUdS+025EpXZuIJEUb2n2 8CdmTfI5SG01sxwzN+iE08gmcHbXeQ== =V64f -----END PGP SIGNATURE----- --AlTqnNRl8k4IHKWPnj5NMJFxTrS4bDMCr-- --===============0208019258== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KcHR4ZGlzdCBt YWlsaW5nIGxpc3QKcHR4ZGlzdEBwZW5ndXRyb25peC5kZQ== --===============0208019258==--