On 12/3/18 9:40 AM, Uwe Kleine-König wrote: > Hello Marc, > > On Wed, Nov 28, 2018 at 09:02:10AM +0100, Marc Kleine-Budde wrote: >> On 11/26/18 11:23 AM, Thorsten K. Scherer wrote: >>> Signed-off-by: Thorsten K. Scherer >>> --- >>> ...rom-the-list-of-libs-to-link-against.patch | 21 ++++++ >>> patches/tpm2-tss-2.1.0/series | 4 ++ >>> rules/tpm.in | 5 ++ >>> rules/tpm2-tss.in | 22 +++++++ >>> rules/tpm2-tss.make | 66 +++++++++++++++++++ >>> 5 files changed, 118 insertions(+) >>> create mode 100644 patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch >>> create mode 100644 patches/tpm2-tss-2.1.0/series >>> create mode 100644 rules/tpm.in >>> create mode 100644 rules/tpm2-tss.in >>> create mode 100644 rules/tpm2-tss.make >>> >>> diff --git a/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch b/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch >>> new file mode 100644 >>> index 0000000..0230570 >>> --- /dev/null >>> +++ b/patches/tpm2-tss-2.1.0/0001-drop-lgcrypt-from-the-list-of-libs-to-link-against.patch >>> @@ -0,0 +1,21 @@ >>> +From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= >>> +Date: Fri, 12 Oct 2018 11:13:42 +0200 >>> +Subject: [PATCH] drop -lgcrypt from the list of libs to link against >>> + >>> +If --with-crypto=ossl is used -lgcrypt is wrong. There shouldn't be any need >>> +to explicitly tell the linker because the library already depends the chosen >>> +crypto lib >> >> S-o-b missing > > I'm unsure why you think a S-o-b is necessary here. The upstream project > requires a S-o-b by the submitter (who is not necessarily the patch > author) only when the patch is sent to them for application. And in my > eyes the S-o-b on the ptxdist-patch already covers that the whole > content (so including the added patch file) is compatible with ptxdist's > license. > > Can you clearify? AFAIK We want to have S-o-bs on all patches in ptxdist. I you don't think this is necessary go ahead as you like. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |