Re: [ptxdist] [PATCH 1/2] net-snmp: drop usage of undefined Kconfig variables

[Alexander Dahl <post@lespocky.de>]

Hei hei, 

Am 2013-09-10 21:25, schrieb Uwe Kleine-König:
> You seem to assume this was configurable before but that is wrong. There
> was something like
> 
> 	if PTXCONF_...
> 		--enable-reentrant
> 	else
> 		--disable-reentrant
> 	endif
> 
> but the variable in the if condition wasn't defined. So it didn't look
> like being hardcoded to --disable-reentrant but effectively it was.

Yes, I saw this. Maybe it was some time before and someone removed it
from net-snmp.in but I didn't prove this in git history.

> So this patch is noop and if you see a problem with the options I
> hardcode now then the problem was already there before because you
> couldn't change the respective variable without adding it first to
> net-snmp.in.

Right, I already understood what you did, so if this is not the place
for this discussion I will make a new patch changing these options.

Is anyone else actually using net-snmp? This would be helpful for
discussion. ;-)

> No, I just dropped all ifs depending on non-existant Kconfig vars.

Which is useful.

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de