From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-vi1eur05on2077.outbound.protection.outlook.com ([40.107.21.77] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7fmS-00026x-OZ for ptxdist@pengutronix.de; Mon, 17 Aug 2020 16:06:34 +0200 Received: from nbmx01.hytera.de (unknown [172.21.102.22]) by ibmx32.hytera.de (Postfix) with ESMTP id 7E161AD8F for ; Mon, 17 Aug 2020 16:06:23 +0200 (CEST) References: <20191210100856.11655-1-christian.hermann@hytera.de> <2400094.He79FygHFi@ada> From: Christian Hermann Message-ID: <03d6c320-ba0b-1ea3-78f5-f41a2fdc13fe@hytera.de> Date: Mon, 17 Aug 2020 16:06:25 +0200 MIME-Version: 1.0 In-Reply-To: <2400094.He79FygHFi@ada> Subject: Re: [ptxdist] [PATCH] haveged: version bump 1.9.2 -> 1.9.8 List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1779443980==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1779443980== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="utNxJkBgRyN6C8Jy7jCdpjxeCvzUtAG4Z" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --utNxJkBgRyN6C8Jy7jCdpjxeCvzUtAG4Z Content-Type: multipart/mixed; boundary="TM5NCk1DP9og87nthpVfiYXfehGYexFE3"; protected-headers="v1" From: Christian Hermann To: ptxdist@pengutronix.de Message-ID: <03d6c320-ba0b-1ea3-78f5-f41a2fdc13fe@hytera.de> Subject: Re: [ptxdist] [PATCH] haveged: version bump 1.9.2 -> 1.9.8 References: <20191210100856.11655-1-christian.hermann@hytera.de> <2400094.He79FygHFi@ada> In-Reply-To: <2400094.He79FygHFi@ada> --TM5NCk1DP9og87nthpVfiYXfehGYexFE3 Content-Type: multipart/mixed; boundary="------------DDB280981E12D39FC23FD973" Content-Language: en-US This is a multi-part message in MIME format. --------------DDB280981E12D39FC23FD973 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, quoting upstream (https://raw.githubusercontent.com/jirka-h/haveged/7ae444b7a0aa64a96729d7= 8dd724b4398b9b0eaa/README.md) ``` The --enable-threads option is an experimental prototype for running multiple collection threads in a single haveged instance. The goal is to create a multi-core haveged that would spread collection overhead more evenly over the available cpu resources. ``` I assume you read it as well and and I agree this option should be disabled by default due to its experimental character (or at best made configurable). Regards On 13.08.20 13:55, Alexander Dahl wrote: > Hei hei, >=20 > sorry for digging in mails from last year, I just stumbled over this wh= en=20 > migrating a BSP to a newer version =E2=80=A6 >=20 > Am Dienstag, 10. Dezember 2019, 11:08:56 CEST schrieb Christian Hermann= : >> * upstream provides new tarballs only on github >> * pull upstream patch to enable threads >=20 > What's the benefit of having threads enabled for haveged? I saw two thr= eads=20 > running on a single core ARM SoC. Sounds quite heavy for me for such a = simple=20 > task haveged is supposed to do? >=20 > Greets > Alex >=20 >> * fix license identifier >> >> Signed-off-by: Christian Hermann >> --- >> ...-fix-compilation-with-enable-threads.patch | 33 ++++++++++++++++++= + >> patches/haveged-1.9.8/series | 1 + >> rules/haveged.make | 14 ++++---- >> 3 files changed, 42 insertions(+), 6 deletions(-) >> create mode 100644 >> patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-threads.= patch >> create mode 100644 patches/haveged-1.9.8/series >> >> diff --git >> a/patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-thread= s.pat >> ch >> b/patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-thread= s.pat >> ch new file mode 100644 >> index 000000000..38895a97c >> --- /dev/null >> +++ >> b/patches/haveged-1.9.8/0001-cb1f06-fix-compilation-with-enable-thread= s.pat >> ch @@ -0,0 +1,33 @@ >> +From cb1f0653c45d9c4a9a855119c85a1d4bfcc9b3b2 Mon Sep 17 00:00:00 200= 1 >> +From: Lars Wendler >> +Date: Thu, 14 Nov 2019 16:15:00 +0100 >> +Subject: [PATCH] build: Fix compilation with --enable-threads >> +MIME-Version: 1.0 >> +Content-Type: text/plain; charset=3DUTF-8 >> +Content-Transfer-Encoding: 8bit >> + >> +Previously failed with: >> + >> +havegetune.c:190:12: error: =E2=80=98BUILD_THREAD=E2=80=99 undeclared= (first use in this >> function); did you mean =E2=80=98BUILD_THREADS=E2=80=99? + 190 | *= bp++ =3D BUILD_THREAD; >> + | ^~~~~~~~~~~~ >> + | BUILD_THREADS >> + >> +Signed-off-by: Lars Wendler >> +--- >> + src/havegetune.c | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/src/havegetune.c b/src/havegetune.c >> +index de39c53..6f14476 100644 >> +--- a/src/havegetune.c >> ++++ b/src/havegetune.c >> +@@ -187,7 +187,7 @@ void havege_tune( /* RETURN: none = =20 >> */ + *bp++ =3D BUILD_CPUID; >> + #endif >> + #if NUMBER_CORES>1 >> +- *bp++ =3D BUILD_THREAD; >> ++ *bp++ =3D BUILD_THREADS; >> + #endif >> + #ifdef ONLINE_TESTS_ENABLE >> + *bp++ =3D BUILD_OLT; >> diff --git a/patches/haveged-1.9.8/series b/patches/haveged-1.9.8/seri= es >> new file mode 100644 >> index 000000000..cb49a0968 >> --- /dev/null >> +++ b/patches/haveged-1.9.8/series >> @@ -0,0 +1 @@ >> +0001-cb1f06-fix-compilation-with-enable-threads.patch >> diff --git a/rules/haveged.make b/rules/haveged.make >> index 80d1910f3..8f49ad49e 100644 >> --- a/rules/haveged.make >> +++ b/rules/haveged.make >> @@ -14,16 +14,18 @@ PACKAGES-$(PTXCONF_HAVEGED) +=3D haveged >> # >> # Paths and names >> # >> -HAVEGED_VERSION :=3D 1.9.2 >> -HAVEGED_MD5 :=3D fb1d8b3dcbb9d06b30eccd8aa500fd31 >> +HAVEGED_VERSION :=3D 1.9.8 >> +HAVEGED_MD5 :=3D fba3c88e416ad99ed69849b61fdcaad0 >> HAVEGED :=3D haveged-$(HAVEGED_VERSION) >> HAVEGED_SUFFIX :=3D tar.gz >> HAVEGED_URL :=3D \ >> - http://www.issihosts.com/haveged/$(HAVEGED).$(HAVEGED_SUFFIX) \ >> - http://www.issihosts.com/haveged/archive/$(HAVEGED).$(HAVEGED_SUFFIX= ) >> + https://github.com/jirka-h/haveged/archive/v$(HAVEGED_VERSION).tar.g= z >> HAVEGED_SOURCE :=3D $(SRCDIR)/$(HAVEGED).$(HAVEGED_SUFFIX) >> HAVEGED_DIR :=3D $(BUILDDIR)/$(HAVEGED) >> -HAVEGED_LICENSE :=3D GPL-3.0-only >> +HAVEGED_LICENSE :=3D GPL-3.0-or-later >> +HAVEGED_LICENSE_FILES :=3D \ >> + file://COPYING;md5=3Dd32239bcb673463ab874e80d47fae504 \ >> + file://src/haveged.c;startline=3D1;endline=3D19;md5=3D772ad7f0aa1fd2= 230cffdf7be7 >> 84b15f >> >> # >> ----------------------------------------------------------------------= ----- >> - # Prepare >> @@ -42,7 +44,7 @@ HAVEGED_CONF_OPT :=3D \ >> --enable-initdir=3D/usr/lib/systemd/system \ >> --disable-nistest \ >> --disable-olt \ >> - --disable-threads \ >> + --enable-threads \ >> --enable-tune >> >> # >> ----------------------------------------------------------------------= ----- >> - >=20 >=20 >=20 >=20 >=20 > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-reque= st@pengutronix.de >=20 --------------DDB280981E12D39FC23FD973 Content-Type: application/pgp-keys; name="0x3387FE18007EEC09.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0x3387FE18007EEC09.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- mQENBF7zc9EBCADByavxxEKQ5njxfLhAkTer41xh8oAuuxhhtM+uE0rOmRKc1cf5 OxjdqzFG13oBhDPpilWtizzNkgwxKzByoOxAnw6kxRl5wRj/3pjhkKQzsiBweTPL jYyXiImOVqbIHSGM/+dnkMtBurF5ZfPk9lJ2To/skHc2EZV7eC560SmkOnFt26ki g9o+YmaTsMIOmdPUrIuWNhveHtpNgl68WskbvP390Hh/XUtJ8fZbcOnKCrKvCvKZ c9KcrzE/hTdycIeLda6uaVF93qMPG3HuQaWDmYyBLjKirgU+cDV1mnd4wJbLcKXy iamrIsmvsZETS8rQ0nohhsDOl/mT1yyDn1CJABEBAAG0L0NocmlzdGlhbiBIZXJt YW5uIDxjaHJpc3RpYW4uaGVybWFubkBoeXRlcmEuZGU+iQFMBBMBCAA2FiEEnlg5 UwH1AIzXQlWBM4f+GAB+7AkFAl7zc9ECGwMECwkIAwQVCgkIBRYCAwEAAh4BAheA AAoJEDOH/hgAfuwJ5yUIALaZrfDYLdiZPq/wHTs1Ug7u0lz/qlksNlJE3NgYbNWK jN4AjQj+YK8XdCa/9CZ0fJ0Ij2m6kg5DRcvy/08mPeeNwHpjR2V39PFoD0u6oRxV lEyynWFVKvsUuIah95A4JKqrcuQxSee2NdXLxXArKESSPWyNUO0TN/NRvAXGgACb qMM2/e/osFnctye+DDoxhCNoc2EHDGQ0FQ+FGM5lG4A/6vEE1GjGD4OZxRbzHWos 2oYmmhaAytP9EEt4jLsSTgtYy34kotVQ4UFYHUeIwtv7OFYqd61x1sX9RNVPawB4 4jJdCVpxz8UbJSrMFFXTK1LQAdTCtoOQmE3FsaeqQN+5AQ0EXvNz0QEIAMMTfbJd z4mHxJbGnjg2N35vJfx9iAJ3LD7fj9dn4xND4C6grNOGMw+tNoEIfqxs39ysatL4 7xxnAweRr2rPnERdCVEDc4cQOuKiiEt1Pkzy0MS7OJqlcBV7mlBsBPifaeSfs3mK J0lEddovZ5TROtyre+MzMUnrLS8uP50IjJIs/8NulPDVl8MR3CA3e33i8l0n3HT0 XImoH3zHJmW0gjzWl8K/udiUqFlcpiTFAWgtG2CpcAiT0Tsg9yOHBYy20cTLDhUQ 5fb1qLMpIP0NEeTiy9Xpy117x96PYqSS4EoWRibQtxh3/5DbcCraYhu+vHUhlrJv sv0pXH4ATclNbK8AEQEAAYkBNgQYAQgAIBYhBJ5YOVMB9QCM10JVgTOH/hgAfuwJ BQJe83PRAhsMAAoJEDOH/hgAfuwJjxgH/23cgJoEKfdmA7ZE2K2eta108PJ9sGX9 3C8lRzp6XGQJoHlz0c5lJ6EUBYBVRBpSomVsueD+5qlwH5NEN7EYRk7c420UREGn xRU5kDsTUt4o627CW/CmwyhBUFVU0rWyQrJi/KWh2FvUnjxA9glWFhqmr2vs5cAo dwVy89iE0PBYU6j0fJYUSaJxJyw9LK3FStdf+NT3cjI83/58gH/opLoayX38epw5 QzIKW0xgPy7QK0mDal0l5m7w5NnbEhCnmE5lLeVC9DZ/eF21oCsuIO3WZKMPwvBz SiJpBsTYGGs1yvUekyUBi3rAOS68EpQVCmsSknD5gEDpiQRNFcGpyXw=3D =3DoX7s -----END PGP PUBLIC KEY BLOCK----- --------------DDB280981E12D39FC23FD973-- --TM5NCk1DP9og87nthpVfiYXfehGYexFE3-- --utNxJkBgRyN6C8Jy7jCdpjxeCvzUtAG4Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEnlg5UwH1AIzXQlWBM4f+GAB+7AkFAl86juEACgkQM4f+GAB+ 7AlRcQf/V6VmvU8TD2lPPAL7npmc7REMB6XMzuWZDl/lXWWxcQ7fV8ddMVvFHDHk thqqKs2dCmSQ9JWQJXytsiZo9X26q+zODqoOA2zNgKgYr/NqD2V0DG/Gzn+FQacf nPuS6qqW42zESI5dYAHfuhTjV4CxQcgFulv24appIBKs+zpH7norANVsWgjRoxkV wjrOl/Q1BlWPG0YLqQbBsjS3/4BQOO8loqwK/IEkGgGj/+mS7H301/aqNN01Ezwh 0TVzB+J6ohcZac0B2NXGgU8d6uChJqeJZPa+pzZujftHisDC74RDIaPLcrcYF9L4 iiBgHXOIX7b6891xl8CiRcz1k2+RTA== =fdCa -----END PGP SIGNATURE----- --utNxJkBgRyN6C8Jy7jCdpjxeCvzUtAG4Z-- --===============1779443980== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de --===============1779443980==--