From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 04 Mar 2022 10:23:36 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nQ49w-00HPi7-Cs for lore@lore.pengutronix.de; Fri, 04 Mar 2022 10:23:36 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nQ49v-0002me-CA; Fri, 04 Mar 2022 10:23:35 +0100 Received: from mail-eopbgr150040.outbound.protection.outlook.com ([40.107.15.40] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ49Y-0002mI-5t; Fri, 04 Mar 2022 10:23:12 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T7IIwLhwetgWjBoKJhGZL8iAXbKVXAxrfIIl79mscxcBopGbQEwl7kl6jX/D+QHqDhXYR8u/Jov+IqWAWjKPTJ5YiXZkzqNl8ZRmOwVgWcgPhF1NPdg0wQZykQfMmE7cyJkjWgZaNAjm4m1lPOR3NmSY5Q+/Dla4Gh8gbdOZ9Y+ADbO8Jqm98lda+C6x3PXUoMWjBAzod6stYJNegLoJCNBxrS0p0u9kOplX+JveGm4VwDLY06zONyafCnWGz3dJbIZFU0VK0eu5yO1+NeknH7ccLuXYq3igIpaMfjocgoWXdaCIpNeEzEM1L+NAblUSlEY2JwGlhmECWW3P4kMdVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q9q+nMm4HvdkDJ2SceqgqcK7Q/a9wUC6TSaIckUQAh0=; b=D82rICxtLjIjYejjJqTvHf2B/HYyE2au594sPY6lTsru4V2+OAxrAwKK246g5F9j75vr6lddqmI95BYg/93k65TjqtZWC3wJ3eLi443cd2chpbuIY5lMJc2cu0Q1xIRgln+jZ5+GZh/pDNaHvYsVc/tftga9/2s47GPbLYzOdm5IuvV13GxJHVpQ13EZfmZdEnXYm5OWWc0wQ5yUuUCrawyZwyghKwA04anKcZLs219GPVimzCrMPUDapp/G8MeNEq69U8+2tcFxpFB+ZOcfONnBEVXpvWbwpF/MRlxayDdkFfni27HNeVjimq6ei+ELl8PAB0U9Tc6AqKme4GrQJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=t2data.com; dmarc=pass action=none header.from=t2data.com; dkim=pass header.d=t2data.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q9q+nMm4HvdkDJ2SceqgqcK7Q/a9wUC6TSaIckUQAh0=; b=ZMvsHOSYis+xZHmXQCJ09oPGbh/C7dMZcJkCuFQ8H48UDKwgRovdmNc2QWsXOeYEuOGB+9YHQ2GJvTDfdC95whogujA52jMT968TcvHvK8fxlZi3lth5gRHGImHe4ldcgxqhOD7uedM6Ret56huYKfE0i7OIp93yKF7SHmAAogA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=t2data.com; Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) by PAXP251MB0348.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:20b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 09:23:09 +0000 Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::1cba:3835:dd1e:63d3]) by DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::1cba:3835:dd1e:63d3%6]) with mapi id 15.20.5038.014; Fri, 4 Mar 2022 09:23:09 +0000 Message-ID: <02f91621-0e25-565b-566f-c645d0e9fe6e@t2data.com> Date: Fri, 4 Mar 2022 10:21:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Content-Language: en-US To: Michael Olbrich References: <20220303222505.936388-1-christian.melki@t2data.com> From: Christian Melki In-Reply-To: X-ClientProxiedBy: GV3P280CA0028.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:b::8) To DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f23f3ac1-a92e-49aa-8e32-08d9fdc09903 X-MS-TrafficTypeDiagnostic: PAXP251MB0348:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZShZ+oZ7SBh+WscwnmSkIKCAnbEgHyk55zgLrdFQtcPBTdwTpoooaNFxtUHgQbCFBj+ZpCLS5Ba9NK+m1SzbjshRaI1LAFHIcvt1rjtA83XR/kqzsdcL3h/795O+DIeq8zaMxUgp9lXYCDf3mFr+gby99088w3cewUrB+vFlVGYniMxkWpI12uVQShP+6yUsqy8TrdoWEDJIeRUkqyPH23y4P9SX9bJbZB1y4mruGDneojhqkEdJ3n0pnrZ/UkGBOs5pwokVmpiqySu9QoO6TScuTIYPCKRTbJXORt4xetNAxfXD413COh+zXSqTd7uNehYrnCJu4QoEm4G68/rHraSRKoS+D7Prl0VmAPaqtAZ0Zt186VSt1NEBqgvwryzVQYrhm6QDgJUavFAAPrCMULmMy1DXvyFWgc9rMZ+TpDNSXo8ttCuANre8Cd0b7qIgfVEdxJLf7PEuI3VDoztb0368yU5t49pVKHpxucmQY0DWVGj5y19NNmyI+/cEo/I/g1go44WFV0jfri4zypnHNyeVMWKZEIRYZpvVHkkaJLgJvk9shl0wu7TYuZJGBSKhYOFQumBOIoWOEzkdg4XD0pZFvDVQO6/gd4Zy1IIhqZYMyA00IagMjdtEBIjH4lHS9qXM33FHomC6UO8ZIN0aukwoBrtf8+3bEB7GWpWBgBtEJjNHt+ZOLoKuj3tlX5aGAYAdnSkBS+rSH1CNfcSxF0XRECLX9dbJEsnYiL1VhikMczWHU0wp3CD+geT2Kp77VQGfAI4y1Lwd5fDfMuhefA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P251MB0618.EURP251.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(396003)(39830400003)(366004)(376002)(136003)(346002)(66946007)(8676002)(66476007)(36756003)(450100002)(44832011)(66556008)(4326008)(5660300002)(8936002)(38100700002)(38350700002)(86362001)(31696002)(2906002)(83380400001)(6506007)(53546011)(52116002)(26005)(186003)(2616005)(6512007)(6916009)(316002)(508600001)(6486002)(31686004)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3NQUDhnZEFVTGJCeUdCNXdNVkFyUDk4SGlLTWxiYTV6SGEzeWRpNDA5YmhJ?= =?utf-8?B?SHF6R3lXUnEzajd5alBsSFQwdXg4ekRZLzlwTzlnb0dPRmZ2QlFNcEFjQTkw?= =?utf-8?B?ZXlvOU9GMjhSVDg4VFcrbzV2RkRuMnRpNVlyNGExRXFQbW5NRjZCOXpoV0Y3?= =?utf-8?B?TWVIazl4YXE5eE1FMXR2T2JtY1lYY0tiNEpkdmtxSFd0ZVFEVFdEVjlFaXIz?= =?utf-8?B?Q2d5dktyVTRRdG40TWJZQUt6Q1JCNXFVcFhUS0krdlNrWE02a3BWYXBjdFpa?= =?utf-8?B?UXNwUTVLUjRWY01MNi9TdGxkNVZ2cmVVQjFsVEhObnFhbHlvdGhQTFhMdmRJ?= =?utf-8?B?VTQ2dWtUemora1FvbzcwSUxlRy9QNEFFai9XVE1td0psYW56cFVBZDBvSTZV?= =?utf-8?B?U0JMZWJZQTIxTFhHZ2kwYndGRnJiVnBKRVBCczJka2Z6Tk1CNURtdE5vZm9K?= =?utf-8?B?NUE1SGRtQW85RDRTOFRNKy96Q1A1MWFIZC8yaGV4Nk9DY1VQSkx5MzNRZHk4?= =?utf-8?B?QVdLNTB3d0dGMVhSVmZwODNud29ad1p5aWUrcUh1a0VoaEE4L3pxWEplTjhS?= =?utf-8?B?QnRwRU5TSUYxTGN3QUc5UkxubFhROVVObHNoZ1NrUVdlaGFtUkdXQUxINmxu?= =?utf-8?B?NDByOE9EYmpTWXdVTkc4YUVMVGoydkpCaEtCcHluekMwaUNTNXM1YWpjbVIw?= =?utf-8?B?KzJ5N2djVkhGcHJKa3hTTk1QcTRwc3g0OUlETjZVQ2tCdVJodFJOTkQ3ZS9M?= =?utf-8?B?TEpDbVMrZlY2Mm9TbWNJbVVmV3hvU3lSaWpIVFJGWkRxaW0vMXBrcnMwaDhF?= =?utf-8?B?akliaU5rZmJGTVV2TFR5ejlGZjBxM3ZueXJmclA0enMyellOaXBaMXgvdjA1?= =?utf-8?B?NG0vTVZybVVHNXd5WnRBV3ZOaEJXNnR3aWdUOWhlR1gvaXlpRHNnbCtQV0Mw?= =?utf-8?B?azVlRkI4bjJycXlSVlJzUitnVnFXeTh6MXZTeG1oMHYzU2g5Nmk5MEVGMHZi?= =?utf-8?B?V2E3eEs1RENaem5ERlZDanFscjNGN0VFU0ZMVVF4Q0laOGdCZXVMOENFMHdi?= =?utf-8?B?UTJ2SFZHcVdLdTlZSEtvRFUrOGFNSHd2WlRraFpXQjRFN1ZHVVBMUzdtcmVX?= =?utf-8?B?WWtxWW5NSmJzMUlFNURIRmhFZjA4OUJFVm9DSlZMb3NRbCt4ZjVReUxxUUZJ?= =?utf-8?B?ejJuTytsQ1BlajRudTYzS1VVSGlBZnhLZVNmdGxzbUZVMHFIM05GN3J1dnZo?= =?utf-8?B?V212N1ovZVYyVFljWGdYT1BDUXVPV3JxdEFEdWdFN0VoTFFvUmRXMmdLZTEw?= =?utf-8?B?RkUxK1k3Nzg4S0Y5UHp3Z3ppbEV6cS9yUXlaeEZvMGFDQUFSSFJGWDA2TnM1?= =?utf-8?B?M0c1ZzJXU2EybnZsTndhRUpQd08wVm1Jb25KQ2dNWkhLb2ZkeXJwUUZMTlhp?= =?utf-8?B?aHVPSkdYWnJOS2ZtdURBMFE1U2hEcStvT09zVVcyeUxqNzVXZWFzTlpEbVB6?= =?utf-8?B?REwyWW5YdWNlV2lHS2xkd296dlp3TU1nRkQ5ODVqQVl0aWdwdjVhc1lMajkz?= =?utf-8?B?alpVN0t6QkRUYStZUXZWSDRuWmpSdkozUFZqaWNUTDdaVzV3SVlFa2lDeGpx?= =?utf-8?B?VmVNWGRtYkVraE55Zjlwb1A3NHpsNC9pclBwSTB0Zlo1TmNpN1YxZlhDc20v?= =?utf-8?B?NUIwSjVjN3ErMzNMa1gyVUpieGhxMTZzclFZMmh1OWpwYW1mdDlJNVpDNHRm?= =?utf-8?B?aTZvSm5rLzY3STZRcWovdm5Qd2tSQW5uM2lIRS94QW1UaituOFhZSFRGeDk3?= =?utf-8?B?WkJod3hBYW92VnpHYkpBWmdYQkdJcDZwbWRDNjVRR1VNVGlPbThiS0wrUVJY?= =?utf-8?B?bGRSa1pFVXhDRkJ2cThqdVhzVG9WVGgxcjdsQTVDMW82K2NyV1dMVnlOejdM?= =?utf-8?B?cFdLTkVmWEFFeWtmYTB3WWttZTdMVi9hTkdZOW9WWXZKRXBVMzM4SzJaYUpE?= =?utf-8?B?ekR1NHZ3eVBBYjh0SmRQcFo1UVNOSmlnZlZrVUNMZDl5NnNHODFnQ2lKeGhT?= =?utf-8?B?RGxMcExwc2xEMjAvNG14aWlZc09yRFFHMUVmdlhQODZtTjFzTHlvU0lITGNK?= =?utf-8?B?cUxwMnZNR29NOWVOY0FuMGZHSEFzRHc5eCtwMGFsTzM2TVRvejZ4ODdwdW9i?= =?utf-8?B?ekhQQnk0YXFIdkdvM2JHTFVhQTNYTWdHbm5Tb1ZQeGQ4RzVTdC9Wc3FGNXZQ?= =?utf-8?Q?UDtDDjBEFdkDW5Ot+5m1F6IKVlIpLEQyfF3m3EKJ0w=3D?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: f23f3ac1-a92e-49aa-8e32-08d9fdc09903 X-MS-Exchange-CrossTenant-AuthSource: DB9P251MB0618.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 09:23:09.3737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ALzDmvyZLm+pm9Qy45l7OyZbceLlcUU/pYd0bdOTflIXpoGm2JicsB7J54m5KjwUIbmPX5PdvghpAksvzWqlzcGGXq6Bm2oM4AGmZ3lPNeI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP251MB0348 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] image-root-cpio: Add compressor options to the env. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 3/4/22 10:09 AM, Michael Olbrich wrote: > On Thu, Mar 03, 2022 at 11:25:05PM +0100, Christian Melki wrote: >> * xz needs crc32 instead of crc64 for the kernel cpio. > > Good point. I didn't know about that. > >> * Set zstd compression level to the same as for the kernel (19). > > Makes sense. > >> * Use multithreading for zstd (deterministic, afaiu). > > It is. I looked into this because I was curious. And it makes sense. zstd > was developed at a time when reproducibility was already important. > >> Actively decided against -T0 for xz, as compression >> is not deterministic when number of threads varies. > > We definitively want to be reproducible here. > >> Signed-off-by: Christian Melki >> --- >> rules/image-root-cpio.make | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/rules/image-root-cpio.make b/rules/image-root-cpio.make >> index fdb0ccfff..eb09dd53e 100644 >> --- a/rules/image-root-cpio.make >> +++ b/rules/image-root-cpio.make >> @@ -26,6 +26,9 @@ IMAGE_ROOT_CPIO_CONFIG := cpio.config >> >> IMAGE_ROOT_CPIO_ENV := \ >> FORMAT="newc" \ >> + ZSTD_CLEVEL="19" \ >> + ZSTD_NBTHREADS="0" \ >> + XZ_OPT="--check=crc32" \ >> COMPRESS=$(call remove_quotes, $(PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_UTIL)) > > Add the options to the PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_UTIL defaults > and keep the quotes here: > > COMPRESS=$(PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_UTIL) > > genimage explicitly does not quote to make to possible to specify the > compressor with options. At least I thinks that should work. > > And maybe we could add a IMAGE_ROOT_CPIO_COMPRESSION_MODE_CUSTOM and then > add 'prompt "suffix" if IMAGE_ROOT_CPIO_COMPRESSION_MODE_CUSTOM' to the > suffix and similar for the util. > > This way the user could tweak things if absolutely necessary. > > What do you think? I don't mind, will fix. But custom compressors will be outside of the ptxdist dependency scope for building host binaries? I can make a note about it in the help? > > Michael > >> >> ifdef PTXCONF_IMAGE_ROOT_CPIO >> -- >> 2.30.2 >> >> >> _______________________________________________ >> ptxdist mailing list >> ptxdist@pengutronix.de >> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de >> > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de